fix: reliable deletion of node_modules #12874
Merged
+99
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Jan 28, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 28, 2022
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810
caalador
pushed a commit
that referenced
this pull request
Jan 28, 2022
Do not set permissions nor follow symlinks when deleting node_modules. Fixes #12810 Co-authored-by: Johannes Eriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set permissions nor follow symlinks when
deleting node_modules.
Combines eab25b3 and 415b7c7 for Flow 2.8.
Fixes #12810