Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: better exception for failing removal (#12659) (CP: 2.7) #12668

Merged
merged 1 commit into from
Jan 3, 2022
Merged

fix: better exception for failing removal (#12659) (CP: 2.7) #12668

merged 1 commit into from
Jan 3, 2022

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

@caalador @vaadin-bot
fix: better exception for failing removal (#12659)
f5edf0f 
Update exception for failing to
remove node_modules folder.

Closes #12655
@vaadin-bot
Copy link
Collaborator Author

SonarQube analysis reported 3 issues

  1. MAJOR TaskRunNpmInstall.java#L93: Remove this unused "classFinder" private field. rule
  2. MINOR TaskRunNpmInstall.java#L245: Immediately return this expression instead of assigning it to the temporary variable "versionsJson". rule
  3. MINOR TaskRunNpmInstall.java#L492: Remove the declaration of thrown exception 'java.lang.IllegalStateException' which is a runtime exception. rule

@vaadin-bot
Copy link
Collaborator Author

This PR is eligible for auto-merging policy, so it has been approved automatically.[Message is sent from bot]

@vaadin-bot vaadin-bot merged commit f182faa into 2.7 Jan 3, 2022
@vaadin-bot
Copy link
Collaborator Author

This PR has been merged with 'squash' method.[Message is sent from bot]

@vaadin-bot vaadin-bot deleted the cherry-pick-12659-to-2.7-1641217965308 branch January 3, 2022 14:47
@vaadin-bot
Copy link
Collaborator Author

This ticket/PR has been released with platform 14.8.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaadin-review-bot vaadin-review-bot vaadin-review-bot approved these changes

Assignees
No one assigned
Labels
Released with Platform 14.8.2 +0.0.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vaadin-bot @vaadin-review-bot @caalador