Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: outdated links to production mode docs #12553

Merged
merged 2 commits into from
Dec 10, 2021
Merged

Conversation

tarekoraby
Copy link
Contributor

No description provided.

@tarekoraby tarekoraby changed the title Fix outdated link to production mode docs fix: outdated links to production mode docs Dec 10, 2021
@vaadin-bot
Copy link
Collaborator

SonarQube analysis reported 4 issues

  1. MAJOR DefaultDeploymentConfiguration.java#L329: Merge this if statement with the enclosing one. rule
  2. MAJOR AbstractConfigurationFactory.java#L73: Refactor this method to reduce its Cognitive Complexity from 20 to the 15 allowed. rule
  3. MINOR DefaultDeploymentConfiguration.java#L305: Replace this lambda with a method reference. rule
  4. MINOR DefaultDeploymentConfiguration.java#L309: Remove useless curly braces around statement rule

@tarekoraby tarekoraby enabled auto-merge (squash) December 10, 2021 09:17
@github-actions
Copy link

Unit Test Results

   720 files     720 suites   22m 30s ⏱️
5 648 tests 5 598 ✔️ 50 💤 0
5 664 runs  5 614 ✔️ 50 💤 0

Results for commit a66c1f1.

@tarekoraby tarekoraby merged commit 5ec8ddd into master Dec 10, 2021
@tarekoraby tarekoraby deleted the tarekoraby-patch-1-1 branch December 10, 2021 09:20
@vaadin-bot
Copy link
Collaborator

Hi @tarekoraby and @tarekoraby, when i performed cherry-pick to this commit to 2.8, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5ec8ddd
error: could not apply 5ec8ddd... fix: outdated links to production mode docs (#12553)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

vaadin-bot pushed a commit that referenced this pull request Dec 10, 2021
* Fix outdated link to production mode docs

* Fix outdated link to production mode docs
@vaadin-bot
Copy link
Collaborator

Hi @tarekoraby and @tarekoraby, when i performed cherry-pick to this commit to 2.7, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 5ec8ddd
error: could not apply 5ec8ddd... fix: outdated links to production mode docs (#12553)
hint: after resolving the conflicts, mark the corrected paths
hint: with 'git add ' or 'git rm '
hint: and commit the result with 'git commit'

@tarekoraby
Copy link
Contributor Author

@caalador what does the above message by vaadin-bot mean? Does something have to be done?

@caalador
Copy link
Contributor

As we would want to have the link fixed also in 2.7 and 2.8 branches (so vaadin 14) the bot tried to do a cherry pick, but there was some merge issue so it needs to be picked manually.

I can do the pick for this.

caalador added a commit that referenced this pull request Dec 13, 2021
vaadin-bot pushed a commit that referenced this pull request Dec 13, 2021
manolo pushed a commit that referenced this pull request Dec 13, 2021
* Fix outdated link to production mode docs

* Fix outdated link to production mode docs

Co-authored-by: Tarek Oraby <[email protected]>
vaadin-bot added a commit that referenced this pull request Dec 15, 2021
Co-authored-by: Tarek Oraby <[email protected]>

Co-authored-by: caalador <[email protected]>
Co-authored-by: Tarek Oraby <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants