refactor: make isAttached iterative #12665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees.
joheriks
force-pushed
the
isattached-iterative
branch
from
d9f59af to
0b983a5
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
caalador
approved these changes
Jan 7, 2022
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees.
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees.
vaadin-bot
pushed a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees.
vaadin-bot
added a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees. Co-authored-by: Johannes Eriksson <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees. Co-authored-by: Johannes Eriksson <[email protected]>
vaadin-bot
added a commit
that referenced
this pull request
Jan 7, 2022
Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees. Co-authored-by: Johannes Eriksson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since isAttached is trivially tail-recursive, use a loop instead of recursion.
Reduces memory consumption in tests that construct deep trees.