refactor: make isAttached iterative (#12665) (#12683)

Since isAttached is trivially tail-recursive, use a loop instead of recursion. Reduces memory consumption in tests that construct deep trees. Co-authored-by: Johannes Eriksson <[email protected]>
vaadin · Jan 7, 2022 · 04a1ca6 · 04a1ca6
1 parent 3b733c9
commit 04a1ca6
Showing 1 changed file with 9 additions and 1 deletion.
diff --git a/flow-server/src/main/java/com/vaadin/flow/internal/StateNode.java b/flow-server/src/main/java/com/vaadin/flow/internal/StateNode.java
@@ -567,7 +567,15 @@ public void markAsDirty() {
      *         this node is not attached
      */
     public boolean isAttached() {
-        return parent != null && parent.isAttached();
+        if (getParent() == null) {
+            return false;
+        } else {
+            StateNode root = getParent();
+            while (root.getParent() != null) {
+                root = root.getParent();
+            }
+            return root.isAttached();
+        }
     }
 
     /**