chore: Change debug level to info as this logging is frequent in harmless cases #13400
Conversation
|
Kudos, SonarCloud Quality Gate passed!
|
|
Should this even be |
...ver/src/main/java/com/vaadin/flow/server/communication/rpc/AbstractRpcInvocationHandler.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
@TatuLund I had an another and more deep look into AbstractRpcInvocationHandler::handle method. Changing warn to debug seems a fine solution, because:
- When the
nodedoes not exist on the server state tree, the server basically has no information why, therefore it cannot decide whether log the message and what level to choose, and what do with it in the end. - When the
nodeis detached, IMO it doesn't make sense to figure out why it is detached. We can probably check if thenodecorresponds toHasValuecomponent, but it is a "private" case when such a warnings occur. - As Artur said, and I agree with him, these warn message doesn't give a clear understanding of what is broken or what's wrong with the caller's code. But it can be useful for development, debugging or anomaly investigation.
So in short I propose to setdebuglevel and apply this patch.
...ver/src/main/java/com/vaadin/flow/server/communication/rpc/AbstractRpcInvocationHandler.java
Outdated
Show resolved
Hide resolved
...ver/src/main/java/com/vaadin/flow/server/communication/rpc/AbstractRpcInvocationHandler.java
Outdated
Show resolved
Hide resolved
|
Kudos, SonarCloud Quality Gate passed!
|
|
Hi @TatuLund and @mshabarov, when i performed cherry-pick to this commit to 9.0, i have encountered the following issue. Can you take a look and pick it manually? |
…less cases (#13400) (#13798) Closes: vaadin/flow-components#1157 Co-authored-by: Tatu Lund <[email protected]>
…less cases (#13400) (#13799) Closes: vaadin/flow-components#1157 Co-authored-by: Tatu Lund <[email protected]>
…less cases (#13400) (#13799) Closes: vaadin/flow-components#1157 Co-authored-by: Tatu Lund <[email protected]>
…less cases (#13400) (#13799) Closes: vaadin/flow-components#1157 Co-authored-by: Tatu Lund <[email protected]>
Closes: vaadin/flow-components#1157