Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix references to logsdb index mode in release highlights #1

Closed
wants to merge 182 commits into from

Conversation

lkts
Copy link
Owner

@lkts lkts commented Aug 13, 2024

elasticsearchmachine and others added 30 commits July 4, 2024 09:46
…c#110492)

This PR was reviewed in elastic#109275

Block and Vector use a non-thread-safe RefCounted. Threads that increase
or decrease the references must have a happen-before relationship.
However, this order is not guaranteed in the enrich lookup for the
reference of selectedPositions. The driver can complete the
MergePositionsOperator, which decreases the reference count of
selectedPositions, while the finally block may also decrease it in a
separate thread. These actions occur without a defined happen-before
relationship.

Closes elastic#108532
These are the docs changes in relation to
elastic#108733
Bit vector tests were failing in cases where an index has more than 1 shards.
For error cases when we expected a failure of the whole request, shards
with empty documents returned success and the whoel request unexpectedly returned 200.

Ensuring that index contains only 1 shard fixes these failures.

Closes elastic#110290, elastic#110291
This change makes the three-parameter constructor of ToPartial public so 
that EsqlNodeSubclassTests can pick it up properly.

Closes elastic#110310
…c#110550)

Currently, read_slm privilege grants access to get the ILM status,
and manage_slm grants access to start/stop ILM. This access will
be removed in the future, but needs to be deprecated before
removal. Add deprecation warning to the read_slm and manage_slm docs.
…110248) (elastic#110545)

* Initial commit; setup Gradle; start service

* initial commit

* minor cleanups, builds green; needs tests

* bug fixes; tested working embeddings & completion

* use custom json builder for embeddings request

* Ensure auto-close; fix forbidden API

* start of adding unit tests; abstraction layers

* adding additional tests; cleanups

* add requests unit tests

* all tests created

* fix cohere embeddings response

* fix cohere embeddings response

* fix lint

* better test coverage for secrets; inference client

* update thread-safe syncs; make dims/tokens + int

* add tests for dims and max tokens positive integer

* use requireNonNull;override settings type;cleanups

* use r/w lock for client cache

* remove client reference counting

* update locking in cache; client errors; noop doc

* remove extra block in internalGetOrCreateClient

* remove duplicate dependencies; cleanup

* add fxn to get default embeddings similarity

* use async calls to Amazon Bedrock; cleanups

* use Clock in cache; simplify locking; cleanups

* cleanups around executor; remove some instanceof

* cleanups; use EmbeddingRequestChunker

* move max chunk size to constants

* oof - swapped transport vers w/ master node req

* use XContent instead of Jackson JsonFactory

* remove gradle versions; do not allow dimensions
Currently, if a child request fails, we automatically trigger  cancellation
for ES|QL requests. This can result in TaskCancelledException being
collected by the RefCountingListener first, which then returns that
exception to the caller. For example, if we encounter a
CircuitBreakingException (429), we might incorrectly return a
TaskCancelledException (400) instead.

This change introduces the ComputeListener, a variant of
RefCountingListener, which selects the most appropriate exception to return
to the caller. I also integrated the following features into ComputeListener to
simplify ComputeService:

- Automatic cancellation of sub-tasks on failure.
- Collection of profiles from sub-tasks.
- Collection of response headers from sub-tasks.
…10567)

Adding `parent task was cancelled [test cancel]` to the list 
of allowed cancellation messages.
…10589) (elastic#110608)

closes elastic#110357

With the loosening of what is considered a unit vector, we need to
ensure we only normalize for equality checking if the query vector is
indeed not a unit vector.

(cherry picked from commit fd790ff)
ComputeResponse from old nodes may have a null value instead of an empty
list for profiles.

Relates elastic#110400 Closes elastic#110591
Currently, we incorrectly remove the `@timestamp` attribute from
the EsRelation when translating metric aggregates.
…#110592) (elastic#110624)

Fixes error using the Amazon Bedrock service with a large 
input that was chunked.
CCS tests could split the vectors over any number of shards. Through
empirical testing, I determined this commits values work to provide the
expected order, even if they are not all part of the same shard.

quantization can have weird behaviors when there are uniform values,
just like this test does.

closes elastic#109978

(cherry picked from commit 9dbe97b)
Partial backport from elastic#110586

Just the Max fix and an extra test for it.
….xcore (elastic#110565) (elastic#110642)

The types from com.nimbusds.jwt are almost not needed in x-pack/plugin/core.
They're only needed in module org.elasticsearch.security, x-pack:plugin:security project.
…0670)

We've already removed Windows-specific BWC jobs in our periodic
pipelines. They shouldn't behave differently and are very prone to
timeouts so let's just remove them from pull requests when the
`test-windows` label is added.
szabosteve and others added 27 commits August 7, 2024 21:20
…#111595)

Ocassionally we see a LISTING.TXT not included in the jar. The cause
seems a timing issue with sync task were target root folder is same
folder as folder containing listing.txt.
…lastic#111725) (elastic#111728)

The `java.security.manager=allow` system property is required when
running tests on newer Java versions with the security manager
deprecated. As such, it should be set in our
`GradleTestPolicySetupPlugin` so that it's done for external plugin
authors.
…elastic#111475) (elastic#111735)

Fix validation of fields mapped to different types in different indices and align with validation of fields of unsupported type.

* Allow using multi-typed fields in KEEP and DROP, just like unsupported fields.
* Explicitly invalidate using both these field kinds in RENAME.
* Map both kinds of fields to UnsupportedAttribute to enforce consistency.
* Consider convert functions containing valid multi-typed fields as resolved to avoid weird workarounds when resolving STATS.
* Add a bunch of tests.

(cherry picked from commit 585480f)

# Conflicts:
#	x-pack/plugin/esql/qa/testFixtures/src/main/resources/union_types.csv-spec
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/analysis/Analyzer.java
#	x-pack/plugin/esql/src/main/java/org/elasticsearch/xpack/esql/plan/logical/Stats.java
…elastic#111646)

* Move DeleteInferenceAction pipeline check to utility threadpool

* Update docs/changelog/111646.yaml

* Update docs/changelog/111646.yaml

Co-authored-by: David Kyle <[email protected]>

---------

Co-authored-by: David Kyle <[email protected]>
…astic#111759)

Fix elastic#111753

(cherry picked from commit f0d06ee)

# Conflicts:
#	muted-tests.yml
#	x-pack/plugin/esql/src/test/java/org/elasticsearch/xpack/esql/analysis/VerifierTests.java
elastic#111761)

This reverts elastic#110261 which we can't land until elastic#111757 - we need to be
sure that the `equals` implementations on subclasses of
`InternalAggregations` is correct before this optimization is safe.

Closes elastic#111679
…without dims (elastic#111756) (elastic#111763)

* Fix NullPointerException when doing knn search on empty index without dims (elastic#111756)

* Fix NullPointerException when doing knn search on empty index without dims

* Update docs/changelog/111756.yaml

* Fix typo in yaml test

---------

Co-authored-by: Elastic Machine <[email protected]>
(cherry picked from commit 4e26114)

# Conflicts:
#	rest-api-spec/src/yamlRestTest/resources/rest-api-spec/test/search.vectors/40_knn_search.yml

* Update 40_knn_search.yml

* Yaml
This change ensures that we don't try to compute stats on mappings that don't have dense or sparse vector fields. We don't need to go through all the fields on every segment, instead we can extract the vector fields upfront and limit the work to only indices that define these types.

Closes elastic#111715
Since apache/lucene-solr#620, intervals disjunctions are automatically rewritten to handle cases where minimizations can miss valid matches.
This change updates the documentation to take this behaviour into account (users don't need to manually pull intervals disjunctions to the top anymore).
…11825)

Spells out some cases in which ILM doesn't delete the underlying
searchable snapshot and instructs users to delete them manually instead.

Co-authored-by: shainaraskas <[email protected]>
@lkts lkts closed this Aug 13, 2024
@lkts lkts deleted the fix_logsdb_highlight branch August 14, 2024 01:48
lkts pushed a commit that referenced this pull request Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.