Fix flaky test #109978 #110245
Fix flaky test #109978 #110245
Conversation
benwtrent
added
>test
|
Pinging @elastic/es-search (Team:Search) |
elasticsearchmachine
added
Team:Search
benwtrent
added
the
auto-merge-without-approval
|
@elasticmachine update branch |
muted-tests.yml
Outdated
| @@ -97,9 +97,6 @@ tests: | |||
| - class: "org.elasticsearch.xpack.searchablesnapshots.FrozenSearchableSnapshotsIntegTests" | |||
| issue: "https://github.com/elastic/elasticsearch/issues/110408" | |||
| method: "testCreateAndRestorePartialSearchableSnapshot" | |||
| - class: org.elasticsearch.test.rest.yaml.CcsCommonYamlTestSuiteIT | |||
| method: test {p0=search.vectors/41_knn_search_half_byte_quantized/Test create, merge, and search cosine} | |||
There was a problem hiding this comment.
In the test we use an index with number_of_shards: 1; do CCS tests override that / create different settings?
There was a problem hiding this comment.
@pmpailis CCS means more than one cluster. So by definition, even if an index has only one shard, the docs could be split across different indices on different clusters.
There was a problem hiding this comment.
Ah fair enough! Not having to do with the test specifically, but I thought that we could have some instances with more than one shards, so I was wondering if there was any weird override for the yaml tests.
There was a problem hiding this comment.
Yeah, the number of shards is still 1 for all the indices over all the clusters, its just now spread over more than one cluster :)
...mlRestTest/resources/rest-api-spec/test/search.vectors/41_knn_search_half_byte_quantized.yml
Show resolved
Hide resolved
💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
CCS tests could split the vectors over any number of shards. Through empirical testing, I determined this commits values work to provide the expected order, even if they are not all part of the same shard. quantization can have weird behaviors when there are uniform values, just like this test does. closes elastic#109978 (cherry picked from commit 9dbe97b)
CCS tests could split the vectors over any number of shards. Through empirical testing, I determined this commits values work to provide the expected order, even if they are not all part of the same shard. quantization can have weird behaviors when there are uniform values, just like this test does. closes #109978 (cherry picked from commit 9dbe97b)
CCS tests could split the vectors over any number of shards. Through empirical testing, I determined this commits values work to provide the expected order, even if they are not all part of the same shard.
quantization can have weird behaviors when there are uniform values, just like this test does.
closes #109978