-
Notifications
You must be signed in to change notification settings - Fork 24.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Expands top_n parameter description in the PUT inference API docs #111446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szabosteve
added
>docs
General docs changes
Team:Docs
Meta label for docs team
auto-backport-and-merge
v8.15.0
:SearchOrg/Inference
Label for the Search Inference team
Team:Search - Inference
v8.16.0
labels
Jul 30, 2024
Documentation preview: |
elasticsearchmachine
added
the
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
label
Jul 30, 2024
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/search-inference-team (Team:Search - Inference) |
Pinging @elastic/ent-search-eng (Team:SearchOrg) |
Co-authored-by: Adam Demjen <[email protected]>
szabosteve
commented
Jul 30, 2024
maxhniebergall
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks Istvan
@elasticsearchmachine test this please |
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 30, 2024
…ocs (#111446) (#111454) Co-authored-by: Adam Demjen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
:SearchOrg/Inference
Label for the Search Inference team
Team:Docs
Meta label for docs team
Team:Search - Inference
Team:SearchOrg
Meta label for the Search Org (Enterprise Search)
v8.15.0
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR expands the
top_n
parameter description with the behavior if the parameter is set to a greater number than the number of documents to rerank.