Fixing EnterpriseGeoIpDownloaderIT #111080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
elasticsearchmachine
added
the
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
joegallo
approved these changes
Jul 19, 2024
💔 Backport failed
You can use sqren/backport to manually backport by running |
joegallo
pushed a commit
to joegallo/elasticsearch
that referenced
this pull request
Jul 19, 2024
joegallo
added a commit
that referenced
this pull request
Jul 19, 2024
Co-authored-by: Keith Massey <[email protected]>
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen EnterpriseGeoIpDownloaderIT fail because documents are ingested that have not had geoip information added. I think that this is because the ingest happens before the geoip database has been retrieved. This change does the ingest-and-check in an assertBusy to handle that case.
Closes #111002.