Inject host.name field without relying on (component) templates
#110938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
salvatore-campagna
added
:StorageEngine/Logs
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
|
Hi @salvatore-campagna, I've created a changelog YAML for you. |
salvatore-campagna
force-pushed
the
fix/logsdb-host-name-mappings
branch
2 times, most recently
from
6217258
to
b1c4f9e
Compare
|
Hi @salvatore-campagna, I've created a changelog YAML for you. |
|
@elasticsearchmachine test this please |
felixbarny
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
LGTM. Depending on how we'll implement #110792, we may not need to inject the host.name field in the future anymore.
salvatore-campagna
added
auto-backport
|
So I disabled the failing CI test |
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 18, 2024
…astic#110938) We do not want to rely on templates or component templates to include the host.name field in indices using LogsDB. The host.name field is a field we sort on by default when LogsDB is used. As a result, we just inject it by default, the same way we do for the @timestamp field. This prevents sorting errors due to missing host.name field in mappings. The host.name is a keyword field and depending on the value of subobjects it will be mapped as a name keyword nested inside a host or as a flat host.name keyword. We also include ignore_above as we normally do for keywords in observability mappings.
💚 Backport successful
|
salvatore-campagna
added a commit
that referenced
this pull request
Jul 18, 2024
…tes (#110938) (#111031) * Inject `host.name` field without relying on (component) templates (#110938) We do not want to rely on templates or component templates to include the host.name field in indices using LogsDB. The host.name field is a field we sort on by default when LogsDB is used. As a result, we just inject it by default, the same way we do for the @timestamp field. This prevents sorting errors due to missing host.name field in mappings. The host.name is a keyword field and depending on the value of subobjects it will be mapped as a name keyword nested inside a host or as a flat host.name keyword. We also include ignore_above as we normally do for keywords in observability mappings. * Enable missing hostname test
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
…astic#110938) We do not want to rely on templates or component templates to include the host.name field in indices using LogsDB. The host.name field is a field we sort on by default when LogsDB is used. As a result, we just inject it by default, the same way we do for the @timestamp field. This prevents sorting errors due to missing host.name field in mappings. The host.name is a keyword field and depending on the value of subobjects it will be mapped as a name keyword nested inside a host or as a flat host.name keyword. We also include ignore_above as we normally do for keywords in observability mappings.
salvatore-campagna
added a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
…astic#110938) We do not want to rely on templates or component templates to include the host.name field in indices using LogsDB. The host.name field is a field we sort on by default when LogsDB is used. As a result, we just inject it by default, the same way we do for the @timestamp field. This prevents sorting errors due to missing host.name field in mappings. The host.name is a keyword field and depending on the value of subobjects it will be mapped as a name keyword nested inside a host or as a flat host.name keyword. We also include ignore_above as we normally do for keywords in observability mappings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not want to rely on templates or component templates to include
the
host.namefield in indices using LogsDB. Thehost.namefield is a fieldwe sort on by default when LogsDB is used. As a result, we just inject it
by default, the same way we do for the
@timestampfield. This preventssorting errors due to missing
host.namefield in mappings.The
host.nameis a keyword field and depending on the value ofsubobjectsit willbe mapped as a
namekeyword nested inside ahostor as a flathost.namekeyword.We also include
ignore_aboveas we normally do for keywords in observability mappings.