Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make skip_unavailable=true a notable change instead of breaking change #110983

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Make skip_unavailable=true a notable change instead of breaking change #110983

merged 1 commit into from
Jul 18, 2024

Conversation

naj-h
Copy link
Contributor

@naj-h naj-h commented Jul 17, 2024

  • Have you signed the contributor license agreement?
  • Have you followed the contributor guidelines?
  • If submitting code, have you built your formula locally prior to submission with gradle check?
  • If submitting code, is your pull request against main? Unless there is a good reason otherwise, we prefer pull requests against main and will backport as needed.
  • If submitting code, have you checked that your submission is for an OS and architecture that we support?
  • If you are submitting this code for a class then read our policy for that.

@elasticsearchmachine elasticsearchmachine added needs:triage Requires assignment of a team area label v8.16.0 labels Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

@naj-h please enable the option "Allow edits and access to secrets by maintainers" on your PR. For more information, see the documentation.

@elasticsearchmachine elasticsearchmachine added the external-contributor Pull request authored by a developer outside the Elasticsearch team label Jul 17, 2024
@mayya-sharipova mayya-sharipova added :Search Foundations/Search Catch all for Search Foundations and removed needs:triage Requires assignment of a team area label labels Jul 17, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-search-foundations (Team:Search Foundations)

@elasticsearchmachine elasticsearchmachine added the Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch label Jul 17, 2024
@naj-h
Copy link
Contributor Author

naj-h commented Jul 18, 2024

@javanna @stansv this is the PR to change this from notable: false to notable: true, to make it a notable change rather than a breaking change. You can see the version label 8.16.0 was applied when we actually need this in 8.15.0 doc, how do I go about this?

@javanna javanna added the >docs General docs changes label Jul 18, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jul 18, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

javanna
javanna approved these changes Jul 18, 2024
View reviewed changes
Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@naj-h naj-h added v8.15.0 auto-backport Automatically create backport pull requests when merged labels Jul 18, 2024
@naj-h naj-h merged commit 1727432 into main Jul 18, 2024
6 checks passed
@naj-h naj-h deleted the naj-h-patch-1 branch July 18, 2024 14:20
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 110983

javanna pushed a commit to javanna/elasticsearch that referenced this pull request Jul 18, 2024
@naj-h @javanna
Make skip_unavailable=true a notable change instead of breaking change (
8052ff6 
elastic#110983)
@javanna javanna added :Search Foundations/CCS and removed :Search Foundations/Search Catch all for Search Foundations labels Jul 18, 2024
@javanna javanna mentioned this pull request Jul 18, 2024
Merged
javanna added a commit that referenced this pull request Jul 18, 2024
@javanna @naj-h
Make skip_unavailable=true a notable change instead of breaking change (
b186ee9 
#110983)

Co-authored-by: Najwa Harif <[email protected]>
ioanatia pushed a commit to ioanatia/elasticsearch that referenced this pull request Jul 22, 2024
@naj-h @ioanatia
Make skip_unavailable=true a notable change instead of breaking change (
3677a9b 
elastic#110983)
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request Jul 23, 2024
@naj-h @salvatore-campagna
Make skip_unavailable=true a notable change instead of breaking change (
b60f9f1 
elastic#110983)
salvatore-campagna pushed a commit to salvatore-campagna/elasticsearch that referenced this pull request Jul 23, 2024
@naj-h @salvatore-campagna
Make skip_unavailable=true a notable change instead of breaking change (
b2f678f 
elastic#110983)
@lkts lkts mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javanna javanna javanna approved these changes

@quux00 quux00 Awaiting requested review from quux00

Assignees
No one assigned
Labels
auto-backport Automatically create backport pull requests when merged backport pending >docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team :Search Foundations/CCS Team:Docs Meta label for docs team Team:Search Foundations Meta label for the Search Foundations team in Elasticsearch v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@naj-h @elasticsearchmachine @javanna @mayya-sharipova