Adding a unit test for GeoIpDownloader.cleanDatabases #110650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
elasticsearchmachine
added
the
Team:Data Management
joegallo
reviewed
Jul 9, 2024
| /* | ||
| * The following two lines assert current behavior that might not be desirable -- we continue to delete expired databases every | ||
| * time that runDownloader runs. This seems unnecessary. | ||
| */ |
There was a problem hiding this comment.
Agreed, this current behavior seems unintentional to me.
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 9, 2024
Co-authored-by: Joe Gallo <[email protected]>
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 9, 2024
) Co-authored-by: Joe Gallo <[email protected]>
masseyke
added a commit
to masseyke/elasticsearch
that referenced
this pull request
Jul 11, 2024
elastic#110675) Co-authored-by: Joe Gallo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a unit test for GeoIpDownloader::runDownloader, specifically testing the behavior of the cleanDatabases() method that runDownloader() calls.