Fix Dissect with leading non-ascii characters #111184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luigidellaquila
added
>bug
:Data Management/Ingest Node
elasticsearchmachine
added
Team:Data Management
|
Pinging @elastic/es-data-management (Team:Data Management) |
|
Hi @luigidellaquila, I've created a changelog YAML for you. |
|
@elasticmachine run elasticsearch-ci/part-3 |
alex-spies
approved these changes
Jul 23, 2024
libs/dissect/src/test/java/org/elasticsearch/dissect/DissectParserTests.java
Outdated
Show resolved
Hide resolved
|
@elasticmachine run elasticsearch-ci/bwc-snapshots |
|
@elasticmachine update branch |
masseyke
approved these changes
Jul 23, 2024
💚 Backport successful
|
luigidellaquila
added a commit
to luigidellaquila/elasticsearch
that referenced
this pull request
Jul 23, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 23, 2024
Co-authored-by: Elastic Machine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing ES|QL we noticed that a Dissect pattern with leading non-ascii characters, eg.
(see the
ü)returned wrong results.
Eg. for an input like
it returned
largest, with an additional blank space at the beginning.This PR fixes the problem in the
DissectParser