Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOCS Query Roles #110473

Merged
merged 11 commits into from
Jul 5, 2024
Merged

Conversation

albertzaharovits
Copy link
Contributor

@albertzaharovits albertzaharovits commented Jul 4, 2024

These are the docs changes in relation to #108733

@albertzaharovits albertzaharovits self-assigned this Jul 4, 2024
@albertzaharovits albertzaharovits added the >docs General docs changes label Jul 4, 2024
Copy link
Contributor

github-actions bot commented Jul 4, 2024

Documentation preview:

@albertzaharovits albertzaharovits added :Security/Security Security issues without another label v8.15.0 labels Jul 4, 2024
@albertzaharovits albertzaharovits marked this pull request as ready for review July 4, 2024 13:34
@elasticsearchmachine elasticsearchmachine added the Team:Docs Meta label for docs team label Jul 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine elasticsearchmachine added the Team:Security Meta label for security team label Jul 4, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just some non-blocking nits.

[%collapsible%open]
====
`name`::
The <<security-api-put-role-path-params,name>> of the role, which is internally indexed as a keyword.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit (optional): not sure if the ", which is internally indexed as a keyword." is needed. Maybe use the (type) prefix instead, so:

(keyword) The <<security-api-put-role-path-params,name>> of the role

Same comment for all the fields.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thanks!

role.
role. The returned role format is a simple extension of the <<defining-roles,role definition>> format,
only adding an extra field `transient_metadata.enabled`.
This field is `false` in case the role is automatically disabled, for e.g. in case the license
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
This field is `false` in case the role is automatically disabled, for e.g. in case the license
This field is `false` in case the role is automatically disabled, for example when the license

Comment on lines 125 to 126
The following request lists all roles, sorted by the role name.
This assumes you have the `read_security` <<privileges-list-cluster,privilege>>:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
The following request lists all roles, sorted by the role name.
This assumes you have the `read_security` <<privileges-list-cluster,privilege>>:
The following request lists all roles, sorted by the role name:

@@ -93,6 +86,12 @@ In addition, sort can also be applied to the `_doc` field to sort by index order
`search_after`::
(Optional, array) <<search-after,Search after>> definition.

[[security-api-query-user-query-params]]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the bonus updates!

<titleabbrev>Query Role</titleabbrev>
++++

Retrieves roles with <<query-dsl,Query DSL>> in a <<paginate-search-results,paginated>> fashion.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@albertzaharovits For completeness sake wondering if we should mention that you can't query reserved roles, only native ones somewhere.

Copy link
Contributor Author

@albertzaharovits albertzaharovits Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@n1v0lg Does that look OK for you: 57675dd ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 looks great

@albertzaharovits albertzaharovits added auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) auto-backport-and-merge labels Jul 5, 2024
@elasticsearchmachine elasticsearchmachine merged commit 747fa59 into elastic:main Jul 5, 2024
5 checks passed
@albertzaharovits albertzaharovits deleted the query-roles-docs branch July 5, 2024 09:47
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

albertzaharovits added a commit to albertzaharovits/elasticsearch that referenced this pull request Jul 5, 2024
These are the docs changes in relation to
elastic#108733
elasticsearchmachine pushed a commit that referenced this pull request Jul 5, 2024
These are the docs changes in relation to
#108733
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) >docs General docs changes :Security/Security Security issues without another label Team:Docs Meta label for docs team Team:Security Meta label for security team v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants