Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] Ensure vector similarity correctly limits inner_hits returned for nested kNN (#111363) #111426

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

benwtrent
Copy link
Member

Backport

This will backport the following commits from main to 8.15:

Questions ?

Please refer to the Backport tool documentation

…ted kNN (elastic#111363)

For nested kNN we support not only similarity thresholds, but also
multi-passage search while retrieving more than one nearest passage.

However, the inner_hits retrieved for the kNN search would ignore the
restricted similarity. Meaning, the inner hits would return all
passages, not just the ones within the limited similarity and this is
confusing.

closes: elastic#111093
(cherry picked from commit 69c9697)
@benwtrent benwtrent merged commit 155eee6 into elastic:8.15 Jul 29, 2024
14 checks passed
@benwtrent benwtrent deleted the backport/8.15/pr-111363 branch July 29, 2024 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants