Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.15] [Inference API] Add Amazon Bedrock support to Inference API (#110248) #110545

Merged

Conversation

markjhoy
Copy link
Contributor

@markjhoy markjhoy commented Jul 5, 2024

Backports the following commits to 8.15:

* Initial commit; setup Gradle; start service

* initial commit

* minor cleanups, builds green; needs tests

* bug fixes; tested working embeddings & completion

* use custom json builder for embeddings request

* Ensure auto-close; fix forbidden API

* start of adding unit tests; abstraction layers

* adding additional tests; cleanups

* add requests unit tests

* all tests created

* fix cohere embeddings response

* fix cohere embeddings response

* fix lint

* better test coverage for secrets; inference client

* update thread-safe syncs; make dims/tokens + int

* add tests for dims and max tokens positive integer

* use requireNonNull;override settings type;cleanups

* use r/w lock for client cache

* remove client reference counting

* update locking in cache; client errors; noop doc

* remove extra block in internalGetOrCreateClient

* remove duplicate dependencies; cleanup

* add fxn to get default embeddings similarity

* use async calls to Amazon Bedrock; cleanups

* use Clock in cache; simplify locking; cleanups

* cleanups around executor; remove some instanceof

* cleanups; use EmbeddingRequestChunker

* move max chunk size to constants

* oof - swapped transport vers w/ master node req

* use XContent instead of Jackson JsonFactory

* remove gradle versions; do not allow dimensions
@markjhoy markjhoy requested a review from a team as a code owner July 5, 2024 17:53
@markjhoy markjhoy added :EnterpriseSearch/Application Enterprise Search :ml Machine learning >non-issue auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport Team:Enterprise Search Meta label for Enterprise Search team Team:ML Meta label for the ML team labels Jul 5, 2024
@markjhoy
Copy link
Contributor Author

markjhoy commented Jul 5, 2024

@elasticsearchmachine run elasticsearch-ci/part-5

@elasticsearchmachine elasticsearchmachine merged commit e24b0c9 into elastic:8.15 Jul 5, 2024
15 checks passed
@markjhoy markjhoy deleted the backport/8.15/pr-110248 branch July 5, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) backport :EnterpriseSearch/Application Enterprise Search :ml Machine learning >non-issue Team:Enterprise Search Meta label for Enterprise Search team Team:ML Meta label for the ML team v8.15.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants