Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default_field: message from metrics index templates #110651

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Remove default_field: message from metrics index templates #110651

merged 3 commits into from
Jul 10, 2024

Conversation

felixbarny
Copy link
Member

This is a follow-up from #102456

@felixbarny felixbarny added the :Data Management/Data streams Data streams and their lifecycles label Jul 9, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Data Management Meta label for data/management team label Jul 9, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-data-management (Team:Data Management)

@elasticsearchmachine elasticsearchmachine added v8.16.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 9, 2024
@felixbarny felixbarny requested a review from flash1293 July 9, 2024 15:41
@elasticsearchmachine
Copy link
Collaborator

Hi @felixbarny, I've created a changelog YAML for you.

@felixbarny felixbarny mentioned this pull request Jul 9, 2024
Closed
flash1293
flash1293 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@flash1293 flash1293 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, could we get this into 8.15 or should we wait for 8.16?

@felixbarny
Copy link
Member Author

Seems like that is something we could back port to 8.15, as it's causing this bug: elastic/kibana#186616. WDYT @dakrone?

@mattc58
Copy link
Contributor

mattc58 commented Jul 9, 2024

++ on backport to 8.15.0 as it's directly related to a downstream bug. However @felixbarny or @flash1293 is there any testing we're able to do here? Or will it be covered by any downstream tests?

mattc58
mattc58 approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@mattc58 mattc58 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 if CI likes it

@felixbarny
Copy link
Member Author

@elasticmachine update branch

@felixbarny
Copy link
Member Author

I think this would be mainly tested downstream. We made the same changes for the logs index template in #102456, so I feel confident in just relying on the existing tests for this follow-up.

@felixbarny felixbarny added the auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) label Jul 10, 2024
@elasticsearchmachine elasticsearchmachine merged commit 6d85b38 into elastic:main Jul 10, 2024
15 checks passed
@felixbarny felixbarny deleted the metrics-remove-default-field branch July 10, 2024 07:17
@felixbarny felixbarny mentioned this pull request Jul 10, 2024
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.15

felixbarny added a commit to felixbarny/elasticsearch that referenced this pull request Jul 10, 2024
@felixbarny
Remove default_field: message from metrics index templates (elastic…
85db658 
…#110651)

This is a follow-up from
elastic#102456
elasticsearchmachine pushed a commit that referenced this pull request Jul 10, 2024
@felixbarny
Remove default_field: message from metrics index templates (#110651) (
77392d6 
#110683)

This is a follow-up from
#102456
@lkts lkts mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flash1293 flash1293 flash1293 approved these changes

@mattc58 mattc58 mattc58 approved these changes

Assignees
No one assigned
Labels
auto-merge-without-approval Automatically merge pull request when CI checks pass (NB doesn't wait for reviews!) :Data Management/Data streams Data streams and their lifecycles >enhancement external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Data Management Meta label for data/management team v8.15.0 v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@felixbarny @elasticsearchmachine @mattc58 @flash1293 @elasticmachine