Speed up collecting zero document string terms #110922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @iverase, I've created a changelog YAML for you. |
nik9000
approved these changes
Jul 18, 2024
iverase
added a commit
to iverase/elasticsearch
that referenced
this pull request
Jul 18, 2024
Use segment ordinals when possible to collect zero document buckets
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 18, 2024
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
Use segment ordinals when possible to collect zero document buckets
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Use segment ordinals when possible to collect zero document buckets
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
Use segment ordinals when possible to collect zero document buckets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think in most cases we have ordinals so let's use the ordinals to collect the terms. This can be much faster, specially in low cardinality fields. In addition we are optimizing for single value BinaryDocValues.
this change is inspired by this discuss forum chat: https://discuss.elastic.co/t/elasticsearch-slow-query-with-min-doc-count-0-on-field-aggregation