Fix leak in collapsing search results #110927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing this case for now by enforcing unpooled to plug the leak, this needs a little more work to function well pooled.
original-brownbear
added
>bug
:Search/Search
|
Pinging @elastic/es-search (Team:Search) |
|
Hi @original-brownbear, I've created a changelog YAML for you. |
benwtrent
approved these changes
Jul 16, 2024
Comment on lines
+103
to
+106
| if (hit.isPooled() == false) { | ||
| // TODO: make this work pooled by forcing the hit itself to become pooled as needed here | ||
| innerHits = innerHits.asUnpooled(); | ||
| } |
There was a problem hiding this comment.
ARG!!!! This indeed is frustrating. But, I agree, we should do the dumb thing first to fix 8.15.x and do something nicer & more performant later.
|
Thanks Ben! |
original-brownbear
added a commit
to original-brownbear/elasticsearch
that referenced
this pull request
Jul 16, 2024
Fixing this case for now by enforcing unpooled to plug the leak, this needs a little more work to function well pooled.
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 16, 2024
lkts
pushed a commit
to lkts/elasticsearch
that referenced
this pull request
Jul 16, 2024
Fixing this case for now by enforcing unpooled to plug the leak, this needs a little more work to function well pooled.
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 17, 2024
Fixing this case for now by enforcing unpooled to plug the leak, this needs a little more work to function well pooled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing this case for now by enforcing unpooled to plug the leak, this needs a little more work to function well pooled.