Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust cancellation message in task tests #110546

Merged
merged 1 commit into from
Jul 7, 2024
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 5, 2024

Adding parent task was cancelled [test cancel] to the list of allowed cancellation messages.

@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :Analytics/ES|QL AKA ESQL v8.14.3 v8.16.0 v8.15.1 labels Jul 5, 2024
@dnhatn dnhatn requested a review from nik9000 July 5, 2024 19:03
@dnhatn dnhatn marked this pull request as ready for review July 5, 2024 19:03
@elasticsearchmachine elasticsearchmachine added the Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) label Jul 5, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@dnhatn
Copy link
Member Author

dnhatn commented Jul 5, 2024

2> REPRODUCE WITH: ./gradlew ':x-pack:plugin:esql:internalClusterTest' --tests "org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.testCancelEsqlTask" -Dtests.seed=17B8564D26D06CD8 -Dtests.locale=zh-Hans-CN -Dtests.timezone=CNT -Druntime.java=22                                  
2> java.lang.AssertionError:
  Expected: (("test cancel" or "task cancelled") or "request cancelled test cancel")
       but: was "parent task was cancelled [test cancel]"
      at __randomizedtesting.SeedInfo.seed([17B8564D26D06CD8:9CD1DC7C4361D7E9]:0)
      at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
      at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:6)
      at org.elasticsearch.test.ESTestCase.assertThat(ESTestCase.java:2375)
      at org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.assertCancelled(EsqlActionTaskIT.java:326)
      at org.elasticsearch.xpack.esql.action.EsqlActionTaskIT.testCancelEsqlTask(EsqlActionTaskIT.java:208)

@dnhatn
Copy link
Member Author

dnhatn commented Jul 7, 2024

Thanks Nik!

@dnhatn dnhatn merged commit c7ee39a into elastic:main Jul 7, 2024
15 checks passed
@dnhatn dnhatn deleted the cancel-message branch July 7, 2024 15:11
dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jul 7, 2024
Adding `parent task was cancelled [test cancel]` to the list 
of allowed cancellation messages.
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

Status Branch Result
8.14 Commit could not be cherrypicked due to conflicts
8.15

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 110546

elasticsearchmachine pushed a commit that referenced this pull request Jul 7, 2024
Adding `parent task was cancelled [test cancel]` to the list 
of allowed cancellation messages.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/ES|QL AKA ESQL Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.14.3 v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants