Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove rollup/security_tests YAML tests #111656

Merged
merged 1 commit into from
Aug 7, 2024

Conversation

lkts
Copy link
Contributor

@lkts lkts commented Aug 6, 2024

Removing this test for following reasons:

  • It's flaky and uses a hack to sleep for 5s (hardcoded). There is no good way to fix this, the only fix is to convert this into a java test. We don't do this due to other points below.
  • This test does not test anything specific to rollup. It creates an index and then checks that index data is not accessible if a user does not have access to this index. The fact that index in question contains rollup data is irrelevant (to the best of my knowledge), rollup performs a regular bulk request. I expect this case to be well covered already elsewhere.
  • Rollup is deprecated and we don't want to invest in its support.

Closes #111631.

@lkts lkts added >test Issues or PRs that are addressing/adding tests :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data auto-backport-and-merge v8.15.1 labels Aug 6, 2024
@lkts lkts requested a review from kkrik-es August 6, 2024 20:28
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

@lkts lkts merged commit f9bf2b6 into elastic:main Aug 7, 2024
15 checks passed
@lkts lkts deleted the remove_rollup_security_test branch August 7, 2024 15:45
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

lkts added a commit to lkts/elasticsearch that referenced this pull request Aug 7, 2024
rjernst pushed a commit to rjernst/elasticsearch that referenced this pull request Aug 7, 2024
mhl-b pushed a commit that referenced this pull request Aug 8, 2024
cbuescher pushed a commit to cbuescher/elasticsearch that referenced this pull request Sep 4, 2024
davidkyle pushed a commit to davidkyle/elasticsearch that referenced this pull request Sep 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data Team:StorageEngine >test Issues or PRs that are addressing/adding tests v8.15.1 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CI] XPackRestIT test {p0=rollup/security_tests/Index-based access} failing
3 participants