-
Notifications
You must be signed in to change notification settings - Fork 24.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOCS] Fixed text_similarity_reranker retriever example #111256
Merged
leemthompo
merged 1 commit into
elastic:main
from
weizijun:fix-text_similarity_reranker-doc
Jul 29, 2024
Merged
[DOCS] Fixed text_similarity_reranker retriever example #111256
leemthompo
merged 1 commit into
elastic:main
from
weizijun:fix-text_similarity_reranker-doc
Jul 29, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview: |
elasticsearchmachine
added
v8.16.0
needs:triage
Requires assignment of a team area label
external-contributor
Pull request authored by a developer outside the Elasticsearch team
labels
Jul 25, 2024
elasticsearchmachine
added
Team:Docs
Meta label for docs team
and removed
needs:triage
Requires assignment of a team area label
labels
Jul 26, 2024
Pinging @elastic/es-docs (Team:Docs) |
@elasticsearchmachine test this |
leemthompo
approved these changes
Jul 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for the syntax fix @weizijun! FYI we'll be adding more retrievers examples and a Python notebook about retrievers/reranking soon too :)
leemthompo
pushed a commit
to leemthompo/elasticsearch
that referenced
this pull request
Jul 29, 2024
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 29, 2024
Co-authored-by: weizijun <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
>docs
General docs changes
external-contributor
Pull request authored by a developer outside the Elasticsearch team
Team:Docs
Meta label for docs team
v8.15.0
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The text_similarity_reranker parameters are placed in the wrong place. Just put them in the right place.