Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fixed text_similarity_reranker retriever example #111256

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

weizijun
Copy link
Contributor

The text_similarity_reranker parameters are placed in the wrong place. Just put them in the right place.

Copy link
Contributor

Documentation preview:

@elasticsearchmachine elasticsearchmachine added v8.16.0 needs:triage Requires assignment of a team area label external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 25, 2024
@lkts lkts added the >docs General docs changes label Jul 26, 2024
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team and removed needs:triage Requires assignment of a team area label labels Jul 26, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@leemthompo
Copy link
Contributor

@elasticsearchmachine test this

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the syntax fix @weizijun! FYI we'll be adding more retrievers examples and a Python notebook about retrievers/reranking soon too :)

@leemthompo leemthompo merged commit 2e0d0e2 into elastic:main Jul 29, 2024
7 checks passed
leemthompo pushed a commit to leemthompo/elasticsearch that referenced this pull request Jul 29, 2024
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
8.15

elasticsearchmachine pushed a commit that referenced this pull request Jul 29, 2024
@weizijun weizijun deleted the fix-text_similarity_reranker-doc branch July 29, 2024 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs General docs changes external-contributor Pull request authored by a developer outside the Elasticsearch team Team:Docs Meta label for docs team v8.15.0 v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants