Properly handle filters on TextSimilarityRank retriever #111673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmpailis
added
>bug
:Search Relevance/Ranking
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
|
Hi @pmpailis, I've created a changelog YAML for you. |
💚 Backport successful
|
pmpailis
added a commit
to pmpailis/elasticsearch
that referenced
this pull request
Aug 7, 2024
elasticsearchmachine
pushed a commit
that referenced
this pull request
Aug 7, 2024
rjernst
pushed a commit
to rjernst/elasticsearch
that referenced
this pull request
Aug 7, 2024
mhl-b
pushed a commit
that referenced
this pull request
Aug 8, 2024
cbuescher
pushed a commit
to cbuescher/elasticsearch
that referenced
this pull request
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
filterspecified inTextSimilarityRankretriever is ignored, so in this PR we account for that by propagating all top-level filters to the nested retriever, just before extracting it tosource.