Skip preallocate tests on windows #110998
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows. closes elastic#110948
rjernst
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
thecoop
approved these changes
Jul 18, 2024
rjernst
added a commit
to rjernst/elasticsearch
that referenced
this pull request
Jul 19, 2024
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows. closes elastic#110948
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 19, 2024
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows. closes #110948
ioanatia
pushed a commit
to ioanatia/elasticsearch
that referenced
this pull request
Jul 22, 2024
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows. closes elastic#110948
salvatore-campagna
pushed a commit
to salvatore-campagna/elasticsearch
that referenced
this pull request
Jul 23, 2024
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows. closes elastic#110948
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The preallocate tests assumed that preallocation was using the fallback implementation which calls setLength on Windows. However, that fallback only happens inside the SharedBytes class, so windows doesn't actually do anything when tryPreallocate is called. This commit skips the test on windows.
closes #110948