Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updating CloseIndexRequestTests to account for master term #110611

Merged
merged 1 commit into from
Jul 8, 2024
Merged

updating CloseIndexRequestTests to account for master term #110611

merged 1 commit into from
Jul 8, 2024

Conversation

masseyke
Copy link
Member

@masseyke masseyke commented Jul 8, 2024

This updates CloseIndexRequestTests to handle the new masterTerm field.
Caused by #108909
Closes #110604

@masseyke masseyke added >test Issues or PRs that are addressing/adding tests :Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. v8.16.0 labels Jul 8, 2024
@elasticsearchmachine elasticsearchmachine added the Team:Distributed Meta label for distributed team (obsolete) label Jul 8, 2024
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-distributed (Team:Distributed)

@masseyke masseyke requested a review from DaveCTurner July 8, 2024 21:15
DaveCTurner
DaveCTurner approved these changes Jul 8, 2024
View reviewed changes
Copy link
Contributor

@DaveCTurner DaveCTurner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Maybe we should run this test on many versions rather than relying on randomness to hit a failure like this eventually?

@masseyke masseyke merged commit e95cbb4 into elastic:main Jul 8, 2024
15 checks passed
@masseyke masseyke deleted the fix/CloseIndexRequestTests branch July 8, 2024 22:01
@DaveCTurner DaveCTurner mentioned this pull request Jul 11, 2024
Closed
DaveCTurner pushed a commit that referenced this pull request Jul 11, 2024
@masseyke @DaveCTurner
Updating CloseIndexRequestTests to account for master term (#110611)
eaa85b2
@lkts lkts mentioned this pull request Aug 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DaveCTurner DaveCTurner DaveCTurner approved these changes

Assignees
No one assigned
Labels
:Distributed Coordination/Cluster Coordination Cluster formation and cluster state publication, including cluster membership and fault detection. Team:Distributed Meta label for distributed team (obsolete) >test Issues or PRs that are addressing/adding tests v8.16.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] CloseIndexRequestTests testBwcSerialization failing
3 participants
@masseyke @elasticsearchmachine @DaveCTurner