Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translate metrics without rate #110614

Merged
merged 1 commit into from
Jul 9, 2024
Merged

Conversation

dnhatn
Copy link
Member

@dnhatn dnhatn commented Jul 8, 2024

Currently, we incorrectly remove the @timestamp attribute from the EsRelation when translating metric aggregates.

@dnhatn dnhatn requested review from martijnvg and astefan July 9, 2024 04:37
@dnhatn dnhatn marked this pull request as ready for review July 9, 2024 04:37
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-storage-engine (Team:StorageEngine)

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dnhatn
Copy link
Member Author

dnhatn commented Jul 9, 2024

Thanks Martijn!

@dnhatn dnhatn merged commit fb10d61 into elastic:main Jul 9, 2024
15 checks passed
@dnhatn dnhatn deleted the timeseries-stats branch July 9, 2024 05:34
@elasticsearchmachine
Copy link
Collaborator

💔 Backport failed

The backport operation could not be completed due to the following error:

An unexpected error occurred when attempting to backport this PR.

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 110614

dnhatn added a commit to dnhatn/elasticsearch that referenced this pull request Jul 9, 2024
Currently, we incorrectly remove the `@timestamp` attribute from
the EsRelation when translating metric aggregates.
elasticsearchmachine pushed a commit that referenced this pull request Jul 9, 2024
Currently, we incorrectly remove the `@timestamp` attribute from
the EsRelation when translating metric aggregates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants