Union types documentation #110183
Merged
Union types documentation #110183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
craigtaverner
added
>docs
|
Documentation preview: |
|
Pinging @elastic/es-docs (Team:Docs) |
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
craigtaverner
commented
Jun 26, 2024
| ---- | ||
|
|
||
| .... | ||
| Cannot use field [client_ip] due to ambiguities being mapped as [2] incompatible types: |
There was a problem hiding this comment.
It would be nice to have a better styling for this error message. Right now this style does not really stand out sufficiently. Do we have a convention for displaying errors? A quick search did not find anything.
There was a problem hiding this comment.
I'm still looking into options and conventions, but for now I changed this to use [source,bash], which is kind of a default and looks decent (example). WDYT?
There was a problem hiding this comment.
Certainly much better than my approach, although not yet quite perfect. Good enough for now.
21 tasks
craigtaverner
added a commit
to craigtaverner/elasticsearch
that referenced
this pull request
Jul 16, 2024
* Union types documentation * Try remove asciidoc error * Another attempt * Using literal block * Nicer formatting * Remove partintro * Small refinements * Edits for clarity and style --------- Co-authored-by: Marci W <[email protected]>
💚 Backport successful
|
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 16, 2024
* Union types documentation * Try remove asciidoc error * Another attempt * Using literal block * Nicer formatting * Remove partintro * Small refinements * Edits for clarity and style --------- Co-authored-by: Marci W <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Union types was added in #107545
This provides the associated documentation for this feature.