Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

weekly-digest · 2020-01-26T23:01:45Z

Here's the Weekly Digest for CleverRaven/Cataclysm-DDA:

ISSUES

Last week 197 issues were created.
Of these, 123 issues have been closed and 74 issues are still open.

OPEN ISSUES

💚 #37392 src/creature_tracker.cpp:127 [bool Creature_tracker::update_pos(const monster&, const tripoint&)] update_zombie_pos: wanted to move the fungaloid to 49,52,-3, but new location already has the spore cloud, by l29ah
💚 #37391 Zombies seemingly hit Limbs of animals, by Relyksboa
💚 #37387 Make int_id::operator int explicit, by Qrox
💚 #37378 "Fire nearby" scenerio flag doing nothing, by Presence-Eternal
💚 #37377 [WIP] More paperbacks, by Jerimee
💚 #37376 Can't pick up faction items, by Melodeiro
💚 #37374 Auditing gun, magazine, and holster volumes, by LaVeyanFiend
💚 #37372 Mapgen-defined spawns aren't subject to migration, by tenmillimaster
💚 #37370 Completely destroyed short ropes still combine to make a pristine long rope, by Alapaga
💚 #37368 jsonize spell skills, by KorGgenT
💚 #37367 Update tool.json to add crafting recipe for hand pump, by gavin1337
💚 #37363 cord converted to long string exploit, by Rogal-Dorn
💚 #37362 Replace axe-kick with spinning back kick and add roundhouse kicks/feints to TKD, by sayke
💚 #37361 Installing gunmods takes time, by snipercup
💚 #37355 Multi-tile pirate cannon vehicle, by SeventhSandwich
💚 #37354 New Trait: Fear of height, by DaAngus
💚 #37352 Follower won't wear an arm splint cause it's too cumbersome, by Alapaga
💚 #37351 Added wild boar to forests, by RarkGrames
💚 #37347 New NPCs for the player to trade with, by Brytenwalda
💚 #37345 Disassembling 30 bullets gives the components of a single round, by Dziugaske
💚 #37343 Add inactive robot disassembly recipe, by Dziugaske
💚 #37339 Errors examining or picking up items dropped by dead NPC, by wapcaplet
💚 #37337 Put some mania in Pyromania, by vlad1492
💚 #37336 It's tiome for biomes. It's time for bimes? Work with me., by I-am-Erk
💚 #37335 Make edamame and soybeans smokable, by CSHague
💚 #37333 In-game text says you can make 8 expansions to a field base, but can only make 6, by LuigiWhatif
💚 #37330 NPC worker downtime - wandering and sitting on chairs, by davidpwbrown
💚 #37329 [WIP][CR] Add assign reader for damage instances, deprecate legacy damage code, by anothersimulacrum
💚 #37327 Game crash after withdrawing money, by HunorP
💚 #37325 Allow NPCs to use basecamp storage zone for activities/jobs, by davidpwbrown
💚 #37324 The age_grow and baby_timer attributes take more time than intended, by RarkGrames
💚 #37322 Change wording on "Disassemble everything" and "Disassemble everything once" to better explain what each action do., by RobertoVGoulart
💚 #37321 Turret mount crafting recipe, by Dziugaske
💚 #37318 Gaps in map memory, by chaoticidealism
💚 #37316 Split sausage_wasteland recipe into two recipes., by arijust
💚 #37315 Heavy Disposable Batteries recharging through exploit., by gwyter
💚 #37314 Allow professions to start with a nearby vehicle - trucker profession, by davidpwbrown
💚 #37311 You lose "Remember Vehicle Position" On vehicle when placed on a Bike Rack, by MisterWytt
💚 #37310 Add property to map class to allow disabling caches, by ZhilkinSerg
💚 #37309 Allow entry of unicode characters into overmap notes, by damien
💚 #37306 Magiclysm - Spellbooks and scrolls should respect charges, by foulman
💚 #37304 Game crashes after unloading bike raack, by BrassRobo
💚 #37300 [WIP]NPC work log - for debugging and feedback, by davidpwbrown
💚 #37298 Hub01 Return Field Data mission is offered twice, by l29ah
💚 #37297 Spike Pit and Glass Pit Blueprint zone does not build over extant shallow pit, by CSHague
💚 #37296 Error messages while reloading liquid containers., by ZehCastro
💚 #37295 [magiclysm] create orichalcum frame vehicle part, by KorGgenT
💚 #37294 Tried to access invalid map position after turning off z-levels, by wapcaplet
💚 #37293 M855A1 has incorrect materials when disassembled., by Sharkey-Ward
💚 #37284 Random NPCs only spawn in the central overmap, by RydellV
💚 #37281 Clean skill rust code, by Fris0uman
💚 #37280 Can know what happens with Hub Security w/o observing them, by l29ah
💚 #37278 Add missing Krav Maga Weapons: Take 2, by JohnWildkins
💚 #37276 Update custom loot zones action, by RegaliaV
💚 #37275 Merge Makeshift Items Mod into base game, pt 1., by Kelenius
💚 #37272 Obsolete mods, by ymber
💚 #37271 Moved mass grave terrain and special to map extra, by ZhilkinSerg
💚 #37263 WIP Autolearn recipes rework cooking part 1, by Maleclypse
💚 #37253 Add the option to toggle individual Reactors in vehicles., by DatMeg
💚 #37241 Rebalance archery take... 5?, by kevingranade
💚 #37239 Batch Crafting Causes Crash Upon Using All Available Ingredients in Batch, by Taichi22
💚 #37238 Custom Zone filters impede sorting, by MarceloLaser
💚 #37234 Antennae Multilevel attacks, by thepotate0
💚 #37232 Explosive chemistry - rework roadmap, by 1n17
💚 #37229 Dashboard consumes more power than aisle lights, by l29ah
💚 #37224 Batch Unload, by Lamandus
💚 #37223 Raw Wasteland Sausage Uncraftable, by whitehorn799
💚 #37220 Flintlock rilfe to musket name change and addition of a proper rifle, by Ker-Nes
💚 #37211 Using wire instead of car springs in small-scale recipes, by randomtyper
💚 #37208 Recalculation of clothes wetness and wetness moral debuff., by Lamandus
💚 #37207 NPCs can't pass through screen mesh door / climb over screen mesh wall, by Drakasin
💚 #37204 Flintlock rifles are misnamed., by Ker-Nes
💚 #37203 Flintlocks should have more range and more dispersion, by Ker-Nes
💚 #37200 RC vehicle steering indicator & vision, by naka123

CLOSED ISSUES

LIKED ISSUE

👍 #37336 It's tiome for biomes. It's time for bimes? Work with me., by I-am-Erk
It received 👍 x9, 😄 x0, 🎉 x0 and ❤️ x13.

NOISY ISSUE

🔈 #37272 Obsolete mods, by ymber
It received 66 comments.

PULL REQUESTS

Last week, 168 pull requests were created, updated or merged.

OPEN PULL REQUEST

Last week, 1 pull request was opened.
💚 #37368 jsonize spell skills, by KorGgenT

UPDATED PULL REQUEST

Last week, 45 pull requests were updated.
💛 #37377 [WIP] More paperbacks, by Jerimee
💛 #37361 Installing gunmods takes time, by snipercup
💛 #37351 Added wild boar to forests, by RarkGrames
💛 #37347 New NPCs for the player to trade with, by Brytenwalda
💛 #37343 Add inactive robot disassembly recipe, by Dziugaske
💛 #37335 Make edamame and soybeans smokable, by CSHague
💛 #37330 NPC worker downtime - wandering and sitting on chairs, by davidpwbrown
💛 #37329 [WIP][CR] Add assign reader for damage instances, deprecate legacy damage code, by anothersimulacrum
💛 #37325 Allow NPCs to use basecamp storage zone for activities/jobs, by davidpwbrown
💛 #37321 Turret mount crafting recipe, by Dziugaske
💛 #37310 Add property to map class to allow disabling caches, by ZhilkinSerg
💛 #37281 Clean skill rust code, by Fris0uman
💛 #37278 Add missing Krav Maga Weapons: Take 2, by JohnWildkins
💛 #37275 Merge Makeshift Items Mod into base game, pt 1., by Kelenius
💛 #37271 Moved mass grave terrain and special to map extra, by ZhilkinSerg
💛 #37200 RC vehicle steering indicator & vision, by naka123
💛 #37193 Added trail property for ammo effects, by ZhilkinSerg
💛 #37190 Percent chance for AOE ammo effects, by ZhilkinSerg
💛 #37179 Explosive chemistry - in very small steps, issue I & II, by 1n17
💛 #37144 Chemistry Revolution: Lithium, by roaringjohn
💛 #37129 Remove scent diffusion over water by implementing NO_SCENT flag, by sayke
💛 #37105 New Elf-A Mutations, by zoshkalin
💛 #37100 Adds Elite Zombie Bio-Operator monster, by Hymore246
💛 #37088 Populated the campground with NPCs, by LovamKicsiGazsii
💛 #37086 Added the rest of the NPCs, by LovamKicsiGazsii
💛 #37052 Explosives disassembly, by Brian-Otten
💛 #36959 added batch time saving for all sugar recipes, by 8ctopus
💛 #36945 Makes loot in military locations more realistic and rewarding, by Brian-Otten
💛 #36911 Re-Wrap recipes (Second Pass), by Soup-de-Loop
💛 #36908 WIP [Aftershock] Millyficent whately and the migo , by Maleclypse
💛 #36853 Military armor balance, by Brian-Otten
💛 #36847 Added 9 NPCs, misc improvements, by LovamKicsiGazsii
💛 #36838 Add FS2000(plus STANAG mag volume update), by LaVeyanFiend
💛 #36747 WIP Canning apple cider and other juices, by Maleclypse
💛 #36733 Add demon chitin armor & repairing dragon armor, by LaVeyanFiend
💛 #36703 Metal bridge over air tiles, by RafeHaab
💛 #36656 Item contents refactor (holster refactor 1 of 2), by KorGgenT
💛 #36625 Add wind chimes, by AlexMooney
💛 #36005 Allow plant mutants to sleep in planter furniture, by AlexanderBodnya
💛 #35957 [WIP] Blazemod refactor, by ave-
💛 #35636 Magiclysm brown dragon, by ZhamelSeh
💛 #35272 Adding More Furniture, by WhaleyWhaley
💛 #34061 new bionics menu, by akozhevn
💛 #33556 CRIT Expansion Update [WIP], by Soupster89
💛 #33271 [CR] Removed penalties and base cost when calculating obtain_cost() for wielded item, by Raschert0

MERGED PULL REQUEST

COMMITS

Last week there were 176 commits.
🛠️ Various generic guns quickfixes (#37386) * Description, recipe, parent, itemidswap, and capitalization fixes by tenmillimaster
🛠️ Merge pull request #37356 from sayke/fix-LTO-on-OSX Update Makefile so LTO works on OSX by ZhilkinSerg
🛠️ [Armor.json sorting pt. 3 (#37393) * Moved items to separate files

Changed cloaks_blankets.json to cloaks.json](0756e42) by RarkGrames
🛠️ Merge pull request #37389 from Cyrano7/Cleanup0.E Some more typo cleanup for 0.E by ZhilkinSerg
🛠️ Merge pull request #37384 from jbytheway/ubsan Add undefined behaviour sanitizer to Travis CI (and fix issues it finds) by ZhilkinSerg
🛠️ Merge pull request #37383 from jbytheway/triage-clang-tidy Triage two clang-tidy checks by ZhilkinSerg
🛠️ [Appease clang-tidy (Appease clang-tidy #37390) * Pass -quiet to clang-tidy on Travis

To reduce the unnecessary noise in the CI output from running
clang-tidy.

Assorted clang-tidy fixes](aa2da16) by jbytheway
🛠️ [Update JSON_INFO.md (bashing cannot be negative) (Update JSON_INFO.md (bashing cannot be negative) #37186) * Update JSON_INFO.md
Update doc/JSON_INFO.md

Co-Authored-By: I-am-Erk [email protected]

Update doc/JSON_INFO.md

Co-Authored-By: I-am-Erk [email protected]

Update JSON_INFO.md
Update JSON_INFO.md

Co-authored-by: I-am-Erk [email protected]](fa3ab6e) by Jerimee
🛠️ Use std::abs on int64_t argument Using abs is in fact safe in this case, but causes a compiler warning. by jbytheway
🛠️ Some more typo cleanup for 0.E Some more typo cleanup for 0.E by Cyrano7
🛠️ Routine i18n updates on 25 Jan 2020 (#37382) by BrettDong
🛠️ make reins autolearn (#37379) by davidpwbrown
🛠️ Armor.json sorting pt. 2 (#37381) by RarkGrames
🛠️ fix screen wall (#37380) by curstwist
🛠️ Enable UBSan in Travis CI UBSan and ASan are compatible, so enable them both in the same test run. by jbytheway
🛠️ Triage two clang-tidy checks PR #37003 added -modernize-use-trailing-return-type to our .clang-tidy on the basis that we don't want to fix those issues. However, it was added to the yet-to-be-triaged section of the file. Move it to the triaged section of checks we have decided we don't want. At the same time, move modernize-use-auto to the same section. No behavioural change should occur. This is just bookkeeping. by jbytheway
🛠️ Merge pull request #37350 from Fris0uman/batt_npc NPC can consume battery charges from batteries by Rivet-the-Zombie
🛠️ [Fixed pluralization of acorn meal/bologna/bone meal/cornmeal/detergent/herring/oatmeal/yeast (#37375) * Fixed pluralization of bone/acorn/corn/oatmeal and yeast.

used new plural form, and added bologna and detergent plurals](175cf62) by jkraybill
🛠️ Add -fno-sanitize-recover=all with sanitizers By default, UBSan just prints a message but doesn't cause an error exit. This is not what we want for CI, so adding an extra option to make these errors fatal in order for CI issues to be obvious. by jbytheway
🛠️ Initialize weather in tests The tests never initialized the state of the weather system, leaving some uninitialized values which could lead to winds in the billions of miles per hour. That in turn led to overflows and UB. Initialize the weather system appropriately. by jbytheway
🛠️ Avoid overflow when computing vehicle power When a vehicle was being fast-forwarded over a period of months upon return to the reality bubble it was possible for the accumulated solar power to exceed billions of joules. This led to integer overflow. Perform intermediate calculation in 64-bit ints to avoid the problem. by jbytheway
🛠️ Avoid some floating point division by zero Avoid division by zero in two cases: light level zero (used to check creature night sight on some code paths) and vehicle traction when all wheels are on the ground. This isn't actually UB, but in one case it led to UB because an infinity was cast to an int. Also, UBSan was complaining about it, possibly because we're doing things that are unsafe when using -ffast-math. by jbytheway
🛠️ Avoid overflow in get_overmaps_near In some cases a call to get_overmaps_near was passing a tripoint with z value INT_MIN. This led to an overflow when computing the distance between points. Instead, just pass the x,y part of the tripoint. by jbytheway
🛠️ Avoid uninitialized bool member variables In effect_type these bools would remain uninitialized for the derived class ma_buff_effect_type, leading to inconsistent behaviour of martial art effects. In inventory a newly constructed inventory could be considered binned, which could cause incorrect behaviour. In both cases, this involved loading invalid bool values, with is UB. by jbytheway
🛠️ Avoid crafting_success_roll returning NaN The crafting_success_roll could end up computing 0.0/0.0. This happened to work, but more by luck than design, so check for that case explicitly. (NaN values are unsafe given that we're compiling with -ffast-math). by jbytheway
🛠️ Avoid member function call with this == null This member function of oracle_t was just a constant function. It didn't need to be a member function, so I made it a free function. In the tests it was being called on null oracle_t* values. by jbytheway
🛠️ Add -fno-sanitize-recover=all When activating a sanitizer, explicitly request that we don't try to recover from a failure. This is so that when we run the tests in CI, ubsan issues will actually cause a failure. Otherwise they're just logged and no-one will notice them. by jbytheway
🛠️ Remove non-scifi professions from Aftershock (#37292) by John-Candlebury
🛠️ Adds repair like jeans to army pants. (#37353) by Brian-Otten
🛠️ Fix handmade magnum carbine using wrong ammo (#37364) by LaVeyanFiend
🛠️ Cleaning can use clean water (#37366) by Fris0uman
🛠️ regenerate values for vehicle drag test (#37369) * regenerate values for vehicle drag test by davidpwbrown
🛠️ [Magiclysm - New Spells 1 (Magiclysm - New Spells 1 #37254) * Linted Assorted Spells

Fresh spells for the masses

Update data/mods/Magiclysm/Spells/biomancer.json

Co-Authored-By: Curtis Merrill [email protected]

fixed paralyze damage
updated cost of pillar
corrected range
rogue comma
Update stormshaper.json
updated terrain files

Huh. completely missed that.

class change
Update data/mods/Magiclysm/Spells/animist.json

Co-Authored-By: Curtis Merrill [email protected]

scrolls & loot list

Co-authored-by: Curtis Merrill [email protected]](3da00f4) by foulman
🛠️ [ Add item_category documentation (#37346) * Add item_category documentation

Alignment](bb45b9a) by snipercup
🛠️ Sorted hats, arm and leg guards (#37358) by RarkGrames
🛠️ Added the item to item groups (#37360) by RarkGrames
🛠️ [Add a vibrator crafting recipe (Add a vibrator crafting recipe #36860) * Add a vibrator crafting recipe

There was an existing recipe for crafting an mp3 player, but
surprisingly none for a much simpler device, the vibrator.
This recipe uses similar ingredients to the existing deconstruction
recipe (with the addition of a tiny electric motor), and is auto-learned
at fabrication level 2.

Increase vibrator crafting requirements

Makes the recipe a bit more realistic, and balanced with existing
recipes, based on pull request comments from other players and
further inspection of existing recipes. Changes include:

Require a plastic mold (must-have for a smoothly contoured shape)
and additional plastic scraps to account for mold overrun
Require electronics skill 1, but use fab 2 to construct
Increase difficulty to 3 and crafting time to 20 minutes
Need wire, solder, and soldering iron
Use "motor_micro" (0.28 lbs) instead of "motor_tiny" (1.38 lbs),
since vibrator itself only weighs 1.0 lbs

lint

Co-authored-by: I-am-Erk [email protected]](2ce8aa2) by wapcaplet
🛠️ Fix a few typos pre 0.E (#37359) Fix a few typos pre 0.E by Cyrano7
🛠️ Update Makefile so LTO works on OSX The gold linker can only produce ELF binaries, not Mach, so it doesn't work on OSX. This lets link-time optimization work when linking Mach binaries from clang. by sayke
🛠️ Generic modern json (#37342) by snipercup
🛠️ [Fix spelling errors (#37349) * Remove executable bit from turret.json

Fix spelling errors

found by lintian](070588e) by reinerh
🛠️ Reverted flag change and added coverage by RarkGrames
🛠️ [Generic Guns rework (#36839) * Rework generic guns

Recipe redefs
20x66 migrations
turrets, descriptions, magazine ammo types
Smörgåsbord of stuff
Update gg_ammo_migration.json
black powder recipes &defs, make more recipes standalone
fix circular error caused by obsoletion
Update recipes_pistol.json
Update modinfo.json
Update pistol.json
Update shot.json](6369e0b) by tenmillimaster
🛠️ NPC can consume battery charges from batteries by Fris0uman
🛠️ Fix mag unloading (#37338) by Trioct
🛠️ Add a "rural" biome in mod form (#37265) by I-am-Erk
🛠️ Jsonize and simplify starving warnings (#36989) by Fris0uman
🛠️ Move update_body and skill rust related functions from player to Character (#37210) by Fris0uman
🛠️ Prevent auto attacking allies (#37257) by Ramza13
🛠️ Merge pull request #37267 from Trioct/holster_fix Fix item duplication through holsters by ZhilkinSerg
🛠️ Reduce the scaling damage dealt by the evolve kill strike special attack (#37277) * Teak the scaling damage dealt by evolve kill strike attack by John-Candlebury
🛠️ Merge pull request #37290 from Fris0uman/charger_no_waste Cable charger CBM don't draw power when you're full by ZhilkinSerg
🛠️ [Computer refactor part 2 (Computer refactor part 2 #37299) * Remove unnecessary/unused members of class computer
Make name and mission_id of computer private
Make alerts a member of computer
Move initialization of next_attempt to constructor
Replace shutdown_terminal with reset_terminal
Check option enum instead of (translated) option string
Migrate computer_action and computer_failure_type to use enum conversion
Use JSON (de)serialization in class computer
Lift ordering restriction of computer_action and computer_failure_type
Remove COMPACT_OBSOLETE
Fix COMPFAIL_DESTROY_DATA range
Remove const modifiers in function declarations

Co-Authored-By: ZhilkinSerg [email protected]

Co-authored-by: ZhilkinSerg [email protected]](e792bb8) by Qrox
🛠️ Merge pull request #37340 from Night-Pryanik/the-the-fix Fixed duplicate "the" by ZhilkinSerg
🛠️ Merge pull request #37328 from Dziugaske/MRE-fun-value-changes MRE enjoyability value changes by Rivet-the-Zombie
🛠️ Fixed duplicate "the" by Night-Pryanik
🛠️ Update mre.json by Dziugaske
🛠️ Update mre.json by Dziugaske
🛠️ Add new safemode rule category for ignoring sounds (#36786) * Added safe sound rule category by Ramza13
🛠️ [Refactor computer window (#37269) * Refactor computer window printing

Use input context in query_bool and query_ynq
Split computer actions into functions
Split computer failures into functions](31768ac) by Qrox
🛠️ Move more string consts into file for them (#37302) by Ramza13
🛠️ Merge pull request #37289 from RarkGrames/Overrun-scenario-fix Overrun scenario fix by ZhilkinSerg
🛠️ Merge pull request #37308 from curstwist/fix-#36916-tacoma-ranch-crash Fix #36916 by moving the ambulance spawn. by ZhilkinSerg
🛠️ Merge pull request #37320 from snipercup/Ammo-modern-json Ammo modern json by ZhilkinSerg
🛠️ Merge pull request #37173 from ymber/harvest_snippets Allow snippets in harvest messages by ZhilkinSerg
🛠️ Merge pull request #37283 from RarkGrames/Animal-reproduction-fixes Animal reproduction fixes by ZhilkinSerg
🛠️ Merge pull request #37319 from jkraybill/jk1 typo: change 'past' to 'passed' (verb) by ZhilkinSerg
🛠️ Merge pull request #37313 from snipercup/Comestible-modern-json2 Comestible-modern-json 2 by ZhilkinSerg
🛠️ Paperback novel tpl (#37166) by Jerimee
🛠️ Merge pull request #37270 from l29ah/oars-fix Saner oars stats and recipe by ZhilkinSerg
🛠️ Ammo modern json by snipercup
🛠️ typo: change 'past' to 'passed' (verb) by jkraybill
🛠️ Merge pull request #37312 from arijust/age_grow Add age_grow attribute documentation. by Rivet-the-Zombie
🛠️ Comestible-modern-json 2 by snipercup
🛠️ Add age_grow attribute documentation. by arijust
🛠️ shfit the ambulance by curstwist
🛠️ Linting by RarkGrames
🛠️ Added flag to the 5 variants by RarkGrames
🛠️ Merge pull request #37274 from saurocyte/filthy_strap_fix Fix filthy wearable weapon drops by Rivet-the-Zombie
🛠️ [Add MAINLINE_MODS.md to document mod inclusion criteria and procedures (Add MAINLINE_MODS.md to document mod inclusion criteria and procedures #37282) * Create MAINLINE_MODS.md
Update doc/MAINLINE_MODS.md

Co-Authored-By: Curtis Merrill [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: Fris0uman [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: davidpwbrown [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: davidpwbrown [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: I-am-Erk [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: I-am-Erk [email protected]

Update doc/MAINLINE_MODS.md

Co-Authored-By: I-am-Erk [email protected]

Co-authored-by: Curtis Merrill [email protected]
Co-authored-by: Fris0uman [email protected]
Co-authored-by: davidpwbrown [email protected]
Co-authored-by: I-am-Erk [email protected]](041c666) by esotericist
🛠️ [Added oral rehydration therapy drink and recipes to craft it. (#37286) * Added sports drink recipe

Added a new location to learn recipe

It makes sense that you'd be able to learn about ORT solution from a first aid manual.

Linted recipe_food.json
Added rehydration drink item
Adjusted the new recipe
Added a "looks_like"
Linted drink.json again
Changed rehydration drink joy from -5 to -2
Adjusted description as per suggestion
Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk [email protected]

Update data/json/recipes/recipe_food.json

Co-Authored-By: I-am-Erk [email protected]

Co-authored-by: I-am-Erk [email protected]](486010b) by Inglonias
🛠️ [Comestible modern json (#37273) * Comestible modern json

Correct amonia plural
Correct almond pulp plural](f27d795) by snipercup
🛠️ Attacking shocker with worn non-conductive gloves won't zapback you (#37242) by Night-Pryanik
🛠️ Calories for offal dishes (#37287) by I-am-Erk
🛠️ Cable charger don't draw power when you're full by Fris0uman
🛠️ Changed occurrences by RarkGrames
🛠️ [Fix map revealing items (Fix map revealing items #37195) * Fix reveal of bar by restaurant guide
Fix reading of enum in om_terrain_match_type tag](ff0f233) by ZhilkinSerg
🛠️ [Offal holiday cooking by evelyn turncoat (Offal holiday cooking by evelyn turncoat #37171) * Recipes and comestibles
itemgroup
Update offal_dishes.json
Update cooking.json
fix components
Update offal_dishes.json
Update data/json/recipes/food/offal_dishes.json

Co-Authored-By: Jianxiang Wang (王健翔) [email protected]

LISTS flag
excess comma
weird array structure unnecessary
Update offal_dishes.json
Update offal_dishes.json
elimiinate charges test for calories
Update canned.json
Update canned.json
Revert "Update canned.json"

This reverts commit 08920ef.

Revert "Update canned.json"

This reverts commit 2836f13.

Update data/json/items/book/cooking.json

Co-Authored-By: I-am-Erk [email protected]

Co-authored-by: Jianxiang Wang (王健翔) [email protected]
Co-authored-by: I-am-Erk [email protected]](7ea3189) by Maleclypse
🛠️ Update mammal.json by RarkGrames
🛠️ [Military Base location (#37024) * Mapgen file

Palette
Overmap special
Overmap terrain
Update mil_base.json
More OM tiles
Added armory and infirmary
Barracks and stuff
More barracks + military vehicles
Utilities and Comm Center
Added bunk beds
Added underground level
Added interior locked metal door
Revert "Added interior locked metal door"

This reverts commit 2a69241.

Added command center
Added z+1 level
Added warehouse shelf
Added Z levels 2-4
Added item groups and corpse piles
Update locations.json
Update mil_base_z0.json
Added IV bag
Added saline solution in iv bag to surgery item group
Added mess tray
Added more item spawn points
Resolved merge conflicts
Added more item spawns
Update furniture-storage.json
Wrapped up item placements
Update mil_base_palette.json
Added monster groups
Added starting scenario
Update scenarios.json
Added monsters
Tweaks and linting
Wrap-up
Update locations.json
Added missing monstergroup
Added specops, bio_soldier and bio_sniper to starting professions
Added shredders
Added the base to military operations map
Changed the overmap color to red
Corrected occurrences
Added laundry room
Added chairs to laundry
Enlarged the helipad
Added benches to laundry
Update mil_base_z-1.json
Tweaks
Tweaks
Minor item placement fixes
Adding palette with recent changes
Handling test failures
More test fixes
Update data/json/overmap/overmap_special/specials.json

Co-Authored-By: I-am-Erk [email protected]

Update data/json/overmap/overmap_special/specials.json

Co-Authored-By: I-am-Erk [email protected]

Co-authored-by: I-am-Erk [email protected]](12beec0) by RarkGrames
🛠️ Apply suggestions from code review Co-Authored-By: Anton Burmistrov [email protected] by saurocyte
🛠️ Fix filthy wearable weapon drops by saurocyte
🛠️ Remove redundant translation by ymber
🛠️ Saner oars stats and recipe The current stats don't represent the description and usage correctly. by l29ah
🛠️ Fix item duplication by Trioct
🛠️ Fix NPC dropping equipment (#37240) * Make npc equiping smarter by Ramza13
🛠️ Tools.json sorting pt. 8 (#37219) * Tools.json sorting pt.8 by RarkGrames
🛠️ Merge pull request #37264 from Qrox/input-filter-cleanup Input event filter clean-up by ZhilkinSerg
🛠️ Merge pull request #37266 from LilShiningMan/LSM---Novels Novels Item Group Revamp - kid books and literature groups added by ZhilkinSerg
🛠️ Merge pull request #37262 from davidpwbrown/danger_note_fix Fix map notes marked dangerous across overmap boundaries by Rivet-the-Zombie
🛠️ Removed redundant arrays for colors (#37187) Co-authored-by: I-am-Erk [email protected] by ZhilkinSerg
🛠️ add migo resin walls for faction camps (#37188) by curstwist
🛠️ rammed earth faction expansions (#37184) by curstwist
🛠️ Novels Item Group Revamp - kid books and literature groups added eliminated duplicated novel item lists and replaced by calling revamped Novels group, as well as newly created kid_books and literature item groups. by LilShiningMan
🛠️ [House fix (#37261) * fix house mapgen

fix for save load compatability
lint

lint for the lint gods

Update house.json

be kind, fix the weight.

remove non functional entries](106fa1a) by curstwist
🛠️ Input event filter clean-up by Qrox
🛠️ use om_local pos to check dnager across overmap boundaries by davidpwbrown
🛠️ Remove redundant curly braces by ZhilkinSerg
🛠️ Migrate/cleanup consumption.cpp from player to character (#36991) by Ramza13
🛠️ Create string_consts.h and pull string consts from player.cpp and character.cpp (#37231) by Ramza13
🛠️ Merge pull request #37250 from CountAlex/tallow-health Adjust tallow health modifier by ZhilkinSerg
🛠️ Merge pull request #37260 from CleverRaven/clang-2020-01-21 Appease clang (2020-01-21) by ZhilkinSerg
🛠️ [NPC mission chain fix (NPC mission chain fix #37255) * check for next mission during dialogue loop
add verification to clear_mission()
revert style fix to main menu.h](4e9ea8c) by davidpwbrown
🛠️ Appease clang by ZhilkinSerg
🛠️ Merge pull request #37258 from davidpwbrown/overflow_sort_fix Check for max number of tile items when moving in sorting by ZhilkinSerg
🛠️ Merge pull request #37259 from davidpwbrown/flicker_fix Change curses refresh rate in main menu to stop flickering by ZhilkinSerg
🛠️ Tools.json sorting pt. 7 (#37218) * Tools.json sorting pt. 7 by RarkGrames
🛠️ change curses refresh rate in main menu to stop flickering by davidpwbrown
🛠️ check for max number of tile items when moving in sorting by davidpwbrown
🛠️ Tools.json sorting pt. 6 (#37217) * Tools.json sorting pt. 6 by RarkGrames
🛠️ Tools.json sorting pt. 5 (#37216) by RarkGrames
🛠️ Preserve translation data in harvest message by ymber
🛠️ Update tests Makefile (#37245) Clean object folder on Windows by ZhilkinSerg
🛠️ Tools.json sorting pt. 4 (#37215) * Tools.json sorting pt. 4 by RarkGrames
🛠️ Merge pull request #37247 from Qrox/computer-session Move computer window to a separate class by ZhilkinSerg
🛠️ Merge pull request #37244 from l29ah/plastic-tub-volume increase plastic tub volume to match its contents' by ZhilkinSerg
🛠️ Merge pull request #37246 from Night-Pryanik/monster-examine-ui-fix Fixed "Aware of your presence!" text overlapping monster effects by ZhilkinSerg
🛠️ Adjust tallow health modifier. by CountAlex
🛠️ Move computer window to a separate class by Qrox
🛠️ Fixed "Aware of your presence!" text overlapping monster/npc effects by Night-Pryanik
🛠️ increase plastic tub volume to match its contents' by l29ah
🛠️ Removes trailing 0x85 character in explosives.json (#37243) by BrettDong
🛠️ [[CR] Update Modular Turrets and Salvaged Robots to match Mainline style and recipes Fixes Modular Turrets needs to update to new robotic parts system #35689 ([CR] Update Modular Turrets and Salvaged Robots to match Mainline style and recipes Fixes #35689 #35752) * Add DROPS_AMMO to turrets and appropriate ammo count

Tried to match ammo counts to mainline turrets (probably overkill) and keep within some similar size constraints.

Trying to solve the issue of non-dropping ammunition from Modular Turrets. Base_turret was missing DROPS_AMMO flag that mainline turrets have. Perhaps this will solve the issue. Tried to get ammo counts to match mainline turrets as well.

Add Modules to Auto armor recipes

Added various modules minus the gun module, as the auto armor does not use a gun.

Fix flag structure and ammunition flags/count

Fixed the structure of flags so DROPS_AMMO and immunity flags are again extended so potential changes to base are easier to implement. This would likely be a tidiness issue later. Removed the DROPS_AMMO flag from liquid turrets as they drop inappropriate containers full of liquid. For instance, if ammo count is 10, it drops ten jerrycans full of napalm, however, when placing the turret, it only takes 10 fuel from the jerrycan, making it an infinite napalm loop. Reduced count of "small pillbox" described turrets. Turrets' max ammo when activated is based on the amount in "starting_ammo", so if set to 1, it will only load 1 round. It will ignore the magazine size of the robogun that it uses. Anyway, I upped the amount fuel in the flamer turret to 10000 to represent using an entire jerrycan of napalm as fuel. I'll need to add flags to the robogun_flamer so that it fires more than 1 round at a time like a normal flamethrower.

Remove lights from Turrets and some robots

Robots that intentionally produce light as a function were left alone. Removed lights from most others. Electrical attack robots will still give off light as if they were a shocker.

Remove lightstrip from Arson hack

Presumably its light comes from pilot light.

Removed lighstrips from turrets

Already removed luminance from turrets, needed to remove lightstrips from uncraft recipes.

Remove power armor backpack frames](00fbf22) by CSHague
🛠️ Magazine Item Group Revamp (#37141) overhauled magazine item group -- added magazine categories, removed novels and misc books by LilShiningMan
🛠️ [Removed everything with CUT quality of 2. (Removed everything with CUT quality of 2. #36650) * Removed everything with CUT quality of 2.
Obsoleted a recipe.](0a81a8b) by Kelenius
🛠️ [MOD] INT Based Learning (#37075) by 1n17
🛠️ Provide ability to execute an action from the keybindings menu (#36859) by scrotty
🛠️ Merge pull request #37178 from ZhilkinSerg/mods-json-ammo-effects-no-boom Remove non-existing NO_BOOM ammo effect from mods by Rivet-the-Zombie
🛠️ Three new map extras (#37160) by RarkGrames
🛠️ [Added new dairy farm location (Added new dairy farm location #37221) * Added salt lick item
Added dirt floor with no roof terrain
Added mapgen, overmap special and overmap terrain definitions](7185c16) by Night-Pryanik
🛠️ Tools.json sorting pt. 3 (#37214) * Tools.json sorting pt. 3 by RarkGrames
🛠️ Merge pull request #37236 from anothersimulacrum/falling! Trigger traps after ranged_pull mattack by ZhilkinSerg
🛠️ Merge pull request #37233 from John-Candlebury/leech-plant-harvest Correct harvest lists for leech plants by ZhilkinSerg
🛠️ Merge pull request #37235 from John-Candlebury/dialouge-fix Fix Intercom dialogue tests by ZhilkinSerg
🛠️ Trigger traps after ranged_pull mattack When playing with 3d FOV, grappler zombies could drag the player off of a rooftop position and onto open air, where they just levitated. Prevent players from levitating by triggering traps on the tile they end up on. by anothersimulacrum
🛠️ Fix tests by John-Candlebury
🛠️ Correct harvest lists for leech plants by John-Candlebury
🛠️ Spelling (#37201) by klorpa
🛠️ Merge pull request #37197 from azraneth/mutant_fish Razorclaws & Mutant Fish drop mutant meat by ZhilkinSerg
🛠️ Add radio tower to Hub 01 (#37202) by John-Candlebury
🛠️ Tools.json sorting pt. 2 (#37213) * Tools.json sorting pt. 2 by RarkGrames
🛠️ Merge pull request #37222 from John-Candlebury/intercom-dialogue Minor tweaks to the intercom's speech by ZhilkinSerg
🛠️ Merge pull request #37230 from kevingranade/drop-ranged-firing-times Drop firing times on ranged weapons. by ZhilkinSerg
🛠️ [Make the unique monsters found in Hub 01 missions more resilient (Make the unique monsters found in Hub 01 missions more resilient #37226) * Better armor for the prototype robot
Better armor for the trapped tendril](0c2013f) by John-Candlebury
🛠️ Drop firing times on ranged weapons, this is mostly handled by aiming now. by kevingranade
🛠️ add still back in (#37227) by Kilvoctu
🛠️ Minor tweaks to the intercom's speech by John-Candlebury
🛠️ Fix game crash when alt tabbing (#37159) by 8street
🛠️ Reins controls for horse-powered vehicles (#37148) by davidpwbrown
🛠️ Merge pull request #37196 from curstwist/adjust-domestic-food-loot-spawns adjust food spawns in houses by ZhilkinSerg
🛠️ Merge pull request #37175 from Qrox/fix-maximize-resize Fix terminal size calculation with maximize window option by ZhilkinSerg
🛠️ Merge pull request #37183 from John-Candlebury/json-pred The PRED traits hardcoded effects work based on flags by ZhilkinSerg
🛠️ Merge pull request #37189 from Jerimee/patch-15 m Update JSON_FLAGS.md by ZhilkinSerg
🛠️ Merge pull request #37177 from 1n17/1n17-gravel Change gravel display on curses by ZhilkinSerg
🛠️ Merge pull request #37185 from triper-sk/fix_washing_machine_detergent Fix washing machine detergent manipulation (#37040) by ZhilkinSerg
🛠️ Merge pull request #37198 from SirPendrak/buckwheat_buff Cooked buckwheat buff. by ZhilkinSerg
🛠️ Merge pull request #37180 from Qrox/safemode-proximity Clarify the description of safe mode proximity distance option by ZhilkinSerg
🛠️ Merge pull request #37176 from Qrox/fix-death-cam Fix time not advancing in death cam mode by ZhilkinSerg
🛠️ [Tools.json sorting pt. 1 (Tools.json sorting pt. 1 #37212) * Tools.json sorting pt. 1
Fixed discrepancy
Requested changes](549cb86) by RarkGrames
🛠️ Disable tests for generic_guns mod (#37206) by ZhilkinSerg
🛠️ Fix json format in house_vacant mapgen (#37205) by ZhilkinSerg
🛠️ Fix harvest message translations by ymber
🛠️ Merge pull request #37047 from Trioct/drug_fix Fix using drugs by Rivet-the-Zombie
🛠️ Add varying ammo types to effective ranged test and tweak values to pass again. by kevingranade
🛠️ Add crossbow effective range tests and tweak them to pass. by kevingranade
🛠️ Cooked buckwheat buff. by SirPendrak

CONTRIBUTORS

Last week there were 45 contributors.
👤 tenmillimaster
👤 ZhilkinSerg
👤 RarkGrames
👤 jbytheway
👤 Jerimee
👤 Cyrano7
👤 BrettDong
👤 davidpwbrown
👤 curstwist
👤 Rivet-the-Zombie
👤 jkraybill
👤 John-Candlebury
👤 Brian-Otten
👤 LaVeyanFiend
👤 Fris0uman
👤 foulman
👤 snipercup
👤 wapcaplet
👤 sayke
👤 reinerh
👤 Trioct
👤 I-am-Erk
👤 Ramza13
👤 Qrox
👤 Night-Pryanik
👤 Dziugaske
👤 arijust
👤 esotericist
👤 Inglonias
👤 Maleclypse
👤 saurocyte
👤 ymber
👤 l29ah
👤 LilShiningMan
👤 CountAlex
👤 CSHague
👤 Kelenius
👤 1n17
👤 scrotty
👤 anothersimulacrum
👤 klorpa
👤 kevingranade
👤 Kilvoctu
👤 8street
👤 SirPendrak

STARGAZERS

Last week there were 30 stagazers.
⭐ AleZaTar
⭐ CapitalistLepton
⭐ jieLLL
⭐ Jeremy-amimo
⭐ DanielPetelin
⭐ Xeon-774
⭐ kaeltis
⭐ Harrow9
⭐ chancepryor
⭐ gwyter
⭐ RayWelker
⭐ dsbrgg
⭐ dzerus3
⭐ sigfriedCub1990
⭐ Scrivener07
⭐ Diabolus-Engi
⭐ ZauronDark
⭐ bachelorwhc
⭐ sayke
⭐ Nore5515
⭐ josefadamcik
⭐ Kulkodar
⭐ defaultxr
⭐ maxloh
⭐ stubillwhite
⭐ Moredread
⭐ bglopez
⭐ jubbon
⭐ shreyasminocha
⭐ wagnermc506
You all are the stars! 🌟

RELEASES

That's all for last week, please 👀 Watch and ⭐ Star the repository CleverRaven/Cataclysm-DDA to receive next weekly updates. 😃

You can also view all Weekly Digests by clicking here.

Your Weekly Digest bot. 📆

The text was updated successfully, but these errors were encountered:

weekly-digest bot added the weekly-digest label Jan 26, 2020

ZhilkinSerg closed this as completed Feb 1, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

weekly-digest bot commented Jan 26, 2020

Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

Weekly Digest (19 January, 2020 - 26 January, 2020) #37424

Comments

weekly-digest bot commented Jan 26, 2020

ISSUES

OPEN ISSUES

CLOSED ISSUES

LIKED ISSUE

NOISY ISSUE

PULL REQUESTS

OPEN PULL REQUEST

UPDATED PULL REQUEST

MERGED PULL REQUEST

COMMITS

CONTRIBUTORS

STARGAZERS

RELEASES