Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NPC mission chain fix #37255

Merged
merged 3 commits into from Jan 20, 2020
Merged

NPC mission chain fix #37255

merged 3 commits into from Jan 20, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jan 20, 2020

Summary

SUMMARY: Bugfixes "NPC mission chain fix"

Purpose of change

Fixes #36586
Fixes #35799

Describe the solution

As per mlangsdorfs suggestion here #36586 (comment)

Tested and it seems to fix the issues, and other missions still work ok.
I dont know this area very well, the dialogue structure isnt something im familiar with, but testing seems to suggest its fine.

Describe alternatives you've considered

N/A

Testing

loaded saves from attached issues and confirmed the next mission i nthe chain loads whilst within the same dialogue, other NPC missions completed fine too.

Additional context

N/A

@ZhilkinSerg ZhilkinSerg added <Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Missions Quests and missions labels Jan 20, 2020
@ZhilkinSerg ZhilkinSerg merged commit 4e9ea8c into CleverRaven:master Jan 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bugfix> This is a fix for a bug (or closes open issue) [C++] Changes (can be) made in C++. Previously named `Code` Missions Quests and missions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mission Chain Nullptr Dino Dave Mission NullPtr if asked for new job immediately after completing previous
1 participant