Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error messages while reloading liquid containers. #37296

Closed
ZehCastro opened this issue Jan 22, 2020 · 2 comments
Closed

Error messages while reloading liquid containers. #37296

ZehCastro opened this issue Jan 22, 2020 · 2 comments
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact

Comments

@ZehCastro
Copy link
Contributor

ZehCastro commented Jan 22, 2020

Describe the bug

Two error messages when trying to "reload" a hydration pack. See Images 1 and 2 further below.

DEBUG    : cannot determine reload cost as antibiotic is neither ammo or magazine

FUNCTION : int player::item_reload_cost(const item&, const item&, long int) const
FILE     : src/player.cpp
LINE     : 8221

And:

 DEBUG    : Tried to reload liquid container with non-liquid.
 
 FUNCTION : bool item::reload(player&, item_location, long int)
 FILE     : src/item.cpp
 LINE     : 5758

Steps To Reproduce

Steps to reproduce the behavior in the attached save:

  1. Try to " reload" the hydration pack being worn, either thru the 'r'eload or 'i'nventory examine and 'r'eload.

Expected behavior

A refill screen for me to select available liquids or some sort of message explaining why I can't do that and no error messages. That is expected because it is usually how this system works as seem in "Image 3" below.

Screenshots

Image 1:
image

Image 2:
image

Image 3:
image

Versions and configuration

The info menu described below was not present:
"Main menu (ESC) > Debug Menu > Info > Generate game report"

  • OS: Windows 10
  • Game Version: 0.D-8574-Win64-Tiles from the releases
  • Graphics version: Tiles
  • Mods loaded: Default mods

Additional context

Image 3, showing the menu working, was taken after dropping every worn or carried items but keeping the hydration pack.

Zipped save:
Post Falls.zip

@ZehCastro
Copy link
Contributor Author

In the attached save, if you try the other liquid containers, you get the same error.

@wapcaplet
Copy link
Contributor

Cannot reproduce in 0.E-9737-g511ddcb179 with the save attached to the original report. I can select several available liquids when reloading the hydration pack:

image

Also works in a new game:

image

Guessing this was resolved by nested container changes since the bug was opened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
<Bug> This needs to be fixed Items / Item Actions / Item Qualities Items and how they work and interact
Projects
None yet
Development

No branches or pull requests

3 participants