Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mapgen-defined spawns aren't subject to migration #37372

Closed
tenmillimaster opened this issue Jan 25, 2020 · 1 comment · Fixed by #37803
Closed

Mapgen-defined spawns aren't subject to migration #37372

tenmillimaster opened this issue Jan 25, 2020 · 1 comment · Fixed by #37803
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` <Crash / Freeze> Fatal bug that results in hangs or crashes. Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Milestone
0.E

Comments

@tenmillimaster
Copy link
Member

Describe the bug

Migrations don't apply to map gen defined spawns, such as those in \data\json\mapgen\military\mil_base\mil_base_z0.json

Steps To Reproduce

Spawn world with generic guns
Choose surrounded start
Choose overrun
Make your way to the armoury
Enjoy the segfault, and behold the m4a1's.

Expected behavior

Assault rifles instead.

Versions and configuration

Dark Days Ahead
Disable NPC Needs
Generic Guns
@tenmillimaster tenmillimaster added <Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map labels Jan 25, 2020
@KorGgenT KorGgenT added this to the 0.E milestone Jan 25, 2020
@KorGgenT KorGgenT added the <Crash / Freeze> Fatal bug that results in hangs or crashes. label Jan 25, 2020
This was referenced Jan 26, 2020
Closed
Closed
@Brian-Otten
Copy link
Contributor

Brian-Otten commented Feb 7, 2020 •
edited
Loading

image
Just confirmed this bug.
It seemed to be all the guns in the armory that spawned incorrectly ( that i could check before i crashed).

@ifreund ifreund mentioned this issue Feb 7, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
<Bug> This needs to be fixed [C++] Changes (can be) made in C++. Previously named `Code` <Crash / Freeze> Fatal bug that results in hangs or crashes. Mods: Generic Guns Anything to do with Generic Guns Spawn Creatures, items, vehicles, locations appearing on map
Projects
None yet
Milestone
0.E
Development

Successfully merging a pull request may close this issue.

Migrate direct item spawns ifreund/Cataclysm-DDA
3 participants
@tenmillimaster @KorGgenT @Brian-Otten