Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

give military base more room to spawn #37285

Closed

Conversation

curstwist
Copy link
Contributor

Summary

SUMMARY: Content "Allow military base to spawn across forests as well as fields."

Purpose of change

Seen some reports of people having issues getting this scenario start to spawn. The size makes it difficult to fit in just fields, so this allows it to spawn other OMT types.

Testing

I tried to spawn the start scenario in a default world before and after the adjustment.

This works ok for default size worlds now, I had to try a few times to get it to work in a large city world.

Additional context

@RarkGrames , thanks for this great looking base.

some default world spawns:
base
image

@curstwist curstwist changed the title give military base a more room to spawn give military base more room to spawn Jan 21, 2020
@RarkGrames
Copy link
Contributor

I don't have anything against the forests, my reasoning was that a military base is easier to defend if the approaching enemy doesn't have the cover of a forest when attacking. What were the problems with the spawning?

@curstwist
Copy link
Contributor Author

curstwist commented Jan 21, 2020

The scenario needs to place it on the first overmap chunk, it's difficult for it to find an open field of that size and fails to start the world/scenario. So it takes the player a few times to generate a world that it will spawn in.

this message:
image

@RarkGrames
Copy link
Contributor

I see. I never had that problem, but I guess I haven't tested it more than a couple of hundred times.

@curstwist
Copy link
Contributor Author

I see. I never had that problem, but I guess I haven't tested it more than a couple of hundred times.

Hmm, I haven't had a successful spawn yet with default world settings. Feel free to suggest this change not be added.

@ralreegorganon
Copy link
Contributor

The other thing you can do to ensure that it has more room to spawn but also has the field buffer is to include the buffer of field terrains in the overmap special definition. That way, it can be placed on the map in a space that includes forests and fields, which gives it a much higher placement success rate, but also ensures you have the buffer of fields for verisimilitude reasons.

@RarkGrames
Copy link
Contributor

I have a feeling that something else might be wrong. I was resetting the world very often as I changed the mapgen file, and it was placed correctly. The last change introduced after the massive testing series was the unique and military flags and the occurrence changes.

I would not go for this solution, only if we absolutely have to.

@curstwist
Copy link
Contributor Author

That's fair, l close this and log an issue instead, then you can choose a solution that works for your plan.

@RarkGrames
Copy link
Contributor

Ok, maybe some more discussion will bring a better solution. I will also test it myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants