-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added coverage to underbrush #37307
Added coverage to underbrush #37307
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you're asserting that all vehicles have wheelbases high enough to clear all underbrush? That doesn't add up.
The description talks about "small plants and shrubs", this implies that the shrubs are small enough to bend when driven over and won't do damage to the car, except scratching the finish. Not something that would damage and break parts on the vehicle. What changes are you suggesting? |
I think that's meant to be "smaller than trees". I picture something like this: I believe what Kevin is saying is that we need to work out vehicle clearance probably from wheel size before we say they can all clear the underbrush whether they're on 24" tires or 4" casters |
After looking through the whole file, I noticed underbrush has no coverage (as opposed to the rest of the shrubs with 40 coverage), so I would think that this is not higher than knee level. If it is intended to be more massive foliage, then it would be a good idea to add coverage here too, and modify the description. Otherwise someone else will try to fix it again in the future. That being said I'm not hell-bent on this whole subject, I'm even fine with leaving as it is and closing the PR. |
It would be reasonable to give it some coverage I think. |
What about changing the description? |
I don't think there's anything really wrong with the description, but I have no strong opinions on it one way or the other |
Summary
SUMMARY: None
Purpose of change
Driving over underbrush breaks vehicle headlights etc.
Describe the solution
Adding the
nocollide
flag to all 5 variants of underbrush.Testing
Drove over some underbrush with a vehicle without damaging it.
Edit: Per feedback and requested changes, I've changed the nocollide flag to 40% coverage to match the rest of the shrubs.