new bionics menu #34061
Closed
new bionics menu #34061
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BevapDin
reviewed
Sep 16, 2019
BevapDin
reviewed
Sep 16, 2019
BevapDin
reviewed
Sep 16, 2019
BevapDin
reviewed
Sep 16, 2019
BevapDin
reviewed
Sep 16, 2019
BevapDin
reviewed
Sep 16, 2019
Also added reset for SkillDisplayType
AMurkin
reviewed
Sep 17, 2019
|
Tabs with passive/inactivatable CBMs have columns too. Not sure if this is a problem, but they take up space. |
BevapDin
reviewed
Sep 17, 2019
ZhilkinSerg
added
[C++]
Added a field in json to hide those |
|
It shows |
AMurkin
reviewed
Sep 18, 2019
cleaning up code a little fixing help keybinding
fixing Return crashing with empty list
|
Can you add documentation for |
Merge branch 'master' into bionics_ui # Conflicts: # data/json/bionics.json # src/bionics_ui.cpp # src/skill.cpp
* Display damage per second in the item info So you can quickly eyeball the weapon effectiveness versus plain meatbags * Added DPS to tests
ZhilkinSerg
requested review from
I-am-Erk,
John-Candlebury and
KorGgenT
as code owners
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
ad63e77
to
8e68539
Compare
kevingranade
force-pushed
the
dev
branch
4 times, most recently
from
621a68e
to
b7106d0
Compare
ZhilkinSerg
force-pushed
the
dev
branch
3 times, most recently
from
0f30a43
to
d432807
Compare
|
I'm afraid this was bad timing, this was large but I don't think it was originally as large as the eat menu changes, but it has horrific conflicts now, feel free to reopen if you feel like working on it again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Interface "Improveing bionics menu UX"
Purpose of change
Hard to find desired bionic in the menu.
Describe the solution
Add more tabs for different bionics categories
CBM description is always on the screen
Data is tabulated
Describe alternatives you've considered
There might be better ways to categorize. I was conservative, so if CBM can fit into multiple it just goes into 'other'.
Faulty can be put as passive with different color
Additional context
Categories are controlled by .json, so it's easy to modify.
Sensory - how you percieve the world (eyes, ears, sonar...)
Internal - internal body functions (blood, brain, muscles...)