Clarify the description of safe mode proximity distance option #37180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…when creating default safe mode rule
ZhilkinSerg
added
[C++]
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: None
Purpose of change
Safe mode proximity distance option only has effect when there's no safe mode rule specified, which is not that obvious from the option's description.
Describe the solution
Update the description to clarify it a bit. It now also copies the value of the option when creating the default rule.
Describe alternatives you've considered
Take the option value into consideration when checking safe mode rules?
Testing
Opened options menu to check the updated description.
Created the default rule in safemode manager and the default distance was copied from the option value.