Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explosives disassembly #37052

Merged
merged 12 commits into from
Apr 7, 2020
Merged

Conversation

Brian-Otten
Copy link
Contributor

@Brian-Otten Brian-Otten commented Jan 14, 2020

Summary

SUMMARY: Content "Lets the player disassemble explosives'"

Purpose of change

As of now you can disassemble only a very small portion of launcher ammo/ explosives, and when you can it gives you pure rdx crystals, which is unrealistic and is also currently only used in making the 60L RDX barrel explosive.

Describe the solution

Added composition-b. This heat castable stabilized explosive and its variants are found in most military explosive munitions. Crafting items using composition B will require a forge and a crucible to recast the explosive.

Added impact and delay fuzes. these are needed to set off stabilized explosives and are found in rockets and grenades respectively.

Added disassembly of all launcher ammo (that i found. it's not impossible i missed one)

Added disassembly of the 120mm tank round.

Added the first new recipe using composition-b, an alternate method to make a pipebomb.

Corrected some weight values that had incongruities with real life.

Some ammo types move out of ammo.json and into their own files.

Describe alternatives you've considered

I wasn't sure how i should handle explosives in mods, mostly blazemod, because they already have their own methods of crafting and disassembly tables. they have been left untouched, but i could give them the same treatment.

I wasn't sure if i should give composition-b and the fuzes a "look-like" flag so haven't yet, would like feedback.

Currently disassembling most explosives takes fabrication 6, it could perhaps be lowered but i think this might be about right for having the confidence to take a hacksaw to a warhead.

Testing

Loaded up the game, disassembled all the added ammo, used the items i got from that to make some pipe bombs, and used them against some zombies.

Additional context

Sources used when determining disassembly results:

http://gunrf.ru/rg_granatomet_ps-7_PG-7WL_eng.html
https://en.wikipedia.org/wiki/PG-7VR
http://gunrf.ru/rg_granatomet_ps-7_TBG-7V_eng.html
http://roe.ru/eng/catalog/land-forces/strelkovoe-oruzhie/grenade-launchers/og-7v/
https://books.google.nl/books?id=K7XOZEt5gDQC&pg=SA2-PA21&lpg=SA2-PA21&dq=1.3+pounds+of+TPA&source=bl&ots=58qdsoj9Yl&sig=ACfU3U1OLrhdow30_BWIaGKN31Pie40VJw&hl=nl&sa=X&ved=2ahUKEwi0qsve7IHnAhVJL1AKHe3GAioQ6AEwAHoECAYQAQ#v=onepage&q=1.3%20pounds%20of%20TPA&f=false
https://www.defence.gov.au/UXO/_Master/docs/Types/Rocket84mmSRAAW-Rev01.pdf
https://fas.org/man/dod-101/sys/land/m830a1.htm
http://bulletpicker.com/cartridge_-120mm-heat-mp-t_-m2.html
https://cdn2.hubspot.net/hubfs/208537/assets/PDF/Direct%20Fire%20Munitions%20Sheets/120mmTankM830%20OK.pdf

When i could not find exact values for amount of material in the explosives i made best effort estimates comparing to similar rockets and to the own rockets weight/size/purpose.
Where CDDA did not have the materials used in the rocket i either used closest analogue (http://cdda-trunk.chezzo.com/incendiary), or omitted the materials for now (military solid rocket fuel)

Further changes to the disassembly results should be much easier to work on with this PR as a base.

image

Any maintainers please feel free to edit the file as you see fit.

Allows you to disassemble all a launcher ammo.
Moves some launcher ammo to dedicated .json files.
Adds a new recipe for the pipebomb using composition B
Adds chem_composition B
Adds delay_fuze and impact_fuze
Added disassembly of 40x46mm grenades.
Since the player cannot unload the LAW you can now disassemble the packed LAW.
@ghost
Copy link

ghost commented Jan 14, 2020

Crafting items using composition B will require a forge and a crucible to recast the explosive.

Considering 215-240C melting point range for CompB that seems a bit excessive, perhaps plastic mold and surface heat would be more appropriate.

Where CDDA did not have the materials used in the rocket i either used closest analogue (http://cdda-trunk.chezzo.com/incendiary), or omitted the materials for now (military solid rocket fuel)

Closest analogue of military solid rocket fuel would also be incendiary (mixture of ammonium perchlorate and aluminium/magnesium powder).

@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Jan 14, 2020

I considered letting people use surface heat, but my internal argument against it was that some of the tools use pretty much direct flames, and the player would really not want to risk localized hotspots. so you use the forge to get the temp just right, melt the whole thing, then cast it. This is not writ in stone, if we can think of a way to have the survivor reliably use his mess kit that would be fine by me too.

As for plastic mold instead of crucible, maybe. i think it might be cutting it close temperature wise. 215C would be to hot for a decent portion of plastics.

PS:
I don't think i want to turn rocket fuel into incendiary, it would make it very confusing how much of the "incendiary" in rockets is their warhead, and how much their fuel, when rocket fuel does get added. Gameplay wise i think very few players are short of incendiary right now, and there is already a large source of extra incendiary in the rockets now.

@ghost
Copy link

ghost commented Jan 14, 2020

Direct flame is a no go without an oil/sand batch, and personally I'd use batch with electric as well.
For melting vessel itself kitchenware pots are fine, but you do rise good point - normal mold might be cutting it bit too close (on top of it being magical, shape-shifting abstract item), molding into sand/clay would be more appropriate.
PS. Whilst I'm not exactly sure how good an 'incendiary ' an incendiary would be, but judging from the recipe, it would make fantastic solid rocket propellant (in fact that exact composition was and is used for military and improvised devices).

@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Jan 14, 2020

image
The new pipe bomb recipe. Skilled survivors can now use the large amount of explosive they might gather from something like a 120mm tank round and use it to make a large number of gunpowder primed pipe bombs.

If this PR merges (or if it's decided we want to add in this PR) my next project will be adding 3-5 more recipes the player could use their new supply of composition-b in, some of them using the new fuzes.

PS: I'm not able to find why the c++ test seems to be failing. If anyone better than me at looking through the logs could spot what the cause is it would be much appreciated.
PPS: Think i ended up finding thanking to some help from the discord, "should" be fixed now.

@ghost
Copy link

ghost commented Jan 14, 2020

You're doing god's work with this stuff. Have some breaching charges anywhere in your sights? Having to use whole C4 brick to blast metal doors was the reason I ever put explosives on my list (never got to it, but that's a different story).

@Brian-Otten
Copy link
Contributor Author

Stuff i was thinking of for the future:
Homemade version of the c4 using a bunch of compound-b and a fuze with some kind of timer.
alternate craft/version of the explosive crossbow bolt.
shaped charge that functions more like an instant jackhammer (this might be tricky coding to make it feel right/realistic)
Larger improvised "grenade" with a large explosive charge and a lot of shrapnel. think 3-5 kilos.
Adding more rockets to the improvised rocket launcher that use the new parts (maybe just converting the old "unrealistic" improvised rockets)

@ghost
Copy link

ghost commented Jan 15, 2020

shaped charge that functions more like an instant jackhammer (this might be tricky coding to make it feel right/realistic)

That's what I meant by breaching charge, I reckon it would just require creating iuse interface for activating and placing charge in the wall/doors and picking the right explosion power. Proper shaped charge would be a lot of fiddling with explosion code and interfaces to direct and scale the blast.

Copy link
Member

@tenmillimaster tenmillimaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for your 40mm uncraft recipes, please refer to :#35865 (comment)

Some of your primers listed are incorrect.

...Also why are you using a screwdriver and a hacksaw to deconstruct the grenades? There's no way you'd recover primers with such crude materials.

@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Jan 15, 2020

Thanks for the heads up, had used the materials i saw in the 40x53mm for the 40x46, will use that data and correct.
What tools should be used for disassembly of the grenades?
PS: 40mm grenade unloading changed according to directions on discord.

As requested by tenmillimaster.
@curstwist curstwist added [JSON] Changes (can be) made in JSON Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 16, 2020
@anothersimulacrum
Copy link
Member

Crafting items using composition B will require a forge and a crucible to recast the explosive.>

You should make a requirement for this and use it, it will make this much easier to maintain.

@Brian-Otten
Copy link
Contributor Author

Could you contact me and let me know how that works? If you mean what i think you mean that would be ideal, but not sure if/how that's possible.

New standard used in pipebomb.
lg_pistol_primer corrected to lgpistol_primer.
@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Jan 16, 2020

Added the explosives_casting_standard and made the new recipe use it.

@Brian-Otten
Copy link
Contributor Author

Opened an issue for how we might handle rocket fuel in the future. Adding a full system for rocket fuel (and the places it might be used) in this PR is out of scope for me right now, but is something i (or others) can work on in the future.

@Brian-Otten
Copy link
Contributor Author

Resolved a very simple merge conflict resulting from #36999

@mkikt4743
Copy link

it's spelled fuse not fuze, also should be using fine cutting, fine screw, fine bolt turning, etc, maybe fine metal sawing

@Brian-Otten
Copy link
Contributor Author

https://en.wikipedia.org/wiki/Fuze

A fuse is a burning piece of rope that will ignite something, while a fuze is a mechanical/electronic detonator that will trigger under certain conditions.

I don't think the survivor would need all the fine tools to simply tear the round apart and pull out the raw material, but i might be overlooking something.

I had not realized artillery propellant came in 1g portions.
@Brian-Otten
Copy link
Contributor Author

Brian-Otten commented Apr 1, 2020

Fixed merge conflicts and gave this a once over. this should be good to go to merge in 0.E experimental. I'll try to contact tonkatsu to resolve the requested changes, they've been made according to his suggestions.

@ZhilkinSerg ZhilkinSerg merged commit d09e3ad into CleverRaven:master Apr 7, 2020
@tenmillimaster
Copy link
Member

Brian and I discussed a number of issues with the explosives dissassembly of 40mm projectiles; This should get re-visited when we have more reloading infrastructure in place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items: Ammo / Guns Ammunition for all kinds of weapons and these weapons themselves Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants