-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Blazemod refactor #35957
[WIP] Blazemod refactor #35957
Conversation
We have naming conventions? Where are those defined? And for directories as well? |
First there is |
At least remove the redundant "blaze_" prefix from all files. |
Will do. |
Almost ready! Will be testing tomorrow, dunno how long it will take due to IMMENSE amount of automated turrets removal and the need to spawn all the blazemod stuff to test renaming and separation to smaller files. |
How is this coming along? |
I'm sorry for going dark, but currently there are some real life issues and changes in my work schedule that leave me almost no free time, so I was unable to do any tests. In a new-year holidays I was only able to rebase my refactor forward to resolve most of the conflicts (actually I rebased the file rename commits and redid everything else again). I hope that in a few weeks I will be able to devote more time to actually do the tests, but at least in a January chances are slim. |
fdae03a
to
b2f24fb
Compare
I will mark it as a long term, so it won't be closed by |
Closing in favor of #37497. Feel free to collaborate with @Soup-de-Loop to update blazemod, make changes in current PR to resolve conflicts and ping me to reopen (or open new PR). |
Summary
SUMMARY: Mods "Refactor and restructure blazemod"
Purpose of change
Update blazemod structure to mirror dda structure, make it easier to support, obsolete some items
Describe the solution
Blazemod is updated on an infrequent basis and is out of sync with internal dda structure changes (directories, naming conventions, etc). Also there are places where 'copy-from' can be used much more extensively.
Move (and rename) files to their respective directories to (mostly) match dda structure.
Restructure blob items and vehicle parts (split to several smaller files to match vehicle parts structure of dda - ie frames, wheels, boards, engines, turrets, etc).
Remove redundant "blaze_" prefix from all files.
Refactor and split blaze_test.json and move recipes to recipes, items to items, vehicle parts to vehicle parts, etc.
Dispose of automated turrets (turret automation is another item from vanilla now, not a turret flag), migrate automated turrets id's to manual ones.
Testing all the stuff changed
Describe alternatives you've considered
Keep it as it is now?
Testing
Generate the game with all blazemod content.
Update mod.
Load the game, check items, vehicles, ensure that everything is migrated properly.