Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add wind chimes #36625

Closed
wants to merge 2 commits into from
Closed

Add wind chimes #36625

wants to merge 2 commits into from

Conversation

AlexMooney
Copy link
Contributor

@AlexMooney AlexMooney commented Jan 1, 2020

Summary

SUMMARY: Content "Adds wind chimes"

Purpose of change

Wind chimes can be set up at a base to provide a small music morale buff. When they're added to houses, they can attract zombies.

Testing

Made the new field visible, deployed a wind chime, saw the field go up. Grabbed and moved the wind chime and the field moves. Smashed a deployed chime. Checked the morale effects.

Remaining work

  • Pick a useful looks_like for the item and the furniture. I'm open to suggestions!

For a later PR

  • Add a crafting recipe
  • Spawn furniture in yards, rarely
  • Spawn item in lawn and garden stores

data/json/field_type.json Outdated Show resolved Hide resolved
data/json/field_type.json Outdated Show resolved Hide resolved
@I-am-Erk I-am-Erk added [C++] Changes (can be) made in C++. Previously named `Code` [JSON] Changes (can be) made in JSON Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 5, 2020
@I-am-Erk
Copy link
Member

I-am-Erk commented Jan 5, 2020

Is it possible that the music message could be moved to JSON, as well as the fact that it counts as music, and then the field code changed to fd_wind_sound? That would allow the same field effect to be added to other things that make noise in the wind, so that windmills could creak for example.

@AlexMooney
Copy link
Contributor Author

@I-am-Erk that's an interesting idea. I'll give it a shot when I get a chance.

@Fris0uman
Copy link
Contributor

i'm not sure how hard it would be but it would be cool if instead of hardcoding fd_wind_chimes you were adding a flag or a bool to fields to use wind to set their intensity. So instead to check for curtype == fd_wind_chimes you'd check for somthing like field.is_wind_dependent. That way other field could be set to use your code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants