Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge Makeshift Items Mod into base game, pt 1. #37275

Closed

Conversation

Kelenius
Copy link
Contributor

@Kelenius Kelenius commented Jan 21, 2020

Summary

SUMMARY: Mods "Moved makeshift Kevlar vest from Makeshift Items Mod to base game."

Purpose of change

Discussed in #26809. (Better late than never). Not related to #37272, though its appearance was the kick I needed to finish this.

Describe the solution

Mod merged fully; it's very small and all items are pretty straightforward.

Given how small it is, I'm not even sure how it came to be and why these items weren't a part of the base game in the first place. Did the original author have grander plans for it? Well I was completely incorrect.

Makeshift Kevlar vest moved over; recipe changed from 5 minutes to 30.

This recipe is pretty similar to XL Kevlar vest. The resulting item ends up with 6 bash and 12 cut protection (vs 8/16 of the regular one). Given the skill requirement and needing fairly rare materials, that seems reasonable.

Describe alternatives you've considered

I see no room for variance.

Should protection be lowered even further? Should it have increased encumbrance?

Testing

Game compiles, loads, new recipes and items appear.

data/json/recipes/weapon/mods.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/mods.json Outdated Show resolved Hide resolved
data/json/recipes/armor/torso.json Outdated Show resolved Hide resolved
data/json/recipes/weapon/mods.json Outdated Show resolved Hide resolved
@ymber
Copy link
Member

ymber commented Jan 21, 2020

None of these items are actually feasible. They weren't in core because they got rejected.

@I-am-Erk I-am-Erk added [JSON] Changes (can be) made in JSON Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact labels Jan 21, 2020
@Kelenius Kelenius changed the title Merged Makeshift Items Mod into base game. Merge Makeshift Items Mod into base game, pt 1. Jan 23, 2020
@Kelenius
Copy link
Contributor Author

Okay, so this turned out to be more involved than just moving the jsons over, so I'm going to look at the Kevlar vest, pistol bayonets, and sword bayonets separately. First would be the makeshift Kevlar vest. I've updated the OP.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Feb 22, 2020
@Kelenius
Copy link
Contributor Author

anothersimulacrumToday at 22:40
In the mean time, comment on that or something to unstale it

@stale stale bot removed the stale Closed for lack of activity, but still valid. label Feb 22, 2020
@CleverRaven CleverRaven deleted a comment from stale bot Feb 22, 2020
@kevingranade
Copy link
Member

So it's a vest entirely made of kevlar panels stitched together with thread? I'm quite certain that's not a workable solution.

I recommend if you want these items in mainline, take the barest outline of what's in the mod and make a new recipe starting from first principles, because as has been pointed out, the items in the mod are deeply flawed.

@Kelenius Kelenius deleted the MakeshiftItemsInclusion branch December 4, 2020 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Crafting / Construction / Recipes Includes: Uncrafting / Disassembling Items / Item Actions / Item Qualities Items and how they work and interact [JSON] Changes (can be) made in JSON
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants