Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mod Inclusion Project: Makeshift Items Mod #26809

Closed
DracoGriffin opened this issue Nov 22, 2018 · 6 comments
Closed

Mod Inclusion Project: Makeshift Items Mod #26809

DracoGriffin opened this issue Nov 22, 2018 · 6 comments
Labels
Mods Issues related to mods or modding <Suggestion / Discussion> Talk it out before implementing

Comments

@DracoGriffin
Copy link
Contributor

Use the following issue as a space to discuss the inclusion of:

Mod Ident: makeshift
Name: Makeshift Items Mod

Your comment should include:

Suggestions for induction

(what parts of the mod should be included, can be as simple as just an item, a location or the complete inclusion)

Incompatibilities

(what parts of the mod should not be included, either some objects / items or entire mod is conflicting with DDA theme [ for whatever reason ])

@DracoGriffin DracoGriffin added <Suggestion / Discussion> Talk it out before implementing Mods Issues related to mods or modding labels Nov 22, 2018
@DracoGriffin
Copy link
Contributor Author

Going to close for lack of interest and discussion.

@Kelenius
Copy link
Contributor

I'm interested, please reopen this issue.

This mod adds:

  • makeshift Kevlar vest, makeshift pistol bayonet, makeshift sword bayonet;
  • crafting recipes for these items;
  • crafting recipes for the regular pistol bayonet and the regular sword bayonet;
  • sword bayonet and pistol bayonet are added to some item groups.

I think that this mod should be moved to the base game as it is.

@Cyrano7
Copy link
Member

Cyrano7 commented Dec 24, 2018

@Kelenius I'm pretty sure these were in the game and were removed then readded in a mod if I remember correctly.

@Night-Pryanik Night-Pryanik reopened this Dec 24, 2018
@Kelenius
Copy link
Contributor

Quick search doesn't indicate that to be the case, can you find a link?

@Cyrano7
Copy link
Member

Cyrano7 commented Dec 25, 2018

@Kelenius It's in the first commit in the file history for the mod. This was the PR and the other PR for the bayonets is linked to it #18272

@Kelenius
Copy link
Contributor

Looking at it, the only item moved was the makeshift kevlar vest, that has been in a game for a long time before that, and I can't find any discussions about why it was removed. The rest was added to the mod after that, and then it all laid untouched for more than two years. I don't see a reason not to merge the mod into the base game.

@DracoGriffin DracoGriffin added the Good First Issue This is a good first issue for a new contributor label Apr 7, 2019
@kevingranade kevingranade removed the Good First Issue This is a good first issue for a new contributor label May 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mods Issues related to mods or modding <Suggestion / Discussion> Talk it out before implementing
Projects
None yet
Development

No branches or pull requests

5 participants