Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR] Removed penalties and base cost when calculating obtain_cost() for wielded item #33271

Merged
merged 4 commits into from
Apr 30, 2020
Merged

[CR] Removed penalties and base cost when calculating obtain_cost() for wielded item #33271

merged 4 commits into from
Apr 30, 2020

Conversation

Raschert0
Copy link
Contributor

@Raschert0 Raschert0 commented Aug 16, 2019

Summary

SUMMARY: Balance "Reloading wielded items now costs less than reloading items in inventory"

Purpose of change

I found, that obtain_cost() call (i.e., when reloading something) returns the same value both for wielded and for stored in inventory items. Maybe this is intended, but it isn't looking like that

Describe the solution

So, when obtain_cost() is called for item, whose owner (who) is_armed() and has this item (target()) as weapon, we calculate item_handling_cost() without penalties (like it is done for holsters) and with zero base_cost (because item is already in hands)

Describe alternatives you've considered

Maybe there can be non-zero base_cost or something else, but I don't think that I know how to do it in another way

Additional context

@ZhilkinSerg ZhilkinSerg added [C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. NPC / Factions NPCs, AI, Speech, Factions, Ownership labels Aug 16, 2019
@stale
Copy link

stale bot commented Sep 20, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Sep 20, 2019
@stale
Copy link

stale bot commented Oct 20, 2019

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

@stale stale bot closed this Oct 20, 2019
@Night-Pryanik Night-Pryanik reopened this Oct 20, 2019
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Oct 20, 2019
@stale
Copy link

stale bot commented Nov 19, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Nov 19, 2019
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Nov 21, 2019
@stale
Copy link

stale bot commented Dec 21, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Dec 21, 2019
@Night-Pryanik Night-Pryanik removed the stale Closed for lack of activity, but still valid. label Jan 20, 2020
@stale
Copy link

stale bot commented Jan 24, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not 'bump' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

@stale stale bot added the stale Closed for lack of activity, but still valid. label Jan 24, 2020
@stale stale bot removed the stale Closed for lack of activity, but still valid. label Jan 30, 2020
@ZhilkinSerg ZhilkinSerg merged commit 6592a39 into CleverRaven:master Apr 30, 2020
@Raschert0 Raschert0 deleted the NoPenaltiesForObtainingWieldedItems branch May 1, 2020 03:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C++] Changes (can be) made in C++. Previously named `Code` Game: Balance Balancing of (existing) in-game features. NPC / Factions NPCs, AI, Speech, Factions, Ownership
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants