Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed pluralization of bone/acorn/corn/oatmeal and yeast. #37371

Closed
wants to merge 1 commit into from

Conversation

jkraybill
Copy link
Contributor

@jkraybill jkraybill commented Jan 25, 2020

Summary

SUMMARY: Content "fixed plural forms of yeast, cornmeal, oatmeal, acorn meal, and bone meal."

Purpose of change

To correctly pluralize *meal and yeast so they aren't described as "bags of yeasts" or "boxes of cornmeals".

Describe the solution

Currently, contained items get auto-pluralized in grammatically incorrect ways, e.g. "3 plastic bags of yeasts" or "2 small cardboard boxes of cornmeals".

This change adds plural forms to the json, so these items are correctly described, e.g. "3 plastic bags of yeast" or "2 small cardboard boxes of cornmeal".

I added fixed pluralization to a couple items that are not currently contained (bone meal and acorn meal) in case they are put in containers in the future, but those pluralizations don't currently change in-game behavior.

Describe alternatives you've considered

The only real alternatives would be doing nothing, or petitioning the Oxford English Dictionary to change the plural form of "oatmeal" to "oatmeals".

Testing

I tested this using spawn item in debug mode to spawn single and multiple contained and non-contained units of oatmeal, corn meal, acorn meal, bone meal, and yeast. Verified that pluralizations have changed from "bags of yeasts" to "bags of yeast" and from "boxes of oatmeals" to "boxes of oatmeal".

Additional context

I would not be surprised if there are other instances of this occurring, these were the ones I have noticed so far. If I find others I'll fix them.

@KorGgenT
Copy link
Member

since you're already in those files, do you mind using the new syntax?
"name": { "str": name, "str_pl": plural name }

@jkraybill
Copy link
Contributor Author

since you're already in those files, do you mind using the new syntax?
"name": { "str": name, "str_pl": plural name }

Will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants