Change curses refresh rate in main menu to stop flickering #37259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZhilkinSerg
added
<Bugfix>
This was referenced Jan 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
SUMMARY: Bugfixes "Change curses refresh rate in main menu to stop flickering"Purpose of change
Makes #37191 a non-blocker.
Describe the solution
Followed ifreunds diff suggestion on that linked issue,
I didnt get the flicker on my ubuntu terminal anyway, but I installed alacritty, and then I saw it happening, applied the fix, no more flickering.
Describe alternatives you've considered
Not making PRs from other peoples suggested diffs and taking all the glory for myself, but I decided it was best that I do take all the glory.
Testing
As above
Additional context
As per Ifruends comment here : - #37191 (comment)
"This is only changing the input timeout. It doesn't affect responsiveness to input at all, only how long the game waits for input each loop before deciding to move on. If anything, this patch would marginally increase input responsiveness.
If we had a proper solution to handling resizing as outlined above the timeout could be made infinitely large without issue."
Dosnt close the issue, but makes it a non-blocker.