Fix pyyang issue 202012 #15902

…net#12436) co-authorized by: [email protected] Why I did it Now, checkout code step and KVM test job can't be cancelled even though the whole build is cancelled. That's because by using Azure Pipeline Conditions, we customized the running condition, and we need to react to the Cancel action explicitly by asserting 'succeeded' https://learn.microsoft.com/en-us/azure/devops/pipelines/process/expressions?view=azure-devops#succeeded https://learn.microsoft.com/en-us/azure/devops/pipelines/process/conditions?view=azure-devops&tabs=yaml#ive-got-a-conditional-step-that-runs-even-when-a-job-is-canceled-how-do-i-manage-to-cancel-all-jobs-at-once How I did it Assert 'succeeded' condition explicitly. How to verify it Verified by cancelling and rerunning the azure pipeline.

commit aa8fe6deff466909909430f00598d2dba9490904 (HEAD -> 202012, origin/202012) Author: Jing Zhang [email protected] Date: Tue Oct 11 10:22:02 2022 -0700 [Active-Standby] avoid posting mux metrics event when receiving unsolicited mux state notification (sonic-net#142) Description of PR Summary: Fixes # (issue) This PR is to fix incorrect mux metrics timestamps caused by unsolicited mux state notification. Sign-off: Jing Zhang [email protected] sign-off: Jing Zhang [email protected]

…nic-net#10770) (sonic-net#10794) Add dependencies device/*

…sonic-net#12461) Why I did it Cherry-pick from sonic-net#8950 Sonic-swss-common requires gmock for staged unit tests How I did it Installed dependency in sonic-buster-build docker file How to verify it rebuild the build container

Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]>

…nic-net#12467) Why I did it Cherry pick sonic-net#9519. when we remove a port and add it back immediately - lldp is keep failing warning message keeps appearing: [WARN/lldp] unable to send packet on real device for Ethernet4: No such device or address How I did it on delete link events it will immediately execute delete without using aggregate events mechanism. How to verify it Run autorestart/test_container_autorestart.py in sonic-mgmt repo Or manual test steps: sudo config feature autorestart swss disabled docker exec swss supervisorctl status docker exec swss kill -SIGKILL 111(orchagent) docker inspect -f {{.State.Running}} swss => make sure swss is running docker exec swss supervisorctl start orchagent Signed-off-by: Zhaohui Sun <[email protected]>

…mhf platform issue (sonic-net#12284) Signed-off-by: mlok <[email protected]> Signed-off-by: mlok <[email protected]>

- Skip the interface status check if the interface does not exist. In the future, when the interface is created/comes up this check will be triggered again. Signed-off-by: Lawrence Lee <[email protected]>

* [action] Add code scan for python

* Fix to improve hostname handling If config_db.json is missing hostname entry, hostname-config.sh ends up deleting existing entry too and hostname changes to default 'localhost' * default hostname to 'sonic` if missing in config file

Update sonic-swss submodule pointer to include the following: * 08711a8 [orchdaemon]: Fixed sairedis record file rotation ([sonic-net#2481](sonic-net/sonic-swss#2481)) Signed-off-by: dprital <[email protected]>

… (sonic-net#12454) * [TestbedV2]Migrate t0 and t1-lag to TestbedV2 (sonic-net#12383) signed-off-by: [email protected] Migrate the t0 and t1-lag test jobs in buildimage repo to TestbedV2. Why I did it Migrate the t0 and t1-lag test jobs in buildimage repo to TestbedV2. How I did it Migrate the t0 and t1-lag test jobs in buildimage repo to TestbedV2. Remove ceos type setting Use 202012 branch as sonic-mgmt branch * Modify template to use 202012 branch

7272bf37 Revert "Revert "[DHCPv6] [202012] Update the dhcpv6_relay config/show cli (sonic-net#2271)" (sonic-net#2336)" (sonic-net#2459) Signed-off-by: Vivek Reddy <[email protected]>

- Why I did it Update SDK/FW version - 4.5.3186/2010_3186 in order to have the following changes: New functionality: 1. Added support for 6.5W (Class 8) in ports 49-50, 53-54, 57-58, and 61-62 on SN4600 system Fix the following issues: 1. On very rare occasion (~1/100K), during I2C transaction with MMS1V50-WM and MMS1V90-WR modules on SN4700 system, the module may send unexpected stop which violate the I2C specification, possibly affecting the link up flow 2. When running 1GbE speeds on SN4600 system, the port remained active while peer side was closed 3. While toggling the cable with ‘sfputil lpmode on/off’, error msg like “ERR pmon#xcvrd: Receive PMPE error event on module 1: status {X} error type {y}” could be received 4. When toggling many ports of the Spectrum devices while raising 10GbE link up and link maintenance is enabled, the switch may get stuck and may need to be rebooted 5. When trying to reconfigure the Flex Parser header and Flex transition parameters after ISSU, the switch will returned an error even if the configuration was identical to that done before performing the ISSU 6. While moving from lossless to lossy mode while shared headroom was used, reduction of the shared headroom can only be done prior to pool type change and when shared headroom is not utilized 7. SLL configuration is missing in SDK dump 8. If TTL_CMD_COPY is used in Encap direction for a packet with no TTL, then the value passed in the ttl data structure will be used if non-zero (default 255 if zero) 9. PCI calibration changes from a static to a dynamic mechanism 10. Layer 4 port information is not initialized for BFD packet event. To address the issue, remote peer UDP port information was added in BFD packet event 11. SDK returned error when FEC mode is set on twisted pair, when FEC was set to None - How I did it Update pointer for the SDK/FW - How to verify it Run regression tests Signed-off-by: dprital <[email protected]>

…12399) - Why I did it ethtool is not able to read certain pages(eg. page 11h) of CMIS cables. SDK provides a set of sysfs to expose the transceiver EEPROM, now we migrate from using ethtool to read these sysfs for transceiver EEPROM reading. - How I did it replace ethtool with accessing the SDK sysfs for cable EEPROM reading. Adjust the offset according to the SDK sysfs memory map. - How to verify it run sonic-mgmt sfp-related regression test case. Signed-off-by: Kebo Liu <[email protected]>

…12551) Update sonic-platform-common submodule pointer to include the following: * a2164f6 [202012] Fix issue: sff8436 does not support decoding power class 5~7 ([sonic-net#317](sonic-net/sonic-platform-common#317)) * 6722b4e Update the return of update_firmware for the image not exist case ([sonic-net#306](sonic-net/sonic-platform-common#306)) Signed-off-by: dprital <[email protected]>

…12500) Signed-off-by: Kebo Liu <[email protected]> Signed-off-by: Kebo Liu <[email protected]>

…k approval (sonic-net#12509) (sonic-net#12541) Co-authored-by: Liu Shilong <[email protected]>

…t#12478) * [202012][RDMA] create split profiles for Arista-7050CX3-32S Manually cherry-picking sonic-net#12228. Signed-off-by: Ying Xie <[email protected]>

…d in ACL rule than caclmgrd gets exception (sonic-net#12577) Why I did it Creating this PR to take changes from sonic-net/sonic-host-services#21

…#12581) (sonic-net#12617) Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]>

Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]>

Why I did it Without LPM enabled, the routing table size is very small. How I did it Enabling LPM. Signed-off-by: Ying Xie [email protected]

* Add lossy scheduler for queue 7

[202012][sonic-linkmgrd] update submodule cf7274a Jing Zhang Mon Nov 7 14:50:40 2022 -0800 [active-standby][active-active] update link prober stats updating frequency to 30s (sonic-net#152) (sonic-net#155) sign-off: Jing Zhang [email protected]

Typo in prior PR sonic-net#11919 hardcodes Vlan name. Change command to use the $vlan variable instead Signed-off-by: Lawrence Lee <[email protected]>

Include following commit: a60f4b9 [202012][Recorder]: Acquire lock for ofstream changes (sonic-net#1144) Signed-off-by: Lawrence Lee <[email protected]>

git log --oneline aacb772..202012 these commits are added in sonic-platform-daemons 8ec96c0 (HEAD -> 202012, origin/202012) [ycabled] fix exception-handling logic for ycabled (sonic-net#312) 3d5470d [ycabled] move swsscommon API's from subroutines to call them exactly once per task_worker/thread (sonic-net#310) Signed-off-by: vaibhav-dahiya <[email protected]> Signed-off-by: vaibhav-dahiya <[email protected]>

Why I did it nameserver and domain entries from build system fsroot gets into sonic image. How I did it Clear /etc/resolv.conf before building image How to verify it Built image with it and verified with install that /etc/resolv.conf is empty

…#12672) Add dualtor test jobs using TestbedV2 in 202012 branch. Why I did it Add dualtor test jobs using TestbedV2 in 202012 branch. How I did it Add dualtor test jobs using TestbedV2 in 202012 branch. Signed-off-by: Yutong Zhang <[email protected]>

* fix sai-ptf docker build error Signed-off-by: richardyu-ms <[email protected]> * correct the docker image version Signed-off-by: richardyu-ms <[email protected]> * update thrift package Signed-off-by: richardyu-ms <[email protected]> * fix version upgrade issue in 202012 Signed-off-by: richardyu-ms <[email protected]> * remove useless file Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: richardyu-ms <[email protected]>

#### Why I did it Include below commits ``` 00b4dc0 2022-11-14 | Remove error logging on "failed in fdb_vlanmac" (sonic-net#272) [Qi Luo] 792afe8 2022-11-14 | Don't cache the vlan-id if it is not valid from DB (sonic-net#273) [zhenggen-xu] ```

* Fix kube mode to local mode long duration issue * Remove IPV6 parameters which is not necessary * Fix read node labels bug * Tag the running image to latest if it's stable * Disable image_version_higher check * Change image_version_higher checker test case Signed-off-by: Yun Li <[email protected]>

* Fix code irregular issues Signed-off-by: Yun Li <[email protected]>

Signed-off-by: zitingguo-ms <[email protected]> Signed-off-by: zitingguo-ms <[email protected]>

Why I did it 1.57.x SDK based incremental drop that addresses a few egress ACL and drop counter failures. Hostname, vtysh, and incorrect queue watermark issue are addressed too. How I did it Update cisco-8000 submodule to v0.2.3 How to verify it Which release branch to backport (provide reason below if selected)

…ration of lazy packages (sonic-net#12164) Why I did it The current lazy installer relies on a filename sort for both unpack and configuration steps. When systemd services are configured [started] by multiple packages the order is by filename not by the declared package dependencies. This can cause the start order of services to differ between first-boot and subsequent boots. Declared systemd service dependencies further exacerbate the issue (e.g. blocking the first-boot script). The current installer leaves packages un-configured if the package dependency order does not match the filename order. This also fixes a trivial bug in [Build]: Support to use symbol links for lazy installation targets to reduce the image size sonic-net#10923 where externally downloaded dependencies are duplicated across lazy package device directories. How I did it Changed the staging and first-boot scripts to use apt-get: dpkg -i /host/image-$SONIC_VERSION/platform/$platform/*.deb becomes apt-get -y install /host/image-$SONIC_VERSION/platform/$platform/*.deb when dependencies are detected during image staging. How to verify it Apt-get critical rules Add a Depends= to the control information of a package. Grep the syslog for rc.local between images and observe the configuration order of packages change.

…nic-net#10224) #### Why I did it To fix sonic-net#9643 #### How I did it Instead of ast.literal_eval added python2 compat code for json strings unicode -> str convertion. We need python2 compatibility since py2 sonic config engine (buster/sonic_config_engine-1.0-py2-none-any.whl target) is still included into the build (ENABLE_PY2_MODULES flag is set for buster). Once we abandon buster and python2, this compat and ast.literal_eval could be cleaned up all through the code base. #### How to verify it run steps from the linked issue

Co-authored-by: Zhi Yuan (Carl) Zhao <[email protected]> Why I did it Arista 7060 platform has a rare and unreproduceable PCIe timeout that could possibly be solved with increasing the switch PCIe timeout value. To do this we'll call a script for this platform to increase the PCIe timeout on boot-up. No issues would be expected from the setpci command. From the PCIe spec: "Software is permitted to change the value in this field at any time. For Requests already pending when the Completion Timeout Value is changed, hardware is permitted to use either the new or the old value for the outstanding Requests, and is permitted to base the start time for each Request either on when this value was changed or on when each request was issued. " How I did it Add "platform-init" support in swss docker similar to how "hwsku-init" is called, only this would be for any device belonging to a platform. Then the script would reside in device data folder. Additionally, add pciutils dependency to docker-orchagent so it can run the setpci commands. How to verify it On bootup of an Arista 7060, can execute: lspci -vv -s 01:00.0 | grep -i "devctl2" In order to check that the timeout has changed.

- [202012] [ACL] Specify action list for `PFCWD` and `DROP` ACL table - Fixed a bug causing error state of same configuration is applied twice

sonic-net#12792) * Apply separated DSCP_TO_TC_MAP and TC_TO_QUEUE_MAP on dualtor

bugfix[2024] vnet route check exit code fix. Show tech save file to skip non-file entries in cisco-8000 platform [armhf][sonic-installer] [cherry-pick to branch 202012] Fix the issue of sonic-installer list after set-default and cleanup [show][muxcable] Catch port Value error exception [dualtor][202012] Send arp/ndp packets from vlan_mac if the device is dualtor [show] vnet advertised-route command [show][muxcable] add support for show mux firmware version all Signed-off-by: Kevin(Shengkai) Wang <[email protected]>

…c-net#12739) Signed-off-by: Neetha John <[email protected]> This is to backport sonic-net#12626 Why I did it There is a need to have separate profiles on compute and storage and this infra update will help achieve that How I did it Moved buffer pool/profile and qos definitions on TD2 to a common folder and all TD2 hwsku's will reference that folder

*[Bgpcfgd] static route expiry feature

Previously, we hard code the min and max numbers of instance in a plan. In this pr, we support passing the instance numbers of a testplan. Why I did it Previously, we hard code the min and max numbers of instance in a plan. In this pr, we support passing the instance numbers of a testplan. How I did it Use a variable to set the instance number.

# Why I did it Publish docker saiserverv2 in the build pipeline. # How I did it Add docker saiserverv2 target in the build template. # How to verify it Run test in sonic-net#12836 and the target has been built out successfully. Signed-off-by: zitingguo-ms <[email protected]>

…et#12835) In order to make the sai update easier, change the URL pattern to a more unified format, which can be update automated latter. Signed-off-by: richardyu-ms <[email protected]>

Advance sairedis head pointer, include changes - sonic-net/sonic-sairedis#1167 sonic-net/sonic-sairedis@4a887a1 Signed-off-by: richardyu-ms <[email protected]> Signed-off-by: richardyu-ms <[email protected]>

Previously, we set timeout in each step such as Lock testbed, Prepare testbed, Run test and KVM dump. When some issue suck like retry happens in one step, it will cause timeout error, but actually, it only needs more time to success. In this pr, we remove the timeout limit in each step and control the timeout outside in each job. When the job runs more than four hours, it will be cancelled. Why I did it Previously, we set timeout in each step such as Lock testbed, Prepare testbed, Run test and KVM dump. When some issue suck like retry happens in one step, it will cause timeout error, but actually, it only needs more time to success. In this pr, we remove the timeout limit in each step and control the timeout outside in each job. When the job runs more than four hours, it will be cancelled. How I did it Remove the timeout parameter in each step, and control the timeout outside in each job. Signed-off-by: Yutong Zhang <[email protected]>

sonic-net#12922) Why I did it enable sai-ptf logger in sai_adapter to log all the sai api invcations How I did it add build parameter to enable the sai-ptf logger when build sai PRC How to verify it local build test test the generated sai_adapter test with pipeline Signed-off-by: richardyu-ms <[email protected]>

… (sonic-net#12990) What I did: Updated Jinja Template to enable BGP Graceful Restart based on device role. By default it will be enable only if the device role type is TorRouter. Why I did:- By default FRR is configured in Graceful Helper mode. Graceful Restart is needed on T0/TorRouter only since the device can go for warm-reboot. For T1/LeafRouter it need to be in Helper mode only

…-net#12989) - Why I did it Update SDK/FW version - 4.5.3196/2010_3196 in order to have the following fixes: 1. ON SPC2/3 in some cases, after many ACL region resize will corrupt internal DB that in return will fail future ACLs configuration 2.. Lag Port as Analyzer Port | when removing port from distributer list SDK does not reselect another port for mirroring 3. Due to critical race at initial configuration, SDK RDQ test may test RDQ configured for WJH and fail the test Add support for new HW SKU of SN4700 - How I did it Update pointer for the SDK/FW - How to verify it Run regression tests

utilities: * f0fc333e 2022-12-15 | [db_migrator] Fix migration of Loopback data: handle all Loopback interfaces (sonic-net#2560) (HEAD -> 202012, github/202012) [Vaibhav Hemant Dixit] * ad7a4d42 2022-11-30 | Support for platforms based on Clounix Networks' device (sonic-net#2108) [songqh2022] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>

…ic-net#12325) (sonic-net#13132) Why I did it Makefile needs some dependencies from the Internet. It will fail for network related issue. Retries will fix most of these issues. How I did it Add retries when running commands which maybe related with networking. How to verify it

…et#13157) Why I did it [202012][Submodule][SAI-Redis]Advance SAI Redis head pointer How I did it include changes: sonic-net/sonic-sairedis@dcea4cd sonic-net/sonic-sairedis@5e9bcb1 sonic-net/sonic-sairedis@8f2a53f sonic-net/sonic-sairedis@c1d7938 [202012][Submodule][SAI]Advance SAI head pointer sonic-sairedis#1184 remove parameter skip-error, which removed from [202205][Submodule][SAI]Advance SAI head pointer sonic-sairedis#1185 How to verify it local build

Why I did it 1.50.x SDK based drop to fix MIGSMSFT-120 ([8102] Orchagent crash as addRoutePost failed at SAI") How I did it Update cisco-8000 submodule to v0.121

…v6 cfg is provided (sonic-net#13006) (sonic-net#13040) Backport PR sonic-net#13006 Signed-off-by: Vivek Reddy Karri <[email protected]>

…) (sonic-net#13226) Why I did it why In order to apply different config across different platform, and use the code with a unified format, reuse syncd init script to init saiserver. How I did it how Reuse syncd init script How to verify it Test Test in DUT s6000 and dx010 with sonic 202205

…ic-net#13233) Why I did it In some cases, dpkg will call dpkg to validate version. dpkg hook will get stuck in a loop to lock. How I did it How to verify it

…nic-net#13177) (sonic-net#13244) Why I did it Currently sonic-slave-* tag is confusing. Set correct tag on sonic-slave-* image. Fix job name to fit the build. How I did it build amd image in amd64: sonic-slave-bullseye:cfe29bff67c sonic-slave-bullseye:latest sonic-slave-bullseye:master build armhf image in amd64: sonic-slave-bullseye-march-armhf:33614806dc3 sonic-slave-bullseye-march-armhf:latest sonic-slave-bullseye-march-armhf:master build arm64 image in amd64: sonic-slave-bullseye-march-arm64:f3b1b16c801 sonic-slave-bullseye-march-arm64:latest sonic-slave-bullseye-march-arm64:master build arm64 image in arm64: sonic-slave-bullseye:75cb326c9a7 sonic-slave-bullseye-arm64:latest sonic-slave-bullseye:master build armhf image in armhf: sonic-slave-bullseye:64d178951fc sonic-slave-bullseye-armhf:latest sonic-slave-bullseye:master How to verify it

The display of azure pipeline is not specific now, such as when the step Run test fails, the display of itself shows successful, but the display of step Kvmdump shows fails, but actually, the step Kvmdump doesn't fail. I improve the display of azure pipeline in this pr, each step has its own success or failure, and is shown in azure pipeline. Why I did it The display of azure pipeline is not specific now, such as when the step Run test fails, the display of itself shows successful, but the display of step Kvmdump shows fails, but actually, the step Kvmdump doesn't fail. I improve the display of azure pipeline in this pr, each step has its own success or failure, and is shown in azure pipeline. How I did it Each step has its own signature of success or failure. Using the chain of responsibility pattern to manage all status. Modify the expected-state in each step.

Signed-off-by: Neetha John <[email protected]> Why I did it ECN parameters need to be updated for storage backend How I did it Included the check for storage backend devices to update qos configs How to verify it Verified that the new ecn settings are applied on storage backend device. Verified that the old ecn settings are applied for storage frontend, non storage frontend/backend devices

…nic-net#13329) Why I did it sonic_host_services depends on deepdiff. But latest deepdiff version has error. How I did it pin deepdiff to previous version. How to verify it

…iSMART (sonic-net#12784) Why I did it smartctl tool is available only in PMON docker. Hence, the tool may be not accessible incase PMON docker goes down. Using iSMART_64 tool to fetch the SSD firmware version and device model information. How I did it Replacing smartctl with iSMART_64.

…mage after sonic-installer clean (sonic-net#12609) Signed-off-by: mlok <[email protected]> Signed-off-by: mlok <[email protected]>

…y-pick. (sonic-net#13107) Why I did it To keep 'Request for xxx branch' label when finished auto-cherry-pick. How I did it Change logic in post cherry pick action. How to verify it

* [Arista]: Add hwSku Arista-7260CX3-D108C10 * Add buffer-related config for Arista-7260CX3-D108C10

…nic-net#13284) The main issue is the pip/pip3 command cannot be found when the package is being installed by apt-get. When using the dpkg install, the searching path is PATH=/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin When using the apt-get install, the searching path is PATH=/usr/sbin:/usr/bin:/sbin:/bin But the pip/pip3 default path is at /usr/local/bin, so dpkg works, but apt-get not work. How I did it Export the path /usr/local/bin for pip/pip3. Make the deb packages can be installed by apt-get.

This PR includes the following commits ``` b44e153 [202012]Revert "[config reload]: On dual ToR systems, cache ARP and FDB table (sonic-net/sonic-utilities#2490) 59f3025 Use github code scanning instead of LGTM (sonic-net/sonic-utilities#2530) 678df5d [202012] avoid printing error if no neighbors are present (sonic-net/sonic-utilities#2594) ```

…c-net#13359) Partial cherry-pick of: [Mellanox] Modified Platform API to support all firmware updates in single boot sonic-net#9608 - Why I did it To allow user manual reboot control over ONiE FW upgrade - How I did it Added a dedicated script argument handling - How to verify it mlnx-onie-fw-update.sh update --no-reboot Signed-off-by: Nazarii Hnydyn <[email protected]>

…onic-net#13378) #### Why I did it Backport sonic-net#13246 to 202012 branch. In case of warm/fast reboot, the hardware reboot cause will NOT be cleared because CPLD will not be touched in this flow. To not confuse the reboot cause determine logic, the leftover hardware reboot cause shall be skipped by the platform API, platform API will return the 'REBOOT_CAUSE_NON_HARDWARE' instead of the "hardware" reboot cause. #### How I did it Check the proc cmdline to see whether the last reboot is a warm or fast reboot, if yes skip checking the leftover hardware reboot cause. #### How to verify it a. Manual test: > 1. Perform a power loss > 2. Perform a warm/fast reboot > 3. check the reboot cause should be "warm-reboot" or "fast-reboot" instead of "power loss" b. Run reboot cause related regression test.

#### Why I did it Update for following swss commits: 96180bf - 2023-01-13 : [202012] Bfd default multiplier change (sonic-net#2615) [siqbal1986] 07506ac - 2023-01-11 : Add missing parameter to on_switch_shutdown_request method. (sonic-net#2567) [Hua Liu] 3253cc8 - 2022-11-30 : Use github code scanning instead of LGTM (sonic-net#2546) [Liu Shilong] f4df524 - 2023-01-11 : [orchagent]:add local_discriminator to state_db (sonic-net#2587) [Baorong Liu] f3cd02d - 2022-12-05 : [202012][muxorch] Adding case for maintaining current state (sonic-net#2500) [Nikola Dancejic]

Swss-common submodule update: c5ed58a - 2023-01-17 : 202012 cast of PR sonic-net/sonic-swss-common#725 (sonic-net#738) [siqbal1986] fe28725 - 2022-11-30 : Use github code scanning instead of LGTM (sonic-net#718) [Liu Shilong]

- Why I did it Backport sonic-net#9795 Python select.select accept a optional timeout value in seconds, however, the value passes to it is a value in millisecond. - How I did it Transfer the value to millisecond. - How to verify it Manual test

1.57.x SDK based incremental drop that addresses: 1) orchagent crash 2) Port LED issue 3) Tunnel endpoint stats 4) test_warm_reboot issue 5) nhop test failure 6) "show platform versions' CLI

Why I did it Fix the following issues for Seastone platform: - system-health issue: show system-health detail will not complete sonic-net#9530, Celestica Seastone DX010-C32: show system-health detail fails with 'Chassis' object has no attribute 'initizalize_system_led' sonic-net#11322 - show platform firmware updates issue: Celestica Seastone DX010-C32: show platform firmware updates sonic-net#11317 - other platform optimization How I did it Modify and optimize the platform implememtation. How to verify it Manual run the test commands described in these issues.

…t#13438) Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>

CS00012254651 (SONIC-66820) Fix missing break stmt Verify run case test_forward_ip_packet_with_0xffff_chksum_tolerant Signed-off-by: richardyu-ms <[email protected]>

…onic-net#12912) (sonic-net#13423) …(sonic-net#12912) Why I did it As described in detail in sonic-net#12753, the current FRR patch 0009-ignore-route-from-default-table.patch is causing unwanted FRR/zebra error logs. This change gets rid of the error messages for routes from kernel default table while these routes are ignored in prefix encoding. How I did it This fix updates the original 0009 patch by checking if the routes are from table default before printing the error logs. The original patch checks the same condition and ignores the routes from table default in prefix encoding. How to verify it Follow the steps to repro as described in sonic-net#12753. Also verify the test case ipfwd/test_nhop_count.py no longer fails due to the error messages. #### Why I did it Resolve cherry-pick conflict for sonic-net#12912

swss: * f28d6622 2023-01-25 | [portinit] Do not call GET on SAI_PORT_ATTR_SPEED when AUTONEG is enabled (sonic-net#2484) (sonic-net#2639) (github/202012, 202012) [Ying Xie] * 217f7f00 2023-01-21 | Cherry pick of sonic-net/sonic-swss#2589 (sonic-net#2627) [siqbal1986] Signed-off-by: Ying Xie <[email protected]> Signed-off-by: Ying Xie <[email protected]>

#### Why I did it Update submodule for sonic-swss: e739e6c - 2023-01-27 : custom advertised prefix for primary vxlan tunnel [202012] (sonic-net#2641) [siqbal1986] sonic-restapi: 99c467d - 2023-01-24 : Add API support for adv prefix and custom monitoring (sonic-net#133) [Prince Sunny] 347684a - 2022-11-30 : Use github code scanning instead of LGTM (sonic-net#132) [Liu Shilong]

…) (sonic-net#13441) Why I did it Fix issue caused by dualtor support PR [dhcpmon] Open different socket for dual tor to enable interface filtering sonic-net#11201 Improve code How I did it On single ToR, packets received count was duplicated due to socket filter set to "inbound" Tx count not increasing due to filter set to "inbound". Added an outbound socket to count tx packets Added vlan member interface mapping for Ethernet interface to vlan interface lookup in reference to PR Fix multiple vlan issue sonic-dhcp-relay#27 Exit when socket fails to initialize to allow dhcp_relay docker to restart How to verify it Tested on vstestbed single tor and dual tor, sent packets and verify printed out dhcpmon rx and tx counters is correct Correct number of tx increases Tx does not increase when ToR is on standby

- Why I did it Added BIOS upgrade infra - How I did it Added new make target - How to verify it Copy msn3800_bios.tar.gz to platform/mellanox/bios make configure PLATFORM=mellanox make target/files/buster/msn3800_bios.tar.gz Signed-off-by: Nazarii Hnydyn <[email protected]>

…sonic-net#12721) Why I did it When getting system mac of centec platform, it would increase by 1 the last byte of mac, but it could not consider the case of carry. How I did it Firstly, I would replace the ":" with "" of mac to a string. And then, I would convert the mac from string to int and increase by 1, at last convert it to string with inserting ":".

This is to reduce writes to disk, which then can use the SSD to get worn out faster. Signed-off-by: Saikrishna Arcot <[email protected]>

Why I did it Advance sonic-dhcp-relay submodule head on 202012 branch How I did it Added the following commits: a4b15d8 jcaiMR Thu Dec 29 14:18:28 2022 +0800 fix relay-reply dhcpv6 packet counter issue (#29) 677543f jcaiMR Sat Dec 17 00:24:32 2022 +0800 fix handleSwssNotification crash in dhcp6relay (#28) ed86546 jcaiMR Wed Dec 14 14:08:58 2022 +0800 Fix multiple vlan issue (#27) 5ec1f5b Vivek Thu Dec 8 09:44:15 2022 -0800 Made the Error log informative (#22) 063d41b jcaiMR Wed Nov 30 14:41:53 2022 +0800 disable cfg dynamic change (#25) d4a51f6 kellyyeh Tue Jan 31 18:09:08 2023 -0800 Add unittest infrastructure (#5) (#31) How to verify it Ran full dhcpv6 test suite on lab device

…3607) This is to reduce writes to disk, which then can use the SSD to get worn out faster. Signed-off-by: Saikrishna Arcot <[email protected]> (cherry picked from commit ee1c32a)

9551386 Jing Zhang Mon Jan 23 15:49:52 2023 -0800 [202012] Update link prober stats post logic sonic-net#159 (sonic-net#162) e54f289 Liu Shilong Wed Nov 30 18:04:15 2022 +0800 Use github code scanning instead of LGTM (sonic-net#157)

…et#13701) Cherry-pick PR sonic-net#12996 into 202012 branch. Signed-off-by: Longxiang Lyu <[email protected]>

sonic-net#13426) Why I did it fix DX010 fan drawer and watchdog platform test case issues How I did it 1. Add fan_drawer get_maximum_consumed_power support 2. Adjust maximum watchdog timeout value check How to verify it Run test_fan_drawer and test_watchdog test cases.

#### Why I did it Some tests under platform_tests/api were failing on the 7050CX3 due to outdated facts in platform.json #### How I did it Updated platform.json facts with appropriate values #### How to verify it Run tests under platform_tests/api to verify no failures

…10083) (sonic-net#13672) #### Why I did it Cherry pick from sonic-net#10083 It is to fix the issue sonic-net#10048 When building .raw image, for instance, target/sonic-broadcom.raw, it will generate a .bin image, target/sonic-broadcom.bin, as the intermediate file. The intermediate file is a build target which may contains different dependencies with the raw one. #### How I did it Rename the intermediate file.

…sonic-net#10211) (sonic-net#13673) #### Why I did it Fix some version info missing in version control files issue #### How I did it Change to collect version before it cleaned up

``` 39cdb49c7 [202012][show] Add bgpraw to show run all (sonic-net#2639) b3ebba2ca [202012][show] add new CLI to show tunnel route objects sonic-net#2255 (sonic-net#2659) d08f59b9f Fixed a bug in "show vnet routes all" causing screen overrun. (sonic-net#2644) (sonic-net#2654) a996abdb5 [202012][show] show logging CLI support for logs stored in tmpfs (sonic-net#2652) c60f771c0 [202012][show_bfd] add local discriminator in show bfd command (sonic-net#2616) ```

Include following commits: - c98b9f09 [202012][orchagent]: Get bridge port ID from FDBOrch cache instead of SAI API sonic-net#2657 (sonic-net#2658) - 59886b8f [MuxOrch] Enabling neighbor when adding in active state (sonic-net#2601)

* set origin and as-path prepend for routes from SLB

#### Why I did it 1.57.x SDK based incremental drop that addresses: Fix for MIGSMSFT-158 Support for VxLAN and BFD Serviceability CLI sfputil reset platform fix to handle 100G optics Added thermal management feature for ZR optics sensors #### How I did it Update cisco-8000 submodule to v0.2.5

#### Why I did it Include below commits: ``` 7147354 2023-02-14 | Fix: zero route may have empty nexthop (sonic-net#276) [Qi Luo] e60a64c 2022-11-30 | Use github code scanning instead of LGTM (sonic-net#274) [Liu Shilong] ```

Why I did it 1. fix chassis test_set_fans_led case 2. fix chassis get_name case mismatch issue 3. fix fan_drawer test_set_fans_speed 4. fix component test_components test case How I did it Add corresponding configuration into chassis json file How to verify it Run platform tests cases to verify these failure cases

Why I did it Some products might experience an occasional IO failure in the communication between CPU and SSD. Based on some research it could be attributable to some device not handling ATA NCQ (Native Command Queue). This issue currently affect 4 products: DCS-7170-32C* DCS-7170-64C DCS-7060DX4-32 DCS-7260CX3-64 How I did it This change disable NCQ on the affected drive for a small set of products. How to verify it When the fix is applied, these 2 patterns can be found in the dmesg. ata1.00: FORCE: horkage modified (noncq) NCQ (not used) Test results using: fio --direct=1 --rw=randrw --bs=64k --ioengine=libaio --iodepth=64 --runtime=120 --numjobs=4 with NCQ (ata1.00: 61865984 sectors, multi 1: LBA48 NCQ (depth 32), AA) READ: bw=33.9MiB/s (35.6MB/s), 33.9MiB/s-33.9MiB/s (35.6MB/s-35.6MB/s), io=4073MiB (4270MB), run=120078-120078msec WRITE: bw=34.1MiB/s (35.8MB/s), 34.1MiB/s-34.1MiB/s (35.8MB/s-35.8MB/s), io=4100MiB (4300MB), run=120078-120078msec without NCQ (ata1.00: 61865984 sectors, multi 1: LBA48 NCQ (not used)) READ: bw=31.7MiB/s (33.3MB/s), 31.7MiB/s-31.7MiB/s (33.3MB/s-33.3MB/s), io=3808MiB (3993MB), run=120083-120083msec WRITE: bw=31.9MiB/s (33.4MB/s), 31.9MiB/s-31.9MiB/s (33.4MB/s-33.4MB/s), io=3830MiB (4016MB), run=120083-120083msec Which release branch to backport (provide reason below if selected)

…c-net#13813) #### Why I did it Submodule update for sonic-swss-common with following change: ``` 3e34309 2023-02-11 | RedisPipeline ignore flush when call dtor from another thread. (sonic-net#736) [Hua Liu] ```

Include following commit: - 0d95f076 [202012]: Reduce log level when FDB cache lookup fails (sonic-net#2667)

…able with different sfp type (sonic-net#13543) - Why I did it There are 3 tasks in xcvrd: main task, run a loop to recover missing SFP static information to DB every 1 minute SFP state task, a process which listens cable plug in/out event, insert SFP static information to DB while a cable is inserted SFP DOM update task, a thread which handles cable DOM information update every 1 minute Let assume user replaces QSFP with QSFP-DD. There are two issues: Only SFP state task listens cable plug in/out event, main task and SFP DOM update task does not know SFP type has changed, they still “think” the SFP type is QSFP. So, main task and SFP DOM update task uses QSFP standard to parse QSFP-DD EEPROM which causes corrupted data. There is a race condition between main task and SFP state task. They both insert SFP static information to DB. Depends on timing, it is possible that main task using wrong SFP type to override SFP static information. The PR is to fix these two issues. There is no such issue on 202205 and above because there is a refactor for xcvrd: SFP state task was changed from process to thread, so that all 3 tasks share the same memory space, they always have correct SFP type. Recover missing SFP information logical was moved from main task to SFP state task. There is no race condition anymore. - How I did it It is difficult to back port latest xcvrd because there are many refactor/new features in xcvrd after 202012 release. It will be huge effort to do so. Based on that, we decided to fix the issue on Nvidia platform API side. The fix is that: refreshing SFP type before any SFP API which accessing SFP EEPROM. Refreshing SFP type before any SFP API would cause a small performance down: Due to my test on 202012 branch, accessing transceiver INFO and DOM INFO for 32 ports takes 1.7 seconds before the change. The number changes to 2.4 seconds after the change. I suppose the performance down is acceptable. - How to verify it Manual test Regression

…onic-net#13726) (sonic-net#13731) Why I did it Docker build has a low rate of hanging up. It hangs on different steps. So, it looks like a bug in docker daemon. How I did it Start a daemon process to scan running time more than 1 hours, and kill the process. How to verify it

…c-net#13894) Why I did it Azure pipeline change. Use common template to make it easy to change common steps. Fix docker hang issue. How I did it

… of squashfs (sonic-net#13890) Upgrade from old image always requires squashfs mount to get the next image FW binary. This can be avoided if we put FW binary under platform directory which is easily accessible after installation: admin@r-spider-05:~$ ls /host/image-fw-new-loc.0-dirty-20230208.193534/platform/fw-SPC.mfa /host/image-fw-new-loc.0-dirty-20230208.193534/platform/fw-SPC.mfa admin@r-spider-05:~$ ls -al /tmp/image-fw-new-loc.0-dirty-20230208.193534-fs/etc/mlnx/fw-SPC.mfa lrwxrwxrwx 1 root root 66 Feb 8 17:57 /tmp/image-fw-new-loc.0-dirty-20230208.193534-fs/etc/mlnx/fw-SPC.mfa -> /host/image-fw-new-loc.0-dirty-20230208.193534/platform/fw-SPC.mfa - Why I did it 202211 and above uses different squashfs compression type that 201911 kernel can not handle. Therefore, we avoid mounting squashfs altogether with this change. - How I did it Place FW binary under /host/image-/platform/mlnx/, soft links in /etc/mlnx are created to avoid breaking existing scripts/automation. /etc/mlnx/fw-SPCX.mfa is a soft link always pointing to the FW that should be used in current image mlnx-fw-upgrade.sh is updated to prefer /host/image-/platform/mlnx location and fallback to /etc/mlnx in squashfs in case new location does not exist. This is necessary to do image downgrade. - How to verify it Upgrade from 201911 to 202012 202012 to 201911 downgrade 202012 -> 202012 reboot ONIE -> 202012 boot (First FW burn) Signed-off-by: Stepan Blyschak <[email protected]>

…logical port number larger than 64 (sonic-net#13709) - Why I did it sfp_event.py gets a PMPE message when a cable event is available. In PMPE message, there is no label port available. Current sfp_event.py is using sx_api_port_device_get to get 64 logical ports attributes, and find the label port from those 64 attributes. However, if there are more than 64 ports, sfp_event.py might not be able to find the label port and drop the PMPE message. - How I did it Don't use hardcoded 64, get logical port number instead. - How to verify it Manual test

…onic-net#13976) Why I did it Support to upgrade packages, do better cleanup after the build. How I did it Remove the no use preference version control file after the build. How to verify it

Why I did it Fix the docker-base-stretch build issue in nephos platform. Collecting supervisord-dependent-startup==1.4.0 Downloading https://files.pythonhosted.org/packages/0e/66/d386c3d2cf36846ded0b9f4999a6c59fd04fb15d768e59d3acfa039102bc/supervisord_dependent_startup-1.4.0-py2.py3-none-any.whl Collecting toposort>=1.5 (from supervisord-dependent-startup==1.4.0) Downloading https://files.pythonhosted.org/packages/8d/c3/44e51b42160145e4ebeb7d86ab93bd933fa9498f94e183ef8a47c6de8b2f/toposort-1.9.tar.gz Complete output from command python setup.py egg_info: Traceback (most recent call last): File "<string>", line 1, in <module> IOError: [Errno 2] No such file or directory: '/tmp/pip-build-LnROQE/toposort/setup.py' ---------------------------------------- Command "python setup.py egg_info" failed with error code 1 in /tmp/pip-build-LnROQE/toposort/ The other platforms have been upgraded to docker-base-buster, not impacted. How I did it Pin the toposort version to 1.7, the package supervisord-dependent-startup has dependency on it. The toposort>=1.8 only for python3, is not applicable to python2.

- Why I did it Update MFT version to 4.21.0-100 to include a fix for an issue reported using mlxlink on qsfp-dd - How I did it Update mft.mk - How to verify it Run regression on Mellanox platforms

Why I did it Seastone does not have the psu fans' status led, need to reflect it in platform.json. How I did it Set the psu fans status led available to false. How to verify it Verify it with platform_tests/api/test_psu_fans.py::TestPsuFans::test_set_fans_led case.

This is to reduce writes to the SSD on the device. Signed-off-by: Saikrishna Arcot <[email protected]>

#### Why I did it Update cisco platform module to 202012-v0.2.6 #### How I did it Update cisco-8000.ini

#### Why I did it Remove dialout as critical process as it is no longer used in prod. As part of future work, can remove dialout completely #### How I did it Remove from critical process list

Why I did it Platform cases test_tx_disable, test_tx_disable_channel, test_power_override failed in dx010. How I did it Add i2c access algorithm for CPLD i2c adapters. How to verify it Verify it with platform_tests/api/test_sfp.py::TestSfpApi test cases.

…ackages (sonic-net#14013) Why I did it [Build] Support to use loosen version when failed to install python packages It is to fix the issue sonic-net#14012 How I did it Try to use the installation command without constraint How to verify it

…onic-net#14066) Why I did it Fix CVE-2022-2309, upgrade lxml from 4.6.3 to 4.9.1

#### Why I did it Update sonic-snmpagent submodule to include below commit: fba50c6 [202012]: snmp vlan support per RFC1213 and added the missing support for RFC2863 (sonic-net#279)

…onic-net#14137) This PR is to backport sonic-net#14138 to 202012. - Why I did it In sfplpm API, the number of logical ports is hardcoded as 64. When a system contains more port than this, the SDK APIs would fail with a trace as below Enabling low-power mode for port Ethernet0... Traceback (most recent call last): File "/usr/share/sonic/platform/plugins/sfplpmset.py", line 167, in set_lpmode(handle, cmd, sfp_module) File "/usr/share/sonic/platform/plugins/sfplpmset.py", line 128, in set_lpmode SX_MGMT_PHY_MOD_PWR_ATTR_PWR_MODE_E, SX_MGMT_PHY_MOD_PWR_MODE_LOW_E) File "/usr/share/sonic/platform/plugins/sfplpmset.py", line 115, in pwr_attr_set mgmt_phy_mod_pwr_attr_set(handle, module_id, attr_type, power_mode) File "/usr/share/sonic/platform/plugins/sfplpmset.py", line 84, in mgmt_phy_mod_pwr_attr_set assert SX_STATUS_SUCCESS == rc, "sx_mgmt_phy_mod_pwr_attr_set failed" AssertionError: sx_mgmt_phy_mod_pwr_attr_set failed Error! Unable to set LPM for 1, rc = 1, err msg: [+] opening sdk Mar 07 03:25:28 INFO LOG: Initializing SX log with STDOUT as output file. Mar 07 03:25:28 ERROR SX_API_PORT: sx_mgmt_phy_mod_pwr_attr_get: This API is deprecated and will be removed in the future. Please use sx_mgmt_phy_module_pwr_attr_get in its place. Mar 07 03:25:28 ERROR SX_API_PORT: sx_mgmt_phy_mod_pwr_attr_set: This API is deprecated and will be removed in the future. Please use sx_mgmt_phy_module_pwr_attr_set in its place. - How I did it Remove the hardcoded value of 64. Obtained the number of logical ports from SDK - How to verify it Manual testing

* Include the following commits: - a21b160 [202012][orchagent]: Handle duplicate routes in a graceful manner (sonic-net#2666) - 1540161 [bfdorch] add default TOS value for BFD packet (sonic-net#2692) - 860430c [ci] run apt-get update before apt-get install (sonic-net#2686)

…t-default form 202012 to 202205 branch. (sonic-net#13911) #### Why I did it When using ```sonic-install set-default``` to switch the image from 202012 to 202205. The system will be stuck at loading kernel while reboot. #### How I did it The issue is caused by the kernal size related setting in uboot environment is smaller in the 202012 branch while they are larger in 202205 branch. The "sonic-installer set-default" just changes the boot_next variable. To fix this issue, we sync up the 202012 branch kernel related setting with the 202205 branch. This PR is only applicable to 202012 branch. #### How to verify it 1) Install the latest 202205 image .89 or latest and reboot 2) Install the 202012 image which contains this fix and reboot 3) using "sonic-installer set-default 202205 image and reboot 4) system should start without any issue. #### Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

… (sonic-net#14056) #### Why I did it This is part of a corresponding change to the pcie daemon that enables it to verify PCI peripherals on a platform against a preconfigured YAML file, and enables the pcied daemon to call the system commands needed for PCI peripheral verification #### How I did it Adding aforementioned libraries to the Dockerfile.j2 file #### How to verify it run 'which setpci' from the pmon docker - would show the path of the binary #### Description for the changelog Modified pmon's Dockerfile.j2 to include pciutils and libpci libraries. **cherry-pick of SHA: 7de0450**

#### Why I did it Some products might experience an occasional IO failure in the communication between CPU and SSD. Based on some research it could be attributable to some device not handling ATA NCQ (Native Command Queue). This issue currently affect 4 products: - `DCS-7170-32C*` - `DCS-7170-64C` - `DCS-7060DX4-32` - `DCS-7260CX3-64` #### How I did it This change disable NCQ on the affected drive for a small set of products. #### How to verify it When the fix is applied, these 2 patterns can be found in the dmesg. `ata1.00: FORCE: horkage modified (noncq)` `NCQ (not used)` Test results using: `fio --direct=1 --rw=randrw --bs=64k --ioengine=libaio --iodepth=64 --runtime=120 --numjobs=4` with NCQ (`ata1.00: 61865984 sectors, multi 1: LBA48 NCQ (depth 32), AA`) ``` READ: bw=33.9MiB/s (35.6MB/s), 33.9MiB/s-33.9MiB/s (35.6MB/s-35.6MB/s), io=4073MiB (4270MB), run=120078-120078msec WRITE: bw=34.1MiB/s (35.8MB/s), 34.1MiB/s-34.1MiB/s (35.8MB/s-35.8MB/s), io=4100MiB (4300MB), run=120078-120078msec ``` without NCQ (`ata1.00: 61865984 sectors, multi 1: LBA48 NCQ (not used)`) ``` READ: bw=31.7MiB/s (33.3MB/s), 31.7MiB/s-31.7MiB/s (33.3MB/s-33.3MB/s), io=3808MiB (3993MB), run=120083-120083msec WRITE: bw=31.9MiB/s (33.4MB/s), 31.9MiB/s-31.9MiB/s (33.4MB/s-33.4MB/s), io=3830MiB (4016MB), run=120083-120083msec ``` #### Description for the changelog Disable ATA NCQ for a few Arista products

Why I did it [ci/build]: Upgrade SONiC package versions How I did it How to verify it

…et#14138) (sonic-net#14202) Manual cherry-pick of sonic-net#14138 - Why I did it In sfplpm API, the number of logical ports is hardcoded as 64. When a system contains more port than this, the SDK APIs would fail with a syslog as below Mar 7 03:53:58.105980 r-leopard-58 ERR syncd#SDK: [MGMT_LIB.ERR] Slot [0] Module [0] has logport [0x00010069] in enabled state Mar 7 03:53:58.105980 r-leopard-58 ERR syncd#SDK: [SDK_MGMT_LIB.ERR] Failed in __sdk_mgmt_phy_module_pwr_attr_set, error: Internal Error Mar 7 03:53:58.106118 r-leopard-58 ERR pmon#-c: Error occurred when setting power mode for SFP module 0, slot 0, error code 1 - How I did it Remove the hardcoded value of 64. Obtained the number of logical ports from SDK - How to verify it Manual testing

Update sonic-restapi for the following commit: 44121be - 2023-03-14: Support ipv6 prefix length greater than 64 and check for adv_prefix 47e4b53 - 2023-03-15: Set allowed IPv6 pfx len to be 60

…onic-net#14220) - Why I did it To optimize Mellanox platform build - How I did it sdk debs are now downloaded as Spectrum-SDK-Drivers-SONiC-Bins release sx kernel is downloaded as zip from Spectrum-SDK-Drivers

Has following commits: ``` b93c4ac Zain Budhwani Wed Mar 1 15:45:43 2023 -0800 Fix crash when retrieving cpu utilization (sonic-net/sonic-gnmi#70) (sonic-net/sonic-gnmi#71) af1ec19 Zain Budhwani Wed Mar 1 15:13:53 2023 -0800 Add diff cov (sonic-net/sonic-gnmi#85) 3f41377 Zain Budhwani Tue Feb 28 16:48:22 2023 -0800 Add logs for md5 checksum (sonic-net/sonic-gnmi#80) 67b7fb2 Zain Budhwani Mon Feb 27 23:44:49 2023 -0800 Add get-update to azp yml (sonic-net/sonic-gnmi#79) 5d6c47f Zain Budhwani Fri Feb 24 13:11:53 2023 -0800 Add net core and code coverage results (sonic-net/sonic-gnmi#77) 984bc6d Zain Budhwani Wed Feb 22 16:03:01 2023 -0800 [202012] Enable unit test (sonic-net/sonic-gnmi#76) e8e4335 Zain Budhwani Fri Feb 10 16:27:58 2023 -0800 Change dir name in pipeline (sonic-net/sonic-gnmi#75) a1cc7ab Zain Budhwani Tue Jan 31 14:11:27 2023 -0800 Add 202012 branch to pr checker (sonic-net/sonic-gnmi#72) eaea6c5 ganglyu Mon Nov 14 10:18:07 2022 +0800 Fix format ```

…net#13898) Why I did it Dhcpmon had incorrect RX count for server side packets. It does not raise any false alarms, but could miss catching server side packet count mismatch between snapshot and current counter. Add debug mode which prints counter to syslog How I did it Due to dualtor inbound filter requirement, there are currently two filters, each for listening to rx / tx packets. Originally, we opened up an rx/tx socket for each interface specified, which causes duplicate socket. Now we initialize the sockets only once. Both sockets are not binded to an interface, and we use vlan to interface mapping to filter packets. For inbound uplinks, we use a portchannel to interface mapping. Previous dhcpmon counter before dual tor change: [ Agg-Vlan1000- Current rx/tx] Discover: 1/ 4, Offer: 1/ 1, Request: 3/ 12, ACK: 1/ 1 [ eth0- Current rx/tx] Discover: 0/ 0, Offer: 0/ 0, Request: 0/ 0, ACK: 0/ 0 [ eth0- Current rx/tx] Discover: 0/ 0, Offer: 0/ 0, Request: 0/ 0, ACK: 0/ 0 [ PortChannel104- Current rx/tx] Discover: 0/ 1, Offer: 0/ 0, Request: 0/ 3, ACK: 0/ 0 [ PortChannel103- Current rx/tx] Discover: 0/ 1, Offer: 0/ 0, Request: 0/ 3, ACK: 0/ 0 [ PortChannel102- Current rx/tx] Discover: 0/ 2, Offer: 1/ 0, Request: 0/ 6, ACK: 1/ 0 [ PortChannel101- Current rx/tx] Discover: 0/ 0, Offer: 0/ 0, Request: 0/ 0, ACK: 0/ 0 [ Vlan1000- Current rx/tx] Discover: 1/ 0, Offer: 0/ 1, Request: 3/ 0, ACK: 0/ 1 [ Agg-Vlan1000- Current rx/tx] Discover: 1/ 4, Offer: 1/ 1, Request: 3/ 12, ACK: 1/ 1 Dhcpmon counter after this PR: [ PortChannel104- Current rx/tx] Discover: 0/ 1, Offer: 0/ 0, Request: 0/ 3, ACK: 0/ 0 [ PortChannel103- Current rx/tx] Discover: 0/ 1, Offer: 0/ 0, Request: 0/ 3, ACK: 0/ 0 [ PortChannel102- Current rx/tx] Discover: 0/ 2, Offer: 1/ 0, Request: 0/ 6, ACK: 1/ 0 [ PortChannel101- Current rx/tx] Discover: 0/ 0, Offer: 0/ 0, Request: 0/ 0, ACK: 0/ 0 [ Vlan1000- Current rx/tx] Discover: 1/ 0, Offer: 0/ 1, Request: 3/ 0, ACK: 0/ 1 [ Agg-Vlan1000- Current rx/tx] Discover: 1/ 4, Offer: 1/ 1, Request: 3/ 12, ACK: 1/ 1 How to verify it Ran dhcp relay test to send all four packets in singles and batches on both single ToR and dual ToR. Counter was as expected.

Why I did it Update dynamic threshold to -1 to get optimal performance for RDMA traffic How I did it Modified pg_profile_lookup.ini to reflect the correct value Signed-off-by: Neetha John <[email protected]>

Why I did it This PR addresses the issue mentioned above by loading the acl config as a service on a storage backend device How I did it The new acl service is a oneshot service which will start after swss and does some retries to ensure that the SWITCH_CAPABILITY info is present before attempting to load the acl rules. The service is also bound to sonic targets which ensures that it gets restarted during minigraph reload and config reload How to verify it Build an image with the following changes and did the following tests Verified that acl is loaded successfully on a storage backend device after a switch boot up Verified that acl is loaded successfully on a storage backend ToR after minigraph load and config reload Verified that acl is not loaded if the device is not a storage backend ToR or the device does not have a DATAACL table Signed-off-by: Neetha John <[email protected]>

…onic-net#14048) For sonic-platform-daemons following commits are added to the submodule dd8fbae (HEAD -> 202012, origin/202012) [ycabled] add more coverage to ycabled; add minor name change for vendor API CLI return key-values pairs (sonic-net#338) 846555e [thermalctld] fix some redundant removal of state DB tables (sonic-net#315) 3d92fb9 Use github code scanning instead of LGTM (sonic-net#316) For sonic-utilities the following commits are added in this PR to the submodule git log --oneline 39cdb49c..202012 ec4c6ea5 (HEAD -> 202012, origin/202012) [show][muxcable] add some new commands health, reset-cause, queue_info support for muxcable (sonic-net#2414) (sonic-net#2704) 03ef272e [202012][vlan] Remove add field of vlanid to DHCP_RELAY table while adding vlan (sonic-net#2681) e00a81ac [202012][dhcp-relay] Add support for dhcp_relay config cli (sonic-net#2640) 274184e1 [vlan] Refresh dhcpv6_relay config while adding/deleting a vlan (sonic-net#2660) (sonic-net#2668 #### Why I did it updating the submodule of sonic-platform-daemons, sonic-utilities #### How I did it updated the submodule

…14357) This PR includes the following commits ``` 5b0f0fc [202012][dhcp_relay] Fix dhcp_relay restart error while add/del vlan (sonic-net/sonic-utilities#2688) 48fd842 [show][muxcable] increase timeout for displaying HW_STATUS (sonic-net/sonic-utilities#2712) f0a9f4f [dhcp_relay] Add show/clear/counter cli for dhcp_relay (sonic-net/sonic-utilities#2719) 8627944 Revert "[202012] Update load minigraph to load backend acl" (sonic-net/sonic-utilities#2736) 93c7d43 [warm-reboot] Use kexec_file_load instead of kexec_load when available (sonic-net/sonic-utilities#2608) cc78747 [warm/fast-reboot] Backup logs from tmpfs to disk during fast/warm shutdown (sonic-net/sonic-utilities#2714) ```

…c-net#14376) During the build process, a dsc file is retrieved from the URL: http://deb.debian.org/debian/pool/main/i/isc-dhcp/isc-dhcp_4.4.1-2.3.dsc Depending on the DNS resolution, the server reached may respond with a HTTP 404 error code, what stops the build process. In all cases, the URL http://deb.debian.org/debian/pool/main/i/isc-dhcp/ no more lists this DSC file but one with a different format. The suffix "+deb11u1" is now appended to identify the debian version. - append this suffix to the make file rules of isc-dhcp Signed-off-by: Guillaume Lambert <[email protected]> Co-authored-by: Guilt <[email protected]>

…old for Th devices (sonic-net#14398) Backport sonic-net#14372 to 202012 Why I did it For better accounting purposes, updating the ingress lossy traffic profile to use static threshold. This change is only intended for Th devices using RDMA-CENTRIC profiles How I did it Update the buffer templates for Th devices in RDMA-CENTRIC folder to use the correct threshold Signed-off-by: Neetha John <[email protected]>

…nic-net#14385) **What I did** Check /etc/pam.d/sshd integrity after modify it in hostcfgd. **Why I did it** Found some incident that /etc/pam.d/sshd become empty file during OR upgrade. **How I verified it** Pass all UT. Add new UT to cover new code. **Details if related** This is a manually cherry-pick PR for sonic-net/sonic-host-services#36

Why I did it Change to use the default ssl lib openssl not nss Backport sonic-net#14351. How I did it

Why I did it sonic-slave-stretch build failed for mmh3 version update to 3.10 on Mar 24. How I did it Enable reproducible build for vhdx image. How to verify it

Update for swss following commits: 3108985 - 2023-03-28 : [202012][muxorch] handling multiple mux nexthops for route (sonic-net#2702) [Nikola Dancejic] f412625 - 2023-03-24 : [202012]Custom monitoring based priority tunnels (sonic-net#2671) [siqbal1986]

#### Why I did it Update sonic-snmpagent submodule to include below commit: Revert "[202012]: snmp vlan support per RFC1213 and added the missing support for RFC2863 (sonic-net#279)" (sonic-net#280)

#### Why I did it Bug in script that was passing in null as log level value if missing from config_db #### How I did it Added more robust conditional statement #### How to verify it 1) Remove log_level from config db 2) config reload -y 3) telemetry should not crash

Improve sudo cat command for RO user. #### Why I did it RO user can use sudo command show none syslog files. #### How I did it Improve sudo cat command for RO user. #### How to verify it Pass all UT. Manually check fixed code work correctly. #### Description for the changelog Improve sudo cat command for RO user.

…ic-net#14432) #### Why I did it This is a cherrypick of sonic-net#14062 on 202012 branch

Why I did it mmh3's new version 3.1.0 breaks pipeline build. bullseye/buster/jessie pined the version to 2.5.1 How I did it Pin mmh3's version as other dists. How to verify it

* [Bgpcfgd] change static route expiry time from 1800 to 172800

#### Why I did it Fix for link down issue seen with AOI 100G-PSM4 optics on 8102-64H-O [JIRA ID# MIGSMSFT-23] #### How I did it update platform module to 0.2.7

Include commit: ``` 6ea1f03 Jing Zhang Tue Mar 28 08:42:44 2023 -0700 [202012] remove chatty log message for peer link event (sonic-net#192) 198292d Jing Zhang Tue Mar 21 17:53:11 2023 -0700 [active-standby] avoid unnecessary mux state probe after configuring to `auto` (sonic-net#183) 47de88e Jing Zhang Mon Mar 20 18:14:25 2023 -0700 [202012] Avoid unnecessary error logs from `handleGetServerMacAddressNotification` sonic-net#96 (sonic-net#185) 8a33319 Jing Zhang Mon Mar 6 11:53:27 2023 -0800 loose link down swithcover condition (sonic-net#178) c2bf08d Jing Zhang Thu Mar 16 18:59:10 2023 -0700 fix ActiveStandbyStateMachine referrence (sonic-net#186) 99d26af Jing Zhang Thu Mar 16 18:58:48 2023 -0700 [ci] Fix apt-get install unable locate package issue. (sonic-net#177) (sonic-net#187) d893be9 Longxiang Lyu Wed Feb 22 12:55:44 2023 +0800 [active-standby] Toggle to standby if link down and config auto (sonic-net#173) ```

Update swss commits: c161027 - 2023-04-07 : [202012] overlay_dmac change in Vnet configuration. (sonic-net#2724) [siqbal1986] 50be4e3 - 2023-04-05 : [202012][mux]: Implement rollback for failed mux switchovers (sonic-net#2716) [Lawrence Lee] 637e4c7 - 2023-03-30 : [202012] Fix orchagent missing request when logrotate happens (sonic-net#2718) [Prince Sunny]

…for EdgeZoneAggregator (sonic-net#14539) #### Why I did it SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1. Original PR for master: sonic-net#14280 #### How I did it Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router. #### How to verify it Unit tests pass, and manually checked on a 7260 to see the changes take effect. #### Description for the changelog [Buffer] Added cable length config to buffer config template for EdgeZoneAggregator

Why I did it [Submodule][202012] Advance sonic-restapi pointer 4f6f979 [Security] Fix the redis security issue CVE-2023-28858 and CVE-2023-28859 (sonic-net#139) Work item tracking Microsoft ADO (number only): 17894593 How I did it How to verify it

…net#13566) (sonic-net#14662) Why I did it If make fails, we can't rerun the make process, because existing patches can't apply again. sonic-net#13386 missed some change. Work item tracking Microsoft ADO (number only): How I did it Check if patches are applied. if yes, don't apply patches again. How to verify it

[sonic-linkmgrd][202012] update submodule 0179207 (HEAD -> 202012, origin/202012) [202012][active-standby] Enforce switchover based on heartbeats when mux probe keeps failing sonic-net#184 (sonic-net#197) sign-off: Jing Zhang [email protected]

…onic-net#14071) Why I did it [Ci] Fix the no parallel jobs in some of the platforms issue We observed some of the pipelines running more time than expected. The issue is the SONIC_BUILD_JOBS using the wrong value 1. It is caused by the runtime variable issue, there is additional single quota mark character added in the make command line. make 'SONIC_BUILD_JOBS=$(nproc)' targe/xxxx Need to change to make SONIC_BUILD_JOBS=$(nproc) targe/xxxx It is to improve the build performance for some of the platforms using the variable SONIC_BUILD_JOBS=1. Good one vs: https://dev.azure.com/mssonic/build/_build/results?buildId=227986&view=logs&j=cef3d8a9-152e-5193-620b-567dc18af272&t=cf595088-5c84-5cf1-9d7e-03331f31d795 "SONIC_BUILD_JOBS" : "8" Bad one barefoot: https://dev.azure.com/mssonic/build/_build/results?buildId=227379&view=logs&j=993d6e22-aeec-5c03-fa19-35ecba587dd9&t=7be0d2ec-661f-5569-462c-2d9b7ca4ca5d "SONIC_BUILD_JOBS" : "1" How I did it Expand the BUILD_OPTIONS variable for all platforms.

sonic-net#14636) Update golang version for telemetry build in sonic-slave-jessie to fix CVE-2021-33195, this PR will be merged into 201911 branch finally. #### Why I did it Go before 1.15.13 and 1.16.x before 1.16.5 has functions for DNS lookups that do not validate replies from DNS servers, and thus a return value may contain an unsafe injection (e.g., XSS) that does not conform to the RFC1035 format. Now in 201911 and 202012 branch we're using 1.14.2 ##### Work item tracking - Microsoft ADO **(number only)**:17727291 #### How I did it Bump golang version into 1.15.15 which contains corresponding fix. #### How to verify it unit test to do sanity check.

…lity (sonic-net#14558) #### Why I did it Cherry-pick commits from master to support the snapshot based mirror, and fix the code conflicts. And add the last commit to fix the build broken issue according to the mirror change. ad162ae [Build] Optimize the version control for Debian packages (sonic-net#14557) 38c5d7f [Build] Support j2 template for debian sources for docker ptf (sonic-net#13198) 5e4826e [Ci] Support to use the same snapshot for all platform builds (sonic-net#13913) 8206925 [Build] Change the default mirror version config file (sonic-net#13786) 5e4a866 [Build] Support Debian snapshot mirror to improve build stability (sonic-net#13097) ac5d89c [Build] Support j2 template for debian sources (sonic-net#12557)

…tty not running to avoid false alert. (sonic-net#14402) (sonic-net#14755) [S6100] Improve S6100 serial-getty monitor, wait and re-check when getty not running to avoid false alert. This is cherry-pick PR for: sonic-net#14402 #### Why I did it On S6100, the serial-getty service some time can't auto-restart by systemd. So there is a monit unit to check serial-getty service status and restart it. However, this monit will report false alert, because in most case when serial-getty not running, systemd can restart it successfully. To avoid the false alert, improve the monitor to wait and re-check. Steps to reproduce this issue: 1. User login to device via console, and keep the connection. 2. User login to device via SSH, check the [email protected] service, it's running. 3. Run 'monit reload' from SSH connection. 4. Check syslog 1 minutes later, there will be false alert: ' 'serial-getty' process is not running' ##### Work item tracking - Microsoft ADO :17424426 #### How I did it Add check-getty.sh script to recheck again later when getty service not running. And update monit unit to check serial-getty service status with this script to avoid false alert. #### How to verify it Pass all UT. Manually check fixed code work correctly: ``` admin@***:~$ sudo systemctl stop [email protected] admin@***:~$ sudo /usr/local/bin/check-getty.sh admin@***:~$ echo $? 1 admin@***:~$ sudo systemctl status [email protected] ● [email protected] - Serial Getty on ttyS1 Loaded: loaded (/lib/systemd/system/[email protected]; enabled-runtime; vendor preset: enabled) Active: inactive (dead) since Tue 2023-03-28 07:15:21 UTC; 1min 13s ago admin@***:~$ sudo /usr/local/bin/check-getty.sh admin@***:~$ echo $? 0 admin@***:~$ sudo systemctl status [email protected] ● [email protected] - Serial Getty on ttyS1 Loaded: loaded (/lib/systemd/system/[email protected]; enabled-runtime; vendor preset: enabled) ``` syslog: ``` Mar 28 07:10:37.597458 *** INFO systemd[1]: [email protected]: Succeeded. Mar 28 07:12:43.010550 *** ERR monit[593]: 'serial-getty' status failed (1) -- no output Mar 28 07:12:43.010744 *** INFO monit[593]: 'serial-getty' trying to restart Mar 28 07:12:43.010846 *** INFO monit[593]: 'serial-getty' stop: '/bin/systemctl stop [email protected]' Mar 28 07:12:43.132172 *** INFO monit[593]: 'serial-getty' start: '/bin/systemctl start [email protected]' Mar 28 07:13:43.286276 *** INFO monit[593]: 'serial-getty' status succeeded (0) -- no output ``` #### Tested branch (Please provide the tested image version) - [x] 20201231.77 #### Description for the changelog [S6100] Improve S6100 serial-getty monitor.

Why I did it Innovium platform has build issue. Remove it from upgrade version pipeline. Work item tracking Microsoft ADO (number only): How I did it How to verify it

Why I did it Fix similar issue seen on sonic-net#13739 but only for DCS-7050CX3-32S How I did it Add a kernel parameter to tell libata to disable NCQ How to verify it The message ata2.00: FORCE: horkage modified (noncq) should appear on the dmesg. Test results using: fio --direct=1 --rw=randrw --bs=64k --ioengine=libaio --iodepth=64 --runtime=120 --numjobs=4 with NCQ READ: bw=26.1MiB/s (27.4MB/s), 26.1MiB/s-26.1MiB/s (27.4MB/s-27.4MB/s), io=3136MiB (3288MB), run=120053-120053msec WRITE: bw=26.3MiB/s (27.6MB/s), 26.3MiB/s-26.3MiB/s (27.6MB/s-27.6MB/s), io=3161MiB (3315MB), run=120053-120053msec without NCQ READ: bw=22.0MiB/s (23.1MB/s), 22.0MiB/s-22.0MiB/s (23.1MB/s-23.1MB/s), io=2647MiB (2775MB), run=120069-120069msec WRITE: bw=22.2MiB/s (23.3MB/s), 22.2MiB/s-22.2MiB/s (23.3MB/s-23.3MB/s), io=2665MiB (2795MB), run=120069-120069msec

#### Why I did it sonic-utilities submodule update for 202012 ``` * d20fc3c8 2023-04-07 | [202012][DBMigrator] Update db_migrator to support EdgeZoneAggregator Buffer Config for T0s (sonic-net#2768) (HEAD, origin/202012) [Dev Ojha] * 322a74dd 2023-03-27 | Resolved rc!=0 problem by replacing fgrep with awk. Added ipv4 filtering to get only v4 peers in case of show ip bgp neighbors (sonic-net#2743) [saurabhab] ``` ##### Work item tracking - Microsoft ADO **(number only)**: 20782336

Using timer-override.conf, we modify the fstrim.timer service. For armhf, Nokia-7215 platform, we modify fstrim.timer to run daily instead of weekly. This is required because the size of the SSD on this platform is 16GB, which on average is nearly 10 times smaller than most other sonic platforms. With smaller disk and the ever increasing level of logging done by sonic, this change is required to prevent the SSD from entering a read-only state due to inadequate free blocks.

#### Why I did it [Build] Upgrade the python docker version to fix bgp not up issue ##### Work item tracking - Microsoft ADO **(number only)**: 22236397

#### Why I did it Update 202012 sonic-telemetry submodule head ##### Work item tracking - Microsoft ADO **(number only)**:16208453

…matically (sonic-net#15035) Why I did it src/sonic-py-swsssdk * d44e0d8 - (HEAD -> 202012, origin/202012) [Security] Fix the redis security issue CVE-2023-28858 and CVE-2023-28859 (sonic-net#135) (3 days ago) [xumia]

…atically (sonic-net#14944) #### Why I did it src/sonic-telemetry ``` * 6dc4bb9 - (HEAD -> 202012, origin/202012) Merge pull request sonic-net#107 from zbud-msft/backport-202012 (33 hours ago) [Tomek Madejski] * cbb7b1e - Update azp yml to generalize branch names (sonic-net#106) (7 days ago) [Zain Budhwani] ```

sonic-net#14862) #### Why I did it src/linkmgrd ``` * 35f7d1c - (HEAD -> 202012, origin/202012) [202012][active-standby][bsl] fix no mux probe issue sonic-net#201 (sonic-net#206) (2 weeks ago) [Jing Zhang] * be701fb - [202012] pick codeql fixes (sonic-net#207) (2 weeks ago) [Jing Zhang] * 0b42cec - Enable debug symbols (sonic-net#199) (3 weeks ago) [Longxiang Lyu] ```

* To resolve NEIGH table entries present in CONFIG_DB. Without this change arp/ndp entries which we wish to resolve, and configured via CONFIG_DB are not resolved.

… debs (sonic-net#12823) Ubuntu 22.04 leverages Zstandard compression to dpkg by default. Debian doesn't support it yet https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=892664 Fix sonic-net#12822 Signed-off-by: Cédric Ollivier <[email protected]>

Updated for commit: f141880 - 2023-04-26 : [bugfix] vnet ping missing with secondary endpoints empty in priority routes. (sonic-net#2736) (sonic-net#2747) [siqbal1986]

Fix armhf and arm64 build issue. Revert sonic-net#7517. Because armhf and arm64 agents are ready. Microsoft ADO (number only): 23765181

Why I did it Remove 'kvmtest-t0' and 'kvmtest-t1-lag' test jobs since all the test jobs are required (continueOnError: false) already, and will only enable one of classical and testbedV2 tests, no need to do an unnecessary 'or' compute test job. Change agent pool to reduce cost and avoid congestion

Why I did it Advance sonic-utilities submodule head Added below commits: 878be48e kellyyeh Wed May 10 15:21:52 2023 -0700 Revert "[warm-reboot] Use kexec_file_load instead of kexec_load when available 094513f8 Vaibhav Hemant Dixit Tue May 9 13:03:52 2023 -0700 [202012] LAG keepalive script to reduce lacp session wait during warm-reboot Work item tracking Microsoft ADO (number only): 23687678

…1846) (sonic-net#15087) #### Why I did it Fix endless build log issue. Cherry pick [PR#11846](sonic-net#11846) ##### Work item tracking - Microsoft ADO **(number only)**: 19299131 #### How I did it The current error handling code for when a deb package fails to be installed currently has a chain of commands linked together by && and ends with `exit 1`. The assumption is that the commands would succeed, and the last `exit 1` would end it with a non-zero return code, thus fully failing the target and causing the build to stop because of bash's -e flag. However, if one of the commands prior to `exit 1` returns a non-zero return code, then bash won't actually treat it as a terminating error. From bash's man page: ``` -e Exit immediately if a pipeline (which may consist of a single simple command), a list, or a compound command (see SHELL GRAMMAR above), exits with a non-zero status. The shell does not exit if the command that fails is part of the command list immediately following a while or until keyword, part of the test following the if or elif reserved words, part of any command executed in a && or || list except the command following the final && or ||, any command in a pipeline but the last, or if the command's return value is being inverted with !. If a compound command other than a subshell returns a non-zero status because a command failed while -e was being ignored, the shell does not exit. ``` The part `part of any command executed in a && or || list except the command following the final && or ||` says that if the failing command is not the `exit 1` that we have at the end, then bash doesn't treat it as an error and exit immediately. Additionally, since this is a compound command, but isn't in a subshell (subshell are marked by `(` and `)`, whereas `{` and `}` just tells bash to run the commands in the current environment), bash doesn't exist. The result of this is that in the deb-install target, if a package installation fails, it may be infinitely stuck in that while-loop. There are two fixes for this: change to using a subshell, or use `;` instead of `&&`. Using a subshell would, I think, require exporting any shell variables used in the subshell, so I chose to change the `&&` to `;`. In addition, at the start of the subshell, `set +e` is added in, which removes the exit-on-error handling of bash. This makes sure that all commands are run (the output of which may help for debugging) and that it still exits with 1, which will then fully fail the target. #### How to verify it

Why I did it Run kvmtest when update package versions to avoid test break. Work item tracking Microsoft ADO (number only): 22335854 How I did it How to verify it

Why I did it Release Notes for Cisco 8102-64H: Updated mtd-utils.mk and pyudev.mk for addressing build failures How I did it Update platform version to 202012.3.0.1

…ate to Elastictest (sonic-net#15257)

… flags (sonic-net#15303)

Fix for SR 695336631. x86 FPGA FPD needs to be upgraded to ver 1.88

…ded (sonic-net#14933) Why I did it Fix the issue where db_migrator is called before DB is loaded w/ config. This leads to db_migrator: Not finding anything, and resumes to incorrectly migrate every missing config This is not expected. migration should happen after the old config is loaded and only new schema changes need migration. Since DB does not have anything when migrator is called, db_migrator fails when some APIs return None. The reason for incorrect call is that: database service starts db_migrator as part of startup sequence. config-setup service loads data from old-config/minigraph. However, since it has Requires=database.service. Hence, config-setup starts only when database service is started. And database service is started when db_migrator is completed. Fixed by: Check if this is first time boot by checking pending_config_migration flag. If pending_config_migration is enabled, then do not call db_migrator as part of database service startup. Let database service start which triggers config-setup service to start. Now call db_migrator after when config-setup service loads old-config/minigraph

Changes in MRVL_PRESTERA_DRIVER_1.1_1: - Memory leak fixed by adding missing releasing pci device. Change-Id: I15a20412eac066894d4ddbebd58e1f127a20d968 Signed-off-by: Pavan Naregundi <[email protected]>

Why I did it Cherry-pick of sonic-net#11827 This is to fix issue: [201811->202012] During warm recovery, TOR did not announce Loopback, VLAN route after upgrade Suspected cause: 202012 does not have system dependency for bgp service to start after interfaces-config.service. This opens a window for race condition: bgp service completing before interfaces are initialized. BGP will miss announcing some routes if the interfaces are not ready.

Cherrypick sonic-net#12381 into 202012 Reverts sonic-net#15312 Work item tracking Microsoft ADO (number only): 24163872

…5309) Why I did it Set build options in pipeline UI. Support setting reproducible build options to py2,py3 in release branch and none in master branch. Work item tracking Microsoft ADO (number only): 22335854 How I did it How to verify it

…e cleaned up after swss restart. (sonic-net#15398) * [cleanup] tables VNET_MONITOR, BFD_SESSION, ROUTE_TUNNEL

sonic-net#13812) (sonic-net#15459) Why I did it Fix all mirror is commented out in sources.list in slave image issue. It will have an issue when installing more packages in the slave container. It will add additional space character after running add-apt-repository command. For example: The original config in /etc/apt/sources.list #deb [arch=amd64] http://deb.debian.org/debian/ bullseye main contrib non-free Run the following command: add-apt-repository "deb [arch=amd64] https://download.docker.com/linux/debian bullseye stable" Then the setting changed to: (added a new space character after #) # deb [arch=amd64] http://deb.debian.org/debian/ bullseye main contrib non-free How I did it Fix the regex string to add the space pattern. After fixed, whether there is a space character or not, it will not be an issue. How to verify it Co-authored-by: xumia <[email protected]>

#### Why I did it fix possible cpld race read issue between watchdog and reboot cause process ##### Work item tracking - Microsoft ADO **(number only)**: #### How I did it Use flock to limit parallel access to cpld sys file #### How to verify it It can be simulate and verified with following python script ```python3 import signal import subprocess import threading exit_flag = False def run_command(cmd): status = True result = "" try: p = subprocess.Popen( cmd, shell=True, universal_newlines=True, stdout=subprocess.PIPE, stderr=subprocess.PIPE) raw_data, err = p.communicate() if err == '': result = raw_data.strip() except: status = False return status, result def get_cpld_reg_value(getreg_path, register): #cmd = "echo {1} > {0}; cat {0}".format(getreg_path, register) cmd = "flock {0} -c 'echo {1} > {0}; cat {0}'".format(getreg_path, register) status, result = run_command(cmd) return result if status else None def cpld_read(thread_num, cpld_reg): while not exit_flag: val = get_cpld_reg_value("/sys/devices/platform/dx010_cpld/getreg", cpld_reg) print(f"Thread {thread_num}: get cpld reg {cpld_reg}, value {val}") def signal_handler(sig, frame): global exit_flag print("Ctrl+C detected. Quitting...") exit_flag = True if __name__ == '__main__': # Register the signal handler for Ctrl+C signal.signal(signal.SIGINT, signal_handler) t1 = threading.Thread(target=cpld_read, args=(1, '0x103',)) t2 = threading.Thread(target=cpld_read, args=(2, '0x141',)) t1.start() t2.start() t1.join() t2.join() ```

…ic-net#14401) (sonic-net#15571)

…onic-net#15582) [Ci] Support to build sonic-swss-common for test - Microsoft ADO **(number only)**: 24341479

…g is loaded (sonic-net#14933)" (sonic-net#15464) This reverts commit 02b1783. Reverts sonic-net#14933 The earlier commit caused a race condition that particularly broke cross branch warm upgrade. Issue happens when db_migrator is still migrating the DB and finalizer is checking DB for list of components to reconcile. If migration is not complete, finalizer get an empty list to wait for. Due to this, finalizer concludes warmboot (deletes system wide warmboot flag) and cause all the services to do cold restart. ADO: 24274591

BACKPORT OF sonic-net#14925 #### Why I did it ISSU version check fails due to inability to mount squashfs from 202211 on 201911 #### How I did it Put ISSU version file under platform directory #### How to verify it 202012 (with [202012][mlnx-ffb.sh] Update issu-version location sonic-net#14927) to master

#### Why I did it Aikido FPD update, power CPLD version display under fwutil CLI and fix for cpu lockup causing telemetry container crash or system reboot ##### Work item tracking - Microsoft ADO **(number only)**: 24174212 #### How I did it update cisco module to 202012.3.1.1

…ic-net#15630) Cherry pick PR for sonic-net/sonic-host-services#62 #### Why I did it Fix the issue sonic-net#10883. ##### Work item tracking - Microsoft ADO **(17795594)**: #### How I did it For performance reason, libswsscommon is not thread safe by design. caclmgrd share config DB connection cross thread, so change to use new db connector in child thread. #### How to verify it Load scale ipv4/ipv6 rules and verify if caclmgrd is crashed

…atically (sonic-net#15543) #### Why I did it src/sonic-telemetry ``` * 56aa539 - (HEAD -> 202012, origin/202012) Fix sonic-mgmt-common version in pipeline build (sonic-net#124) (2 weeks ago) [Sachin Holla] * 4264949 - Change log level (sonic-net#118) (4 weeks ago) [Zain Budhwani] ```

…AD (sonic-net#15532) #### Why I did it Update submodule sonic-utilities to the latest HEAD ``` 50296b90 - [202012][dhcp-relay] Fix dhcp6relay counter issue (sonic-net#2866) (sonic-net#2873) (Fri Jun 30 18:08:53 2023 +0800) <Yaqiang Zhu> 160030c4 - [202012][dhcp_relay] Add "Reconfigure", "Information-Request", "Malformed" counter options (sonic-net#2844) (Sun Jun 11 20:35:30 2023 -0700) <kellyyeh> e6289ced - [vlan][dhcp_relay] Clear dhcpv6 relay counter while deleting vlan (sonic-net#2852) (Fri Jun 2 18:20:21 2023 +0000) <Yaqiang Zhu> 885082ec - correctly parsing complete ipv6 vnet info (sonic-net#2827) (Thu May 25 06:01:40 2023 +0000) <Keith Lu> ``` ##### Work item tracking - Microsoft ADO 22635770

Why I did it Refine PR test template format. How I did it Refine PR test template format. How to verify it PR test executed normally. Signed-off-by: Chun'ang Li <[email protected]>

…net#15719) Backport sonic-net#15461 #### Why I did it * To fix `hiredis` compilation #### How I did it * Changed package version: `0.14.0-3~bpo9+1` -> `0.14.1-1` #### How to verify it 1. make configure PLATFORM=mellanox 2. make target/sonic-mellanox.bin #### Tested branch (Please provide the tested image version) - [X] 202012

…ry leak issue. (sonic-net#8659) (sonic-net#15703) This pull request extract tacacs support functions into library to share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. #### Why I did it To support TACACS per command authorization, we need reuse the TACACS config file parse code in bash plugin project. ##### Work item tracking - Microsoft ADO **(number only)**: 24433713 #### How I did it Add libtacsupport.pc.in to extract tacacs support functions into library. Fix memory leak issue in TACACS config parse code by convert the dynamic memory allocation memory to static memory allocation. #### How to verify it Pass all current UT. Check shared library generated manually. #### Tested branch (Please provide the tested image version) Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. - [ ] SONiC.202012-15703.306864-1ef589c19 #### Description for the changelog Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code.

…o support TACACS+ per-command authorization&accounting.(sonic-net#9029) (sonic-net#15718) This pull request add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting. ##### Work item tracking - Microsoft ADO **(number only)**: 24433713 #### Why I did it Support TACACS per-command authorization&accounting. #### How I did it Change ConfigDB schema and HostCfg enforcer. Add UT to cover changed code. #### How to verify it Build following project and pass all UTs: make target/python-wheels/sonic_host_services-1.0-py3-none-any.whl #### Which release branch to backport (provide reason below if selected) N/A #### Tested branch (Please provide the tested image version) Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. - [ ] SONiC.202012-15723.309781-38d8852cd #### Description for the changelog Add Config DB schema and HostCfg Enforcer plugin to support TACACS+ per-command authorization&accounting.

sonic-utilities submodule update #### Why I did it sonic-utilities submodule update: ``` 399b1e3 2023-07-06 [202012][Show][BGP] Show BGP Change for no neighbor scenario (sonic-net#2886) 7b47641 2023-07-10 [[202012] [TACACS+] Add config command for AAA authorization and accounting. (sonic-net#1889) ``` ##### Work item tracking - Microsoft ADO **(number only)**:24433713 #### How I did it Update sonic-utilities submodule. #### How to verify it Pass all test case. #### Tested branch (Please provide the tested image version) - [ ] SONiC.202012-15703.306864-1ef589c19

…nic-net#8750) (sonic-net#15788) This pull request integrate audisp-tacplus to SONiC for per-command accounting. ##### Work item tracking - Microsoft ADO **(number only)**: 24433713 #### Why I did it To support TACACS per-command accounting, we integrate audisp-tacplus project to sonic. #### How I did it 1. Add auditd service to SONiC 2. Port and patch audisp-tacplus to SONiC #### How to verify it UT with CUnit to cover all new code in usersecret-filter.c Also pass all current UT. #### Tested branch (Please provide the tested image version) Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. - [ ] SONiC.202012-15723.312602-e230e2d3e #### Description for the changelog Add audisp-tacplus for per-command accounting.

Fix libtacsupport.so can't parse tacplus_nss.conf issue and not reset server list before parse config file issue. ##### Work item tracking - Microsoft ADO **(number only)**: 24433713 #### Why I did it 1. Fix libtacsupport.so can't parse tacplus_nss.conf correctly issue: Support debug=on setting. Support put server address and secret in same row. 2. Fix the parse_config_file method not reset server list before parse config file issue. #### How I did it Fix libtacsupport.so can't parse tacplus_nss.conf issue and not reset server list before parse config file issue. #### How to verify it UT with CUnit cover all code in this plugin. Also pass all current UT. #### Which release branch to backport (provide reason below if selected) N/A #### Tested branch (Please provide the tested image version) Extract tacacs support functions into library, this will share TACACS config file parse code with other project. Also fix memory leak issue in parse config code. - [ ] SONiC.202012-15723.312602-e230e2d3e #### Description for the changelog Fix libtacsupport.so can't parse tacplus_nss.conf issue and not reset server list before parse config file issue.

) #### Why I did it cherry pick, sonic-net#15535 Graceful restart is a key event for bgpd, related log print is debug level. To change it to info level to get more visibilities when this kind of event is triggered. ##### Work item tracking - Microsoft ADO **(13875291)**: #### How I did it To create patch file to change from debug level to info level. #### How to verify it To run PR test and capture the print.

…5890) Why I did it Fix the armhf build failure. How to reproduce the issue: docker run -it debain:bullseye bash apt-get update && apt-get install -y python3-pip pip3 install PyYAML==5.4.1 Error message: Collecting PyYAML==5.4.1 Installing build dependencies ... done Getting requirements to build wheel ... error ERROR: Command errored out with exit status 1: command: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl .... raise AttributeError(attr) AttributeError: cython_sources ---------------------------------------- WARNING: Discarding https://files.pythonhosted.org/packages/a0/a4/d63f2d7597e1a4b55aa3b4d6c5b029991d3b824b5bd331af8d4ab1ed687d/PyYAML-5.4.1.tar.gz#sha256=607774cbba28732bfa802b54baa7484215f530991055bb562efbed5b2f20a45e (from https://pypi.org/simple/pyyaml/) (requires-python:>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*, !=3.5.*). Command errored out with exit status 1: /usr/bin/python3 /tmp/tmp6xabslgb_in_process.py get_requires_for_build_wheel /tmp/tmp_er01ztl Check the logs for full command output. ERROR: Could not find a version that satisfies the requirement PyYAML==5.4.1 ERROR: No matching distribution found for PyYAML==5.4.1 root@fa2fa92edcfd:/# But if adding the option --no-build-isolation, then it is good, see fix. install "PyYAML==5.4.1" --no-build-isolation The same error can be found in the multiple builds. Work item tracking Microsoft ADO (number only): 24567457 How I did it Add a build option --no-build-isolation.

Fix pyyang issue 202012 #15902

Fix pyyang issue 202012 #15902

Commits on Oct 19, 2022

Commits on Oct 20, 2022

Commits on Oct 21, 2022

Commits on Oct 25, 2022

Commits on Oct 26, 2022

Commits on Oct 27, 2022

Commits on Oct 28, 2022

Commits on Oct 30, 2022

Commits on Oct 31, 2022

Commits on Nov 1, 2022

Commits on Nov 2, 2022

Commits on Nov 5, 2022

Commits on Nov 6, 2022

Commits on Nov 7, 2022

Commits on Nov 8, 2022

Commits on Nov 9, 2022

Commits on Nov 10, 2022

Commits on Nov 11, 2022

Commits on Nov 13, 2022

Commits on Nov 15, 2022

Commits on Nov 16, 2022

Commits on Nov 17, 2022

Commits on Nov 18, 2022

Commits on Nov 20, 2022

Commits on Nov 23, 2022

Commits on Nov 24, 2022

Commits on Nov 27, 2022

Commits on Nov 29, 2022

Commits on Nov 30, 2022

Commits on Dec 2, 2022

Commits on Dec 4, 2022

Commits on Dec 5, 2022

Commits on Dec 7, 2022

Commits on Dec 8, 2022

Commits on Dec 10, 2022

Commits on Dec 17, 2022

Commits on Dec 22, 2022

Commits on Dec 23, 2022

Commits on Dec 25, 2022

Commits on Dec 27, 2022

Commits on Dec 28, 2022

Commits on Jan 1, 2023

Commits on Jan 2, 2023

Commits on Jan 3, 2023

Commits on Jan 4, 2023

Commits on Jan 10, 2023

Commits on Jan 12, 2023

Commits on Jan 13, 2023

Commits on Jan 16, 2023

Commits on Jan 17, 2023

Commits on Jan 18, 2023

Commits on Jan 19, 2023

Commits on Jan 25, 2023

Commits on Jan 26, 2023

Commits on Jan 28, 2023

Commits on Jan 30, 2023

Commits on Feb 2, 2023

Commits on Feb 6, 2023

Commits on Feb 7, 2023

Commits on Feb 8, 2023

Commits on Feb 9, 2023

Commits on Feb 10, 2023

Commits on Feb 14, 2023

Commits on Feb 16, 2023

Commits on Feb 17, 2023

Commits on Feb 19, 2023

Commits on Feb 20, 2023

Commits on Feb 21, 2023

Commits on Feb 22, 2023

Commits on Feb 23, 2023

Commits on Feb 24, 2023

Commits on Feb 25, 2023

Commits on Feb 26, 2023

Commits on Feb 28, 2023

Commits on Mar 2, 2023

Commits on Mar 4, 2023

Commits on Mar 7, 2023

Commits on Mar 8, 2023