Celestica Seastone DX010-C32: show platform firmware updates

[FunForNOS]

Description

the command show platform firmware updates fails with a chassis names mismatch instead of listing updates.

Steps to reproduce the issue:

1. Install Sonic 202111 or 202205
2. log in as admin
3. issue command show platform firmware updates

Describe the results you received:

Output:

admin@sonic:~$ show platform firmware updates
Error: Chassis names mismatch: keys=['Celestica-DX010-C32', 'Seastone-DX010']. Aborting...
Aborted!

Describe the results you expected:

The command shows available updates, e.g. works as designed.

Output of show version:

admin@sonic:~$ show version

SONiC Software Version: SONiC.202111.114441-e8daeacd3
Distribution: Debian 11.3
Kernel: 5.10.0-8-2-amd64
Build commit: e8daeacd3
Build date: Sat Jun 25 20:00:32 UTC 2022
Built by: AzDevOps@sonic-build-workers-001OKA

Platform: x86_64-cel_seastone-r0
HwSKU: Seastone-DX010
ASIC: broadcom
ASIC Count: 1
Serial Number: N/A
Model Number: N/A
Hardware Revision: N/A
Uptime: 08:39:01 up 30 min,  4 users,  load average: 0.83, 0.75, 0.63

Docker images:
REPOSITORY                    TAG                       IMAGE ID       SIZE
docker-syncd-brcm             202111.114441-e8daeacd3   4e27432ac89d   798MB
docker-syncd-brcm             latest                    4e27432ac89d   798MB
docker-gbsyncd-credo          202111.114441-e8daeacd3   c5b0c92c4048   474MB
docker-gbsyncd-credo          latest                    c5b0c92c4048   474MB
docker-dhcp-relay             latest                    cce38ba00022   433MB
docker-orchagent              202111.114441-e8daeacd3   796c0264eafe   452MB
docker-orchagent              latest                    796c0264eafe   452MB
docker-nat                    202111.114441-e8daeacd3   34369d8e429f   437MB
docker-nat                    latest                    34369d8e429f   437MB
docker-fpm-frr                202111.114441-e8daeacd3   eb901261db6f   452MB
docker-fpm-frr                latest                    eb901261db6f   452MB
docker-macsec                 202111.114441-e8daeacd3   d281120d993c   437MB
docker-macsec                 latest                    d281120d993c   437MB
docker-teamd                  202111.114441-e8daeacd3   9b811857fff6   434MB
docker-teamd                  latest                    9b811857fff6   434MB
docker-sonic-telemetry        202111.114441-e8daeacd3   e52bf76682eb   508MB
docker-sonic-telemetry        latest                    e52bf76682eb   508MB
docker-snmp                   202111.114441-e8daeacd3   39ca86f575d8   463MB
docker-snmp                   latest                    39ca86f575d8   463MB
docker-platform-monitor       202111.114441-e8daeacd3   523fd8aacfdb   684MB
docker-platform-monitor       latest                    523fd8aacfdb   684MB
docker-sonic-mgmt-framework   202111.114441-e8daeacd3   896fb274c5a8   574MB
docker-sonic-mgmt-framework   latest                    896fb274c5a8   574MB
docker-sflow                  202111.114441-e8daeacd3   f31496b8f1ea   435MB
docker-sflow                  latest                    f31496b8f1ea   435MB
docker-router-advertiser      202111.114441-e8daeacd3   179f73576642   420MB
docker-router-advertiser      latest                    179f73576642   420MB
docker-lldp                   202111.114441-e8daeacd3   2ce7f21a190c   460MB
docker-lldp                   latest                    2ce7f21a190c   460MB
docker-mux                    202111.114441-e8daeacd3   e4a843de630d   472MB
docker-mux                    latest                    e4a843de630d   472MB
docker-database               202111.114441-e8daeacd3   bbfb5876af97   420MB
docker-database               latest                    bbfb5876af97   420MB

Output of show techsupport:

[sonic_dump_sonic_20220702_083918.tar.gz](https://github.com/Azure/sonic-buildimage/files/9032791/sonic_dump_sonic_20220702_083918.tar.gz)

[salvadorb]

I'm facing exactly the same problem

[qnos]

PR #13356 fix this issue.

[prgeor]

with PR 13356 this issue is now broken @assrinivasan FYI

root@str2-dx010-acs-7:~# show platform firmware updates
Error: Chassis names mismatch: keys=['Seastone-DX010', 'Celestica-DX010-C32']. Aborting...
Aborted!
root@str2-dx010-acs-7:~# 
root@str2-dx010-acs-7:~# 
root@str2-dx010-acs-7:~# show platform summary
Platform: x86_64-cel_seastone-r0
HwSKU: Celestica-DX010-C32
ASIC: broadcom
ASIC Count: 1
root@str2-dx010-acs-7:~#

[qnos]

with PR 13356 this issue is now broken @assrinivasan FYI

root@str2-dx010-acs-7:~# show platform firmware updates
Error: Chassis names mismatch: keys=['Seastone-DX010', 'Celestica-DX010-C32']. Aborting...
Aborted!
root@str2-dx010-acs-7:~# 
root@str2-dx010-acs-7:~# 
root@str2-dx010-acs-7:~# show platform summary
Platform: x86_64-cel_seastone-r0
HwSKU: Celestica-DX010-C32
ASIC: broadcom
ASIC Count: 1
root@str2-dx010-acs-7:~#

Hi prgeor,

Seems your build customized the default SKU to Celestica-DX010-C32, but community default SKU is Seastone-DX010. All SKUs shared the same platform.json, so the chassis name in platform.json could not match every SKU. If so, I think some additional mechanisms should be introduced for the mismatch issue. How do you think about it?

[FunForNOS]

Can confirm this bug is fixed. Tested with build id 207726.