Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add shellcheck and mock modules for running unit and linter test #14062

Merged
merged 1 commit into from
Mar 3, 2023

Conversation

vaibhavhd
Copy link
Contributor

Why I did it

Add shellcheck Linux utility : to enable linter check on bash scripts

Add mock pip module: to enable running unit tests on sonic-mgmt container

How I did it

Added shellcheck and mock

How to verify it

Verified these new packages by manually installting and using them for upgrade path tests.

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211

Description for the changelog

Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@vaibhavhd vaibhavhd requested a review from lguohan as a code owner March 2, 2023 22:21
@vaibhavhd vaibhavhd requested review from wangxin and yxieca March 2, 2023 22:21
@mssonicbld
Copy link
Collaborator

@vaibhavhd PR conflicts with 202205 branch

xumia pushed a commit to xumia/sonic-buildimage-1 that referenced this pull request Mar 10, 2023
@yxieca
Copy link
Contributor

yxieca commented Mar 15, 2023

@vaibhavhd please create a separate PR for 202205 branch.

@liuh-80
Copy link
Contributor

liuh-80 commented Mar 28, 2023

Manually cherry-pick PR created: #14432

qiluo-msft pushed a commit that referenced this pull request Mar 30, 2023
)

#### Why I did it
This is a cherrypick of #14062 on 202012 branch
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants