[Buffer] Added cable length config to buffer config template for EdgeZoneAggregator #14280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neethajohn
reviewed
Mar 16, 2023
| @@ -0,0 +1,2869 @@ | |||
| <DeviceMiniGraph xmlns="Microsoft.Search.Autopilot.Evolution" xmlns:i="http://www.w3.org/2001/XMLSchema-instance"> | |||
There was a problem hiding this comment.
can you model Arista-7060CX-32S-D48C8 instead? That is the hwsku that connects to EdgeZoneAggregator
| </ManagementAddress> | ||
| <HwSku>Arista-VM</HwSku> | ||
| </Device> | ||
| <Device i:type="LeafRouter"> |
There was a problem hiding this comment.
Make all the neighbors of type EdgeZoneAggregator
There was a problem hiding this comment.
Ok, but this has no effect on cable length since the rest of the neighbors are all leaf routers.
There was a problem hiding this comment.
This is just to mimic actual environment where all neighbors are EdgeZone devices
Signed-off-by: dojha <[email protected]>
Signed-off-by: dojha <[email protected]>
|
@developfast , I think this change cannot be cleanly cherry-picked into 202012. Please check and raise a separate PR if needed |
neethajohn
approved these changes
Mar 17, 2023
yxieca
approved these changes
Mar 17, 2023
|
@developfast PR conflicts with 202205 branch |
mssonicbld
pushed a commit
to mssonicbld/sonic-buildimage
that referenced
this pull request
Mar 19, 2023
…ZoneAggregator (sonic-net#14280) Why I did it SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1. How I did it Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router. How to verify it Unit tests pass, and manually checked on a 7260 to see the changes take effect. Signed-off-by: dojha <[email protected]>
|
Cherry-pick PR to 202211: #14340 |
mssonicbld
added
Included in 202211 Branch
and removed
Approved for 202211 Branch
Created PR to 202211 Branch
labels
mssonicbld
pushed a commit
that referenced
this pull request
Mar 20, 2023
…ZoneAggregator (#14280) Why I did it SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1. How I did it Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router. How to verify it Unit tests pass, and manually checked on a 7260 to see the changes take effect. Signed-off-by: dojha <[email protected]>
developfast
added
Created PR to 202205 Branch
and removed
Cherry Pick Conflict_202205
labels
developfast
added
Created PR to 202012 Branch
and removed
Cherry Pick Conflict_202012
labels
qiluo-msft
pushed a commit
that referenced
this pull request
Apr 10, 2023
…for EdgeZoneAggregator (#14539) #### Why I did it SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1. Original PR for master: #14280 #### How I did it Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router. #### How to verify it Unit tests pass, and manually checked on a 7260 to see the changes take effect. #### Description for the changelog [Buffer] Added cable length config to buffer config template for EdgeZoneAggregator
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1.
How I did it
Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router.
How to verify it
Unit tests pass, and manually checked on a 7260 to see the changes take effect.
Which release branch to backport (provide reason below if selected)
Description for the changelog
[Buffer] Added cable length config to buffer config template for EdgeZoneAggregator
Ensure to add label/tag for the feature raised. example - PR#2174 under sonic-utilities repo. where, Generic Config and Update feature has been labelled as GCU.
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)