Skip to content

Commit

Permalink
[Buffer] Added cable length config to buffer config template for Edge…
Browse files Browse the repository at this point in the history
…ZoneAggregator (#14280)

Why I did it
SONiC currently does not identify 'EdgeZoneAggregator' neighbor. As a result, the buffer profile attached to those interfaces uses the default cable length which could cause ingress packet drops due to insufficient headroom. Hence, there is a need to update the buffer templates to identify such neighbors and assign the same cable length as used by the T1.

How I did it
Modified the buffer template to identify EdgeZoneAggregator as a neighbor device type and assign it the same cable length as a T1/leaf router.

How to verify it
Unit tests pass, and manually checked on a 7260 to see the changes take effect.

Signed-off-by: dojha <[email protected]>
  • Loading branch information
developfast authored Mar 17, 2023
1 parent 96817c4 commit de17f72
Show file tree
Hide file tree
Showing 5 changed files with 1,940 additions and 4 deletions.
3 changes: 3 additions & 0 deletions files/build_templates/buffers_config.j2
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,9 @@ def
{%- if DEVICE_NEIGHBOR_METADATA is defined and DEVICE_NEIGHBOR_METADATA[DEVICE_NEIGHBOR[local_port].name] %}
{%- set neighbor = DEVICE_NEIGHBOR_METADATA[DEVICE_NEIGHBOR[local_port].name] %}
{%- set neighbor_role = neighbor.type %}
{%- if 'edgezoneaggregator' == neighbor_role | lower %}
{%- set neighbor_role = 'LeafRouter' %}
{%- endif %}
{%- if 'asic' == neighbor_role | lower %}
{%- set roles1 = 'internal' %}
{%- if 'internal' not in ports2cable %}
Expand Down
Loading

0 comments on commit de17f72

Please sign in to comment.