[armhf][Nokia-7215] changes fstrim.timer to daily #14723

jon-nokia · 2023-04-19T13:09:32Z

Using override.conf, we modify the fstrim.timer service.

For armhf, Nokia-7215 platform, we modify fstrim.timer to run daily
instead of weekly. This is required because the size of the SSD on
this platform is 16GB, which on average is nearly 10 times smaller than
most other sonic platforms. With smaller disk and the ever increasing
level of logging done by sonic, this change is required to prevent
the SSD from entering a read-only state due to inadequate free blocks.

Why I did it

Required to prevent the SSD from entering a read-only state due to inadequate free blocks

Work item tracking

Microsoft ADO (number only):

How I did it

How to verify it

Verified that override works.

admin@sonic-amazon:~$ sudo systemctl status fstrim.timer 
\u25cf fstrim.timer - Discard unused blocks daily
     Loaded: loaded (/lib/systemd/system/fstrim.timer; enabled; vendor preset: enabled)
    Drop-In: /usr/lib/systemd/system/fstrim.timer.d
             \u2514\u2500timer-override.conf
     Active: active (waiting) since Thu 2023-04-27 14:14:18 UTC; 36min ago
    Trigger: Fri 2023-04-28 00:00:00 UTC; 9h left
   Triggers: \u25cf fstrim.service
       Docs: man:fstrim

Apr 27 14:14:18 sonic systemd[1]: Started Discard unused blocks daily.
admin@sonic-amazon:~$ cat /usr/lib/systemd/system/fstrim.timer.d/timer-override.conf 
[Unit]
Description=Discard unused blocks daily

[Timer]
OnCalendar=daily
admin@sonic-amazon:~$

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

202012
master

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

jon-nokia · 2023-04-19T17:07:26Z

Additional reviewers @carl-nokia @mlok-nokia @Pavan-Nokia

prgeor · 2023-04-21T06:46:30Z

device/nokia/armhf-nokia_ixs7215_52x-r0/installer.conf

+
+if [ -r /host/machine.conf ]; then
+  # fstrim frequency to daily for our platform
+  desc="Discard unused blocks ($platform)"


@jon-nokia where is 'desc' used?

It's used in the sed command to change the description from "Discard unused blocks once a week". Since I was changing the OnCalendar value the description no longer made sense.

saiarcot895 · 2023-04-21T16:23:26Z

device/nokia/armhf-nokia_ixs7215_52x-r0/installer.conf

+  desc="Discard unused blocks ($platform)"
+  sed -i -e "s,OnCalendar=.*,OnCalendar=daily,g" \
+         -e "s,Description=.*,Description=$desc,g" \
+         /usr/lib/systemd/system/fstrim.timer


Instead of modifying the packaged file, please create an override file for this timer, in /etc/systemd/system/fstrim.timer.d/. This is far cleaner and less likely to break something in the case of some updates/changes.

Will do. That is much cleaner. Thank you.

Replaced original commit with this use of override.conf.

saiarcot895 · 2023-04-24T22:13:48Z

platform/marvell-armhf/sonic-platform-nokia/debian/sonic-platform-nokia-7215.install

@@ -1,5 +1,6 @@
 nokia-7215_plt_setup.sh usr/sbin
 7215/scripts/nokia-7215init.sh  usr/local/bin
 7215/service/nokia-7215init.service  etc/systemd/system
+7215/service/fstrim.timer/override.conf  /etc/systemd/system/fstrim.timer.d


Ah, if installing in a package, it's better to have it be in /lib/systemd/system/fstrim.timer.d. Also, I'd recommend naming it something besides override.conf, in case there happens to be some conflict (which is unlikely).

For /etc/systemd, I followed your example as well as that of the file, nokia-7215init.service. I'm not sure when to use /etc/systemd vs /lib/systemd and what the convention really is. Are you sure we need to change this?

The /etc/systemd directory is meant for service files and overrides that are created by the system administrator. These are generally not installed through a package. The /lib/systemd directory are for service files that do come from a package. See this for a more detailed description.

I would recommend following the convention, at least for consistency. At the very least, since override.conf is a common name for service file overrides, and since this is coming from a package, I'd highly recommend renaming this file.

@saiarcot895, Please check if the latest update is satisfactory. Thanks

Using timer-override.conf, we modify the fstrim.timer service. For armhf, Nokia-7215 platform, we modify fstrim.timer to run daily instead of weekly. This is required because the size of the SSD on this platform is 16GB, which on average is nearly 10 times smaller than most other sonic platforms. With smaller disk and the ever increasing level of logging done by sonic, this change is required to prevent the SSD from entering a read-only state due to inadequate free blocks.

prgeor · 2023-04-28T18:10:09Z

@jon-nokia have you tested this new change?

jon-nokia · 2023-04-28T18:22:33Z

@jon-nokia have you tested this new change?

Yes, I posted results in verification section for you just now.

prgeor · 2023-04-28T23:49:50Z

@lguohan please help merge this PR

prgeor · 2023-05-02T01:47:27Z

@lguohan please help merge this PR

@lguohan could you merge

Using timer-override.conf, we modify the fstrim.timer service. For armhf, Nokia-7215 platform, we modify fstrim.timer to run daily instead of weekly. This is required because the size of the SSD on this platform is 16GB, which on average is nearly 10 times smaller than most other sonic platforms. With smaller disk and the ever increasing level of logging done by sonic, this change is required to prevent the SSD from entering a read-only state due to inadequate free blocks.

mssonicbld · 2023-05-11T03:13:43Z

Cherry-pick PR to 202012: #15015

Using timer-override.conf, we modify the fstrim.timer service. For armhf, Nokia-7215 platform, we modify fstrim.timer to run daily instead of weekly. This is required because the size of the SSD on this platform is 16GB, which on average is nearly 10 times smaller than most other sonic platforms. With smaller disk and the ever increasing level of logging done by sonic, this change is required to prevent the SSD from entering a read-only state due to inadequate free blocks.

mssonicbld · 2023-05-17T20:59:11Z

Cherry-pick PR to 202211: #15125

mssonicbld · 2023-05-17T20:59:12Z

Cherry-pick PR to 202205: #15126

jon-nokia marked this pull request as ready for review April 19, 2023 17:05

jon-nokia requested a review from lguohan as a code owner April 19, 2023 17:05

prgeor reviewed Apr 21, 2023

View reviewed changes

saiarcot895 reviewed Apr 21, 2023

View reviewed changes

jon-nokia force-pushed the jon-dev branch from 6ce9d00 to c0eb504 Compare April 24, 2023 13:29

saiarcot895 reviewed Apr 24, 2023

View reviewed changes

prgeor previously approved these changes Apr 25, 2023

View reviewed changes

prgeor added the Platform: Nokia label Apr 25, 2023

jon-nokia dismissed prgeor’s stale review via 5a0e960 April 27, 2023 15:01

jon-nokia force-pushed the jon-dev branch from c0eb504 to 5a0e960 Compare April 27, 2023 15:01

saiarcot895 approved these changes Apr 27, 2023

View reviewed changes

prgeor approved these changes Apr 28, 2023

View reviewed changes

prgeor added Request for 202012 Branch Request for 202205 Branch Request for 202211 Branch labels Apr 28, 2023

lguohan merged commit 0692e8a into sonic-net:master May 3, 2023

liuh-80 added the Approved for 202012 Branch label May 11, 2023

mssonicbld added the Created PR to 202012 Branch label May 11, 2023

mssonicbld mentioned this pull request May 11, 2023

[action] [PR:14723] [armhf][Nokia-7215] changes fstrim.timer to daily #15015

Merged

mssonicbld added Included in 202012 Branch and removed Approved for 202012 Branch labels May 11, 2023

mssonicbld removed the Created PR to 202012 Branch label May 11, 2023

yxieca added Approved for 202205 Branch Approved for 202211 Branch labels May 17, 2023

mssonicbld added the Created PR to 202211 Branch label May 17, 2023

mssonicbld added the Created PR to 202205 Branch label May 17, 2023

This was referenced May 17, 2023

[action] [PR:14723] [armhf][Nokia-7215] changes fstrim.timer to daily #15125

Merged

[action] [PR:14723] [armhf][Nokia-7215] changes fstrim.timer to daily #15126

Merged

mssonicbld added a commit that referenced this pull request May 17, 2023

[armhf][Nokia-7215] changes fstrim.timer to daily (#14723) (#15125)

17771ef

mssonicbld added Included in 202211 Branch and removed Approved for 202211 Branch Created PR to 202211 Branch labels May 17, 2023

mssonicbld added a commit that referenced this pull request May 18, 2023

[armhf][Nokia-7215] changes fstrim.timer to daily (#14723) (#15126)

f6bd817

mssonicbld added Included in 202205 Branch and removed Approved for 202205 Branch Created PR to 202205 Branch labels May 18, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[armhf][Nokia-7215] changes fstrim.timer to daily #14723

[armhf][Nokia-7215] changes fstrim.timer to daily #14723

jon-nokia commented Apr 19, 2023 •

edited

Loading

jon-nokia commented Apr 19, 2023

prgeor Apr 21, 2023

jon-nokia Apr 21, 2023

saiarcot895 Apr 21, 2023

jon-nokia Apr 21, 2023

jon-nokia Apr 24, 2023

saiarcot895 Apr 24, 2023

jon-nokia Apr 25, 2023

saiarcot895 Apr 26, 2023

jon-nokia Apr 27, 2023

prgeor commented Apr 28, 2023

jon-nokia commented Apr 28, 2023

prgeor commented Apr 28, 2023

prgeor commented May 2, 2023

mssonicbld commented May 11, 2023

mssonicbld commented May 17, 2023

mssonicbld commented May 17, 2023

[armhf][Nokia-7215] changes fstrim.timer to daily #14723

[armhf][Nokia-7215] changes fstrim.timer to daily #14723

Conversation

jon-nokia commented Apr 19, 2023 • edited Loading

Why I did it

Work item tracking

How I did it

How to verify it

Which release branch to backport (provide reason below if selected)

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

jon-nokia commented Apr 19, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

prgeor commented Apr 28, 2023

jon-nokia commented Apr 28, 2023

prgeor commented Apr 28, 2023

prgeor commented May 2, 2023

mssonicbld commented May 11, 2023

mssonicbld commented May 17, 2023

mssonicbld commented May 17, 2023

jon-nokia commented Apr 19, 2023 •

edited

Loading